Path: csiph.com!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Piotr =?utf-8?Q?O=C5=BCarowski?= Newsgroups: linux.debian.maint.python Subject: Re: packaging django-rest-framework-filters Date: Thu, 29 Nov 2018 14:10:02 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Nov 29 13:00:43 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-6.999 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, HEADER_FROM_DIFFERENT_DOMAINS=0.001, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -6.1 Mail-Followup-To: debian-python@lists.debian.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180223 X-Mailing-List: archive/latest/16588 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20181129130023.xc3y5lchvomgvbw6@sar0.p1otr.com Approved: robomod@news.nic.it Lines: 28 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Thu, 29 Nov 2018 14:00:23 +0100 X-Original-Message-ID: <20181129130023.xc3y5lchvomgvbw6@sar0.p1otr.com> X-Original-References: <20181122050200.tcg7urpyqjd5rx7n@mail.wookware.org> <48711e64-382f-e89f-81a3-4b5f69788905@debian.org> <20181129114444.0ff6bd4e@calvin.codehelp> <3808513.Eq8BaGn0ig@kitterma-e6430> Xref: csiph.com linux.debian.maint.python:11144 [Scott Kitterman, 2018-11-29] > dh-python already doesn't use upstream version requirements when automatically > extracting dependencies, so you have to check those yourself regardless of how > you do it. This design decision was based on generally poor experiences with > the accuracy of upstream version descriptions (using exact version > requirements is very common in the upstream Python community and that > generally isn't supportable in Debian). actually dh_python{2,3} extracts it, but only if package maintainer of given module claims it is sane (via PEP386 tag in pydist file) f.e. I consider Mako's versioning sane, so I added PEP386 tag to pydist file in src:mako and now all packages that have "Mako>=1.0.3" in setup.py's install_requires AKA requires.txt (do not confuse with requirements.txt) will get the dependency. Another way to get versioned dependency is to add version restriction in Build-Depends (but that has to be updated each time upstream changes it, it needs to be done for build tests anyway). This is only a bit better than hardcoding it in Depends, though. Note that it doesn't cover the "I tested it with latest Mako so lets require latest one in install_requires" case, so I'm not promoting PEP386 that much (IMO package maintainers have to translate minimum required versions into proper Build-Depends dependencies by hand for now) -- GPG: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645