Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Sergio Durigan Junior Newsgroups: linux.debian.maint.python,linux.debian.devel.mentors Subject: Re: RFS: pcapy/0.11.3-1 [ITA] Date: Sat, 16 Jun 2018 21:50:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Sat Jun 16 19:39:39 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.951 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, LDO_WHITELIST=-5, MENTORSRFS=-0.3, PGPSIGNATURE=-5] autolearn=unavailable autolearn_force=no X-Policyd-Weight: using cached result; rate: -6.1 X-URL: http://blog.sergiodj.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailing-List: archive/latest/16055 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/87k1qywmgp.fsf@debian.org Approved: robomod@news.nic.it Lines: 141 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python , "python-modules-team\@lists.alioth.debian.org" , Debian Mentors List X-Original-Date: Sat, 16 Jun 2018 15:38:46 -0400 X-Original-Message-ID: <87k1qywmgp.fsf@debian.org> X-Original-References: Xref: csiph.com linux.debian.maint.python:10646 linux.debian.devel.mentors:41246 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Control: owner -1 ! Control: tags -1 + moreinfo On Thursday, June 07 2018, eamanu wrote: > Dear mentors, > > I am looking for a sponsor for my package "pcapy" > > * Package name : pcapy > Version : 0.11.3-1 > Upstream Author : Core Security > * URL : https://github.com/CoreSecurity/pcapy > * License : Apache Software License > Section : python > > It builds those binary packages: > > python-pcapy - Python interface to the libpcap packet capture library > > To access further information about this package, please visit the > following URL: > > https://mentors.debian.net/package/pcapy > > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/p/pcapy/pcapy_0.11.3-1.dsc > > More information about hello can be obtained from https://www.example.com. > > Changes since the last upload: > > [ Jakub Wilk ] > * Use canonical URIs for Vcs-* fields. > > [ Ond=C5=99ej Nov=C3=BD ] > * Fixed VCS URL (https) > * d/control: Set Vcs-* to salsa.debian.org > * d/changelog: Remove trailing whitespaces > * Remove debian/pycompat, it's not used by any modern Python helper > > [ Emmanuel Arias ] > * new upstream version > * update d/watch to download correctly the last upstream version > * update d/control to add Maintainer the DPMT > * update d/control to add me to Uploaders field (Closes: #895787) > * update debhelper on d/contorl from 5.0.37.2 to 11 > * update Standards-Version from 3.9.2 to 4.1.4 on d/control > * add Testsuite: autopkgtest-pkg-python on d/control > * update d/compat from 5 to 11 > * add to copyright file the debian files copyright Hi Emmanuel, Thanks for the package, and for your interest in adopting it! The first question I have is about the VCS. I tried finding your commits on the official Salsa repo, but wasn't able to. Are you using any other repository for that? It's much easier to review the changes when there's a repository, and I strongly suggest you use the official one for the packaging. As for the review, here's what I'd like you to address: 1) d/copyright should follow DEP-5. Take a look at: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ and you'll be able to find instructions on the format of the file. It shouldn't be too hard for you to convert the existing file. 2) The package doesn't need CDBS anymore, so you can safely remove it from the Build-Depends line. 3) The "Homepage" field can have a better URL: https://www.coresecurity.com/corelabs-research/open-source-tools/pcapy 4) You should consider packaging a Python 3 package, as well as the Python 2 you're already packaging (in which case you could probably split the documentation part into its own package). If Python 3 is not supported, you should contact upstream and probably file a bug against it. 5) Any reason why the package has "Suggests: doc-base"? 6) It's a good habit to export the PYBUILD_NAME variable (on d/rules): export PYBUILD_NAME=3Dpcapy This variable tells pybuild what's the name of your project. 7) It's a good idea to use (on d/rules): export DEB_BUILD_MAINT_OPTIONS =3D hardening=3D+all since your package is building a shlib. 8) The package is installing the LICENSE file by default, but this is not needed since we have the d/copyright file. Therefore, it'd be good if you could remove this file from the package. You can do that by e.g. overriding dh_auto_install and rm'ing the file there. I think that's basically everything I've spotted. Please let me know if you need any help. Cheers, =2D-=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEI3pUsQKHKL8A7zH00Ot2KGX8XjYFAlslZ0YACgkQ0Ot2KGX8 XjbY2RAArBzeszjtBGGrJvmPh8i1eQbYLQd5SrtkY+n3Mt0c3yFW0SR24uemH8Be eAF9Iy8Er3vkEjbIpUvw/VyhV9XpeT62sHvt3UbJqMhVSh2yOJPN9E2jvlzeMiPx Yhq9/0mzNmZVCD9IAVUteyNE/gbuKPPCYmYhLfwy/BBgbj4jcn7hZzy9IvewxO1b RMgMdN0NxKrlmhp78N3t2T/b8ABeVBlxNytN0xZOsrxG02YoTtwTBypBeiQZdTMw CwUox+vYQxKNqlY/d1lJ8wTZ1Ky0fbgF0gtW/JdTpiIACuwnaN3+Vrdgz1zpcmrF ZNoWpOM3+q+NxdwvvoSJ2Mfy4kzWuQbgX9jPpN4o1AyBqj+IR+onFToXzic/NofF UwxFcDUn57st30/iNaRRxvEdEjl52/5K5WxYpSRfqg7lQawyMhNzGI4mzN73kNKr atndR7qoJJBiwttaQ1o9ZTBb8qziSjifBIdhAdaQhV9xpDVWkujQsHneQYZPREt6 7iShEp7y0W59oVrw70dkcT1T8uaazbSf25sV7Aq6hzpWhDPeCQ8bCuQU8qJADlF7 92ECGrFiEbF0oYZWBUlaE0xGuSJrxv6RgY8bdVOtBEscqCUQHWDfG36ALTa8e48z y4hAvQQWgKa0PBoF1NFRcXHF9apDrWKkg4A+BH99Yimf6gJaND8= =ghxb -----END PGP SIGNATURE----- --=-=-=--