Path: csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod From: Harlan Lieberman-Berg Newsgroups: linux.debian.maint.python Subject: Re: Certbot DNS Dependencies Date: Sat, 03 Mar 2018 03:10:01 +0100 Message-ID: References: X-Original-To: "Ana C. Custura" X-Mailbox-Line: From debian-python-request@lists.debian.org Sat Mar 3 02:06:11 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-4.9 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FOURLA=0.1, HTML_MESSAGE=2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=no autolearn_force=no X-Policyd-Weight: DYN_NJABL=SKIP(0) NOT_IN_SBL_XBL_SPAMHAUS=-1.5 BL_NJABL=SKIP(-1.5) CL_IP_EQ_HELO_IP=-2 (check from: .setec. - helo: .mail-vk0-x233.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -7 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=setec-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=isa9Mf12IEr884eMRet9gEhGU10F0WzSpEUdJB5PXIo=; b=z8T83UT/ky1yMwChibr4eqccmAZ7zWDto6Sp0WxhNY037K6Xg82vZxKzPG+3KqMacq j/zBze/jvTAyFFb1eCgfs+oN7zCKs58PzK0JIgFO6fTnY58ICo8JS0V+afBnNGgzgicF e/jTcrtqKjdXZuyOyRdHT9XVjG4jtw2nXXmTfTONCyQdib2WDs56y+ShBAAj6A+FxJmI ZZqcJSmWoQVNom8xCFE4i8KNgdaMX+0+KbWoLb+cmTwG4YkXB5j4jjU/ANH08QY9qF7U d/DZ28u5Ec5S/dBtnKt2TS04O1geDSWtm2O1QcH6e2gYODAQnmG5zkFyBSeHfgw47vrT XVeQ== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=isa9Mf12IEr884eMRet9gEhGU10F0WzSpEUdJB5PXIo=; b=TLRO0AXvqFM1nzHzaZsOzjG07BIu+i1QcYD6uzGxspx/oCXom9EYNk4JUyj0+z5wQ9 ilxSfY654x0QMvFenBWW56ZZ4TOzoWYbV19lxoP7tblcRwxytWOlQWCeoczTqop0wQuw DC24cFdMOgv4sGcuLL9lOVbhvQUn/YYz64KgLbckl/DTSLyFnURmW1vQVWl7lHD7Bwli YlU+Tqm764/g9dT2+0Un/zgGkWxzHjL7M4amtkooGPqLqq+MUKkssUJ+2P+DhmShorQU 3MpHwgri8NDnSYrOrlDeHaFXq9dgbqrAbutMsuJD9TWobGJetmkH1BtuFKCwJT6dPEA2 GH7A== X-Gm-Message-State: APf1xPBp2iGKnC16HFutdL65Yb08QuzyE9pTbgioxU81kKKEZQMx6WFo DBSVuv/pHxfA6N2/8RLMJAsspHQYZmmO12LdDVElAA== X-Google-SMTP-Source: AG47ELvu1W2x/QufQe7GfD/b1+vDvSkm3U5QYGDnP0gTwlouv/rGFKb8HxX5eK5KZvgjd2nN1N2YjgtnLpy25acedgE= X-Received: by 10.31.73.129 with SMTP id w123mr5497690vka.102.1520041736364; Fri, 02 Mar 2018 17:48:56 -0800 (PST) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114d66f6bd76ab0566784ba9" X-Mailing-List: archive/latest/15615 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAEri_iFzGJJd4MnybeO4jDF+eum-BhzpWF_JEL8eWm9MM+Tycg@mail.gmail.com Approved: robomod@news.nic.it Lines: 194 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Brad Warren , debian-python@lists.debian.org X-Original-Date: Fri, 2 Mar 2018 20:48:56 -0500 X-Original-Message-ID: X-Original-References: <1519592811.2179177.1282897096.147F8709@webmail.messagingengine.com> <1520037437.3469398.1289767168.45B07A5E@webmail.messagingengine.com> Xref: csiph.com linux.debian.maint.python:10220 --001a114d66f6bd76ab0566784ba9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Ana! These look to be in good shape in general. For the VCSs', you have two options; if you want to join DPMT, you could put them under their hierarchy, or you could use the Debian heirarchy and I can grant you permissions for the repos. Let me know which one you'd prefer to do. I do have one tweak I'd like to see for python-tldextract; I think we should have it Recommend `publicsuffix` and add that to the list of PUBLIC_SUFFIX_LIST_URLs. Please test it to make sure it works even without that file; reading the code, it looks like it should, but I'd like to double check. For python-lexicon, it's generally considered good practice to use the same license for the work under debian/ as the rest of the package is. If the difference was intentional, I'd want to know more about why you feel the difference is important. Let me know if you have questions; a couple of minor changes and I think they're about ready to ship! On Fri, Mar 2, 2018 at 7:37 PM, Ana C. Custura wrote: > Hi Harlan, > > Thank you for your email, I've had some time to look at them and both ar= e > now on mentors: > https://mentors.debian.net/package/tldextract > https://mentors.debian.net/package/lexicon > > I would also like to push to salsa, but need help with getting access to > repositories and/or teams. I've left the vcs fields pointing to > salsa.debian.org/debian for now. > > Some notes: > tldextract: > -uses a writable cache file which ends up in usr/share with the wrong > permissions during the installation. I moved this to the user's homedir. > > lexicon: > - some optional dependencies still need to be packaged to make some > provider-specific functionality work; I filed ITPs for python3-pynamechea= p > and python3-transip [ #891944 and #891945 ] > - it looks like tests fail with pybuild because they need to run from a > specific directory, so dh_auto_test is overridden with a custom command. > > All feedback is much appreciated, and thanks again! > > Ana > > On Sun, Feb 25, 2018, at 9:27 PM, Harlan Lieberman-Berg wrote: > > On Sun, Feb 25, 2018 at 16:06 Ana C. Custura wrote: > > Thank you for the email! > Yes I'm almost there with tldextract and I've partly packaged lexicon too= , > but forgot pick up the ITP for it. I'm not a DD yet, so my for new > packages I need a sponsor - would you like to be the one to review them a= nd > upload them? > > > That=E2=80=99s awesome! I just took care of python-cloudflare last night,= so > that=E2=80=99s the list. > > Happy to sponsor them for you. Push them up to mentors and ping me when > you=E2=80=99re ready! > > Sincerely, > > > -- > Harlan Lieberman-Berg > ~hlieberman > > > --=20 Harlan Lieberman-Berg ~hlieberman --001a114d66f6bd76ab0566784ba9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Ana!

These look to be = in good shape in general.=C2=A0 For the VCSs', you have two options; if= you want to join DPMT, you could put them under their hierarchy, or you co= uld use the Debian heirarchy and I can grant you permissions for the repos.= =C2=A0 Let me know which one you'd prefer to do.

I do have one tweak I'd like to see for python-tldextract; I thi= nk we should have it Recommend `publicsuffix` and add that to the list of P= UBLIC_SUFFIX_LIST_URLs.=C2=A0 Please test it to make sure it works even wit= hout that file; reading the code, it looks like it should, but I'd like= to double check.

For python-lexicon, it's gen= erally considered good practice to use the same license for the work under = debian/ as the rest of the package is.=C2=A0 If the difference was intentio= nal, I'd want to know more about why you feel the difference is importa= nt.

Let me know if you have questions; a couple of= minor changes and I think they're about ready to ship!
<= br>

On= Fri, Mar 2, 2018 at 7:37 PM, Ana C. Custura <ana@netstat.org.uk>= wrote:
Hi Harlan,

Thank you for your email,=C2=A0 I've had some time to look at the= m and both are now on mentors:

I would also like to push to salsa, but need help with getting access = to repositories and/or teams. I've left the vcs fields pointing to salsa.debian.org/= debian for now.

Some notes:
tldextract:
-uses a writable cache file which ends up in usr/share=C2=A0 with the = wrong permissions during the installation. I moved this to the user's h= omedir.

lexicon:
- some optional dependencies still need to be packaged to make some pr= ovider-specific functionality work; I filed ITPs for python3-pynamecheap an= d python3-transip [ #891944 and #891945 ]
- it looks like tests fail with pybuild because they need to run from = a specific directory,=C2=A0 so dh_auto_test is overridden with a custom com= mand.

All feedback is much appreciated, and thanks again!
=

Ana

On Sun, Feb 25, 2018, at 9:27 PM, Harlan Lieberman-Berg wrote:
On Sun, Feb 25, 2018 at 16:06 Ana C. Custura= <ana@netstat.or= g.uk> wrote:
Thank you for the email!
Yes I'm almost there with tldextract and I've partly packaged= lexicon too, but forgot pick up the ITP for it.=C2=A0 I'm not a DD yet= , so my for new packages I need a sponsor - would you like to be the one to= review them and upload them?

That=E2=80=99s awesome! I just took care of python-cloudflare last nig= ht, so that=E2=80=99s the list.

Happy to sponsor them for you. Push them up to mentors and ping me whe= n you=E2=80=99re ready!

Sincerely,


--
Harlan Lieberman-Berg
~hlieberman




--
Harlan Lieberman-Berg
~hlieberman
--001a114d66f6bd76ab0566784ba9--