Path: csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: review for gtg/0.6-1 Date: Mon, 07 Nov 2022 14:40:01 +0100 Message-ID: References: X-Original-To: =?UTF-8?B?RnJhbsOnb2lz?= Mazen X-Mailbox-Line: From debian-python-request@lists.debian.org Mon Nov 7 13:30:29 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-115.024 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.1.1 (GTK 3.24.20; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/iJxLFCBYLg9qpwI7578eOS5"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/20461 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20221107142929.4766273b@debian.org Approved: robomod@news.nic.it Lines: 75 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Mon, 7 Nov 2022 14:30:05 +0100 X-Original-Message-ID: <20221107142929.4766273b@debian.org> X-Original-References: <20221101135247.3fd5ebe0@debian.org> <41b5143ec8d706ae4c0bd67d91c3a48eb842e137.camel@mzf.fr> Xref: csiph.com linux.debian.maint.python:14608 --Sig_/iJxLFCBYLg9qpwI7578eOS5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 4 Nov 2022 16:07:56 +0100 Fran=C3=A7ois Mazen wrote: Thank you for making all those improvements. > > * copyright: > > =C2=A0+ public domain without explanation detailing exactly what > > exemption the files in question have from default copyright > > restrictions. =20 >=20 > I don't know what do you expect here. The current description > contains "No copyright is claimed". What should I add?=20 Copyright restrictions apply by default, so for something to be in the public domain requires some explicit statement to that effect by the copyright holder. While d/copyright says "No copyright is claimed" (which may or may not serve that purpose, depending on context) I cannot find that particular statement anywhere in the source. Where does it come from, who wrote it? (Or am I just overlooking something obvious?) > > * autopkgtests: > > =C2=A0+ consider adding an autopkgtest based on the upstream > > testsuite. =20 >=20 > The upstream provides two test datasets but no associated tests for > the installed application. Should I write them myself? (would be > quite complex as it's a graphical interface) Tests don't necessarily have to be for the application as a whole, not to mention the existing 'smoke' and 'check-graphical-app' cover that part already. With the Debian CI triggering an autopkgtest run for gtg every time there's a change in a dependency, running an upstream testsuite that tests bits and pieces of code can still be useful for finding incompatibilities such changes may introduce. Also, testsuites based on pytest tend to be straightforward to turn into an autopkgtest, see for example [1] and [2]. I noticed on salsa that the updated d/rules tries to run the upstream testsuite during build but it errors out during test collection (and that error in turn doesn't trigger build failure). [1]https://salsa.debian.org/python-team/packages/puremagic/-/tree/master/de= bian/tests [2]https://salsa.debian.org/python-team/packages/nfoview/-/blob/debian/mast= er/debian/tests/upstream-pytest --Sig_/iJxLFCBYLg9qpwI7578eOS5 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmNpCF0ACgkQQoMEoXSN zHom4BAAw8GMf41twMEhGjB2mSnqiMOzxdGiSAi23ThlrXmqOek5fp/76RbWxfXp cl3CpWpqTkBHmVvj7Yr93FNk/yToBpi/RfUEjhgR5n98wHuj6rDsYPRzeb6ZZPso zc68keebUuKnc9wRe96Uv/uvwvdZRLnlJJE3vbreI5wQvv2tH8dUbqvZkdBw/0eM P/1YHIPnjmgQTEmW219TnnvP806WWwdb6FtlNhzQy/2QJ+fOCD0rCs8uDD0AvmXg mcZd2+IcxgozQWxPiNwGpCtkWj1edp0eb8prOshN8hEdXb/WSe2NlFObIuI4d6cS MSYqB7lcGXL1nwCr60qKCQrwMSHSqgKMFGOn+7fo3CY+c/vgonMjsu+YeN2BHqbZ rVUzg/OzXds9f06jJ6pusGX4vPS6/3sl51qGx+A+wghFjz+6VdPxTqJs7gGd8sBs 5fdPPpm5shtGpH1TmsdevkAcQbwjyZZZBXMi3ZCk3k149aOc9aBI/J/zJsb993OJ o/hJ5o3kr3qyUwrmQ8NiqVgPgUnWAcLrmkh+CrvDagm3mgUP6mxF2B2c07orB9tj RMdVSPUh2waMCQqo1hoRVClZiHKfvvmeMfoATOK5U8vWrF9n5en3lCodji8Fb5Xj 60c2p5Rsa0+PSUOwAR2jZO72WtHwkjDCY3hHyXkloiZ0kIVWu5o= =2ia4 -----END PGP SIGNATURE----- --Sig_/iJxLFCBYLg9qpwI7578eOS5--