Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: review for gtg/0.6-1 Date: Tue, 01 Nov 2022 14:00:01 +0100 Message-ID: X-Original-To: francois@mzf.fr X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Nov 1 12:53:19 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.224 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, SARE_ADLTOBFU=0.68, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.1.0 (GTK 3.24.20; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/L=VG0q1yh83OlFUJz5qRz3t"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/20428 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20221101135247.3fd5ebe0@debian.org Approved: robomod@news.nic.it Lines: 104 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Tue, 1 Nov 2022 13:52:47 +0100 X-Original-Message-ID: <20221101135247.3fd5ebe0@debian.org> Xref: csiph.com linux.debian.maint.python:14576 --Sig_/L=VG0q1yh83OlFUJz5qRz3t Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable hi Francois, I took a look at the gtg package put up for sponsorship in the Python team: * changelog: + multiple entries for revisions that did enter the archive (0.3.1-2 through 4) appear to have gone missing? + there's about a dozen open bugs against the old package, yet only a single one gets closed. Did you review the outstanding bugs and check if any of them are fixed by the new upstream release and/or the revamped packaging? + it's team policy to keep the target distribution at UNRELEASED while a package is under review. + ITP bug not closed upon package reintroduction? * clean: consider converting the entries for deleting pycache stuff at depths other than 3 to also use globbing. =20 * control: + long description should be extended. Assume the reader knows little or nothing about the application at all; what can it do, what makes it special, what services does it integrate with, and so on. Take a look at the upstream homepage if you need inspiration. + why list the old maintainer as uploader? + multiple missing dependencies for utilities called by script_pocketmod. + missing dep gir1.2-secret-1 (for the optional import of gi.repository.Secret in GTG/core/keyring.py) + missing dep for optional import of gi.repository.GnomeKeyring in GTG/core/keyring.py (though it seems that's not yet packaged in Debian so we might have to forego it for now). + missing dep gir1.2-pango-1.0 (for the unconditional import of Pango in GTG/gtk/browser/treeview_factory.py and other files; as well as PangoCairo in GTG/gtk/browser/cell_renderer_tags.py) + unused build-dep on itstool? + lots of build-deps only appear useful for testing; please mark those . * copyright: + public domain without explanation detailing exactly what exemption the files in question have from default copyright restrictions. + GTG/plugins/dev_console/* headers say LGPL, not GPL. + one Jean-Fran=C3=A7ois Fortin Tam is listed in the 'Files: *' paragraph, but only appears as a copyright holder in two files (GTG/core/info.py.in and a single translation). * docs: what purpose does a list of upstream authors serve as end user documentation? * patches: two out of three patches at first glance appear useful for inclusion upstream, yet all are marked 'Forwarded: not-needed'? * rules: + override_dh_auto_install starts by calling dh_auto_install; consider using execute_after_ instead of an override in such cases. + upstream testsuite (based on pytest) not run on build, why? * lintian: + X: gtg: executable-in-usr-lib usr/lib/python3/dist-packages/GTG/plugins/export/export_templates/script= _pocketmod (wrong install location per FHS?) + X: gtg: executable-in-usr-lib usr/lib/python3/dist-packages/GTG/core/networkmanager.py (imported as a python module, file probably shouldn't be executable at all?) * autopkgtests: + please change directory to $AUTOPKGTEST_TMP before running test commands to ensure the test doesn't depend on anything from the extracted source pkg, see best practices at [1]. + consider adding an autopkgtest based on the upstream testsuite. * source: variables not properly quoted in 'script_pocketmod', cannot handle spaces (etc.) in the path of the source file; please patch. Once the above comments have been addressed, simply re-add the package to the IRC channel topic. Note: I didn't do any functional testing yet, in light of the need for significant changes to the current packaging. [1]https://wiki.debian.org/ContinuousIntegration/AutopkgtestBestPractices --Sig_/L=VG0q1yh83OlFUJz5qRz3t Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmNhFqAACgkQQoMEoXSN zHqWZBAAjxH1UpQVS5ZcMV6ahuEFB/eQHiws8fgJ4gJnCB0Npa2t3vYewv7RDkV4 k3VFt36nFEzA1FmnrKrCO1eFa7APxDAFGzoGkC/IbXlxGWEqHYEZKNUDCWjiSQ9M bGQt84/36nneZh3wFvuRQHM6RQfqyWsomohxkz6f4jfeH5v9XVguSrs4z2DtMQbq 0Ta3AJNrP6Ipc1olF73BvDziVn8yH7w/NdLuOCdodEAywjnyggosMIBuLhcELeX0 LL0r7BKGy8JNIMU9agYoMgUgm1UAaeKJy4hrZV1KHXz7wEj1CrPZo99r0LXRc4FE f7cVQ0uaN01UExqluTMqRYQBcRwVz2dkBPqtm5LkskwIAde/FmSfU6Wbh/yChQrb ifOCZ7OXiJXIepX6+SOmDHNpadg3pzPGvANTMb6GWme7lQS+YcIorrdcF96y7Fo+ PYgSYzE6QuJK/mnnRbNHV+yvVjweVdnnPMJuiyzxj6JYBW2OUBJ1GI/8120CK+q4 P1Fj32l6ubGfYfaJ5Ig6K+zcUmrYEa8rv9JUlGtYhuprRw3uAFPflbIgDijWuTO+ HkAl8qPXBLaODd3wuBcJ+0m6FnG3gccgnnLaX68vPO08ipRHweuh1MwdXVcs/Hzs njvi6g0Ii73xmF3gAawiLyyIVJsnTmzAiFQGwSkEbHNPSu2qBeM= =m0Ld -----END PGP SIGNATURE----- --Sig_/L=VG0q1yh83OlFUJz5qRz3t--