Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Bo YU Newsgroups: linux.debian.maint.python Subject: Re: review for pygubu/0.27-1 Date: Mon, 26 Dec 2022 15:30:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Mon Dec 26 14:26:38 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.099 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, FREEMAIL_FROM=0.001, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no X-Policyd-Weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-vs1-xe2d.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5 X-Gm-Message-State: AFqh2koLEIy318h0P0LVLAckGs2GShsKldBNJMB7MfTbVPxBt8md2nTO dQEx3mVvUdp1ek1OSmo8pgZk4iK8F7wAHWwcweoF776/5rzEVmDk X-Google-SMTP-Source: AMrXdXvhnnJDlFAsr082g8MGviKNuOGDTqFkg0l8jvelSACwEqQ7ZH+SWQ3xyDAnghxnNcpARkt6kmKdM5FefMJyu6s= X-Received: by 2002:a67:f291:0:b0:3b2:e50f:ca09 with SMTP id m17-20020a67f291000000b003b2e50fca09mr2433879vsk.29.1672064775897; Mon, 26 Dec 2022 06:26:15 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Mailing-List: archive/latest/20648 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAKq8=3LPsTQ86Z9Mwa_FFEvoZ1puQ4EtWaTODrMtPy0eLvU_zg@mail.gmail.com Approved: robomod@news.nic.it Lines: 85 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Mon, 26 Dec 2022 22:26:04 +0800 X-Original-Message-ID: X-Original-References: <20221210111717.1e46a2c6@debian.org> Xref: csiph.com linux.debian.maint.python:14780 Hi, First sorry for the late reply. On Sat, Dec 10, 2022 at 6:17 PM Jeroen Ploemen wrote: > > hi Bo, > > my comments for the pygubu package up for sponsorship in the Python > team: > > * changelog: only a single entry is needed for an initial debian > release. > > * copyright: > + please remove the copyright statement at the start of the MIT > license paragraph so that it contains only the license terms; > + tests/support.py appears to be based on [1] (i.e. from upstream > python, license info at [2])? > > * control: > + do you need python3-tk for any other purpose than running tests? > If not, mark as !nocheck; > + "Description: Debian packaging for pygubu": you want to describe > pygubu itself here, not that it's packaged for Debian - every > package in the distribution is, after all. > It is easy to fix these above issues. > * rules: the script at development/runtests.sh simply calls "python3 > -m unittest" on the tests dir for the default python3 only, which > is not what you want. Consider letting pybuild (+pytest?) handle > things directly, for example by changing the override to something > like PYBUILD_SYSTEM=custom PYBUILD_TEST_ARGS="xvfb-run -a > {interpreter} -m pytest -v tests" dh_auto_test. Right, I *just* use custom testing scripts to test cases when building. But I am stuck in when I use PYBUILD_* something. I searched some code as example: ``` override_dh_auto_test: HOME=/tmp xvfb-run -a dh_auto_test \ -- --system=custom --test-args="cd tests; {interpreter} -m unittest -v" ``` But it works. (I should keep exploring the way you recommend). > > * tests: you don't want to hardcode dependencies on an autopkgtest > that should be pulled in by the binary package. Here I do not understand clearly when modifying it, I know you mean I should put some dependencies for autopkgtest in binary packages' B-D,but which packages should be put there[0]? ``` Depends: @, python3-all, tkcalendar, python3-tk, xvfb, xauth ``` Could you help me to understand it again?:) > There's a debian/.gitlab-ci.yml file but the CI isn't enabled in the > repository settings on salsa. Ok. I know how to turn on the CI button. > > The binary package seems to be missing dependencies on tk, pil > (conditional import at src/pygubu/stockimage.py:124), as well as a > large number of tk-related modules used by the plugins (tkcalendar, > awesometkinter, customtkinter, tkintertable, tkintermapview, tksheet; > most of these don't seem to be packaged yet). > Yeah, I think you are right. But I thought if autopkgtest is ok, the functions testing should be ok. I suspect that my understanding about autopkgtest this time. > Have you done any functional testing on a (reasonably clean) debian > testing or unstable install? I will do that. If it was you said[1], there are many works need to do.:) BR, Bo > [0]: https://salsa.debian.org/python-team/packages/pygubu/-/blob/debian/main/debian/control#L22 [1]: https://salsa.debian.org/python-team/packages/pygubu