Path: csiph.com!pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod From: Jonas Smedegaard Newsgroups: linux.debian.maint.python Subject: Re: Updating khal to fix RC bug #1023341 Date: Fri, 16 Dec 2022 19:00:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Fri Dec 16 17:52:02 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-10.18 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, FOURLA=0.1, LDO_WHITELIST=-5, MD5_SHA1_SUM=-1, MURPHY_DRUGS_REL8=0.02, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, SHIPPING_ID=3, SHIP_ID_INT=1] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -4.6 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="===============4239022003874447718==" MIME-Version: 1.0 Content-Disposition: inline User-Agent: alot/0.10 X-Mailing-List: archive/latest/20601 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/167121309501.2856.15916646856044364885@auryn.jones.dk Approved: robomod@news.nic.it Lines: 119 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Fri, 16 Dec 2022 18:51:35 +0100 X-Original-Message-ID: <167121309501.2856.15916646856044364885@auryn.jones.dk> X-Original-References: <167119984322.2856.7662918214150004490@auryn.jones.dk> Xref: csiph.com linux.debian.maint.python:14735 --===============4239022003874447718== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Quoting Jonas Smedegaard (2022-12-16 15:10:43) > Hi Daniele, and others, >=20 > Quoting Daniele Tricoli (2022-12-16 07:16:24) > > I tried to update khal to block the autoremoval from testing (due=20 > > #1023341) but it's not clear to me how to import metadata used to parse= =20 > > the package version with uscan=C2=B9 during repack of the tarball. > >=20 > > PKG-INFO and the egg.info directory are on salsa=C2=B9 upstream branch = but=20 > > I'm not able to see them in the upstream tarballs (I looked also the=20 > > commit on salsa with hash ba53a6bfb845ab4df3d5298f91f323b070084f4b):=20 > > also PKG-INFO in the root of the repository is a news to me. > >=20 > > How can I put them in the repacked tarball? In d/watch is indicated tha= t=20 > > for update the classic uscan invocation (through gbp) is used. > >=20 > > The only way I can think of is to manually repack (AFAIK uscan doesn't = > > support adding files before the invocation of mk-origtargz)... but it=20 > > not seems that this was the procedure used according documentation on=20 > > d/watch. > >=20 > > AFAIU this mechanism was introduced to fix #1002406.=C2=B3 > >=20 > > Jonas do you have the time to explain? >=20 > I will have a closer look now, then get back to you. >=20 > Ususally when I "look" at a package I routinely update it as well. > Would you prefer that I roll back whatever changes I do during my > "looking at it" and guide you to gain same understanding as me? > Because if your interest is simply to get khal updated then > simpler for me is do (hopefully) all myself and only tell you without > leaving room for you to redo and potentially learn more from that DIY > experience. I am happy to do that slower process - I find it fun to > collaborate (am just not very used to it), so please do tell if you are > eager to learn. :-) As you might have noticed by now, I took the liberty of releasing my changes when I understood what was going on - because by then I had a functioning package ready for upload. It was multiple layers of cause for confusion: First layer: Upstream uses setuptools-scm to resolve release version, which is bad because it makes assumptions about things outside of the project - specifically it interacts with VCS (meta)data and assumed that is not replaced by that of another distro by the time the project is built. So our packaging patches away the use of setuptools-scm. Second layer: Our replacement involved grep'ing for upstream release version from file PKG-INFO which, as you correctly point out, is missing from upstream tarball. It was however included in previous upstream tarball, so this is an upstream change. So our replacement needed to be adjusted (to now instead grep CHANGELOG). Third layer: Debian build routines call clean target regardless if patches are applied or unapplied. Our patch affects dh_auto_clean so our replacement is extended with checking if patch is applied and skipping dh_auto_clean when it isn't. This makes it appear as if our "clean" target succeeds easily leading to the wrong assumption (at least for me) that it must be something upstream that fails - something mysteriously looking for a missing PKG-INFO file... Hope that was understandable. I have now updated our replacement routines plus a range of other householding changes, and released the new packaging release. Thanks a lot for bringing it to my attention. In fact I had old work lying around locally from July 30th that had stalled at that exact same failure, so I myself was evidently baffled as well (and then got distracted by something else), despite my having introduced the patch myself. ...so I have now also sprinkled a few comments in debian/rules file, to aid future baffld Debian maintainers. - Jonas --=20 * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ * Sponsorship: https://ko-fi.com/drjones [x] quote me freely [ ] ask before reusing [ ] keep private --===============4239022003874447718== MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Description: signature Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAmOcsCIACgkQLHwxRsGg ASFoeg//bMh/e8VjIcloamTY8cbzuRqkc7h+dhyitoWuhbL5PChRO/FY5bnHmTgA aNxcPiwkXgVrSYWAL1kIS/NiW/C8GQv1Ui3sIgm+K7BR9uI8GLx5AKX4XeM/KcJb ZfVsa9uqWh+9hSVNrGj+zfJ+HbNSsIhq3F2P9zSy6B670QAl1eKsVEu1T3KH5MV8 vcSjTM5ysdvyKOKEEqHICC+ZIulSu9P/0vzFc8HBVR6Ib61qDJapDK94RBYI4TTd 4agJA095FyZvNpyRkXIB4sSCEWOVcaLv0Wq1lyj4cN7Tg4xafiuKd8JkCcTObVG+ 2zHq1lKOPKDxZ0Ct4D4Fh5h0wI8qkq9vPBBV55HOX8mlN4AvPQJ9HSjZPrA+LzQ0 zdKxXOsfGgfKhPgNL4PO9wEQq0kBTtrjp0Y4NVdgqejl76M9l9GSNWVaMqUDyVfR KQV3HjGxDHqIxp4YBtu8Gj++pP2+GrtX9QXL9fZzmfVWmYuSuY6wwM0n3HQlfHHd wrT4fQYjsRL+jqjn0GJT/Xojoom3ll0ddFLTkfHUoFovxCzl36FbFUU29+USzzMi xUlatDYUMcFEZUGlIrEvH+yyjKeJ5WxniEcoPD2MUnYirQE/0ZC9mPzW5lh+/svv oJ1Xag44tnwGXXkuk4dtggA1/iTZ8slFl87mpPfQDt92/d7uIYI= =JrkN -----END PGP SIGNATURE----- --===============4239022003874447718==--