Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Bo YU Newsgroups: linux.debian.bugs.dist,linux.debian.maint.python Subject: Bug#1007025: git-multimail 1.6.0 package review Date: Thu, 22 Sep 2022 11:10:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Thu Sep 22 09:06:10 2022 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -2.598 Reply-To: Bo YU , 1007025@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: wnpp@debian.org, vimer X-Debian-Pr-Message: followup 1007025 X-Debian-Pr-Package: wnpp X-Gm-Message-State: ACrzQf3KV3B0AiPqWQQxhBcTMC4yIQteA4r4tsU/7reY72jaMimaNFg+ IsRSa/PhqhGUb8JbADNLoSA= X-Google-SMTP-Source: AMsMyM4npU2MOpd2zeNzjMAWTLeoQdIL9gUHv2jAMfiy57X6cKOCViJ5zcupuPaezw3cLxPxVUxpOQ== X-Received: by 2002:a17:902:d0d2:b0:178:1047:1cce with SMTP id n18-20020a170902d0d200b0017810471ccemr2376835pln.150.1663837409069; Thu, 22 Sep 2022 02:03:29 -0700 (PDT) X-PGP-Key: https://github.com/yuzibo/yuzibo.github.io/blob/master/_includes/subkey-signing-06-18-143E4BAF-pub.asc MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jitoif6uww7fpgk6" Content-Disposition: inline X-Debian-Message: from BTS X-Mailing-List: archive/latest/1735573 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 152 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Bastian Germann , debian-python@lists.debian.org X-Original-Date: Thu, 22 Sep 2022 17:03:24 +0800 X-Original-Message-ID: <20220922090324.ot6shgjve5p47gk2@debian> X-Original-References: <8735jf8a0w.fsf@angela.anarc.at> <8735jf8a0w.fsf@angela.anarc.at> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <5062951b-5c19-60a6-daa9-8acde45eaef6@debian.org> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <20220717152756.lyoqizifnfhykqrg@debian> <87illowqce.fsf@emma.anarc.at> <20220918031024.rehgofq4bc4k5hw4@debian> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <87mtau5c3e.fsf@curie.anarc.at> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <87mtau5c3e.fsf@curie.anarc.at> Xref: csiph.com linux.debian.bugs.dist:1118250 linux.debian.maint.python:14487 --jitoif6uww7fpgk6 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 20, 2022 at 10:56:05AM -0400, Antoine Beaupr=E9 wrote: >> https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1= 245009306 >> (To avoid bring noisy for upstream, i just recorded it in a issue) > >I don't think pull requests are noisy... you should probably just submit >this as a PR upstream. Ok, got it. Will do. Sometime I mentioned the patch in the issue, the maintainer of upstream will pick it into if he think that is valuable. > >[...] > >> nfoview: >> https://salsa.debian.org/python-team/packages/nfoview/-/blob/debian/mast= er/debian/launcher/nfoview >> >> The issue is that I installed git_multimail.py twice in fact it should >> be under /usr/lib/python3 only as jcfp said. So i remove it in /usr/bin >> by hand. >> >> Now I have removed the launcher for git-multimail and it should work:) > >Hm. This is weird. Why would you *not* want git-multimail under >/usr/bin? I understand the that git_multimail.py *module* should be in >/usr/lib/, but you should *also* have a launcher in /usr/bin/ > >I think, therefore, this is incorrect: > >+override_dh_python3: >+ dh_python3 >+ rm -f debian/git-multimail/usr/bin/git_multimail.py >+ > >First off, don't use `-f` there: we *do* want to fail if the file >doesn't exist, so that we can remove the override. > yeah, right. >Second, this looks wrong: `git-multimail` (the launcher) should be the >thing that's installed under /usr/bin, not `git_multimail.py` (the >module). If the module ends up in /usr/bin, then it's probably a bug >upstream that should be filed. > >Could you clarify what happens with the package right now? The issue is that, it really seems like a bug here. First, I install git-multimail manual: ``` sudo python setup.py install # log is below =2E.. creating /usr/local/lib/python3.10/dist-packages/git_multimail-1.5.0-py3.10= =2Eegg Extracting git_multimail-1.5.0-py3.10.egg to /usr/local/lib/python3.10/dist= -packages Adding git-multimail 1.5.0 to easy-install.pth file Installing git_multimail.py script to /usr/local/bin =2E.. vimer@dev:~/build/rfs/git-multimail$ which git_multimail.py /usr/local/bin/git_multimail.py ``` It looks like you said. The git_multimail.py is placed in /usr/local/bin/git_multimail.py (if from debian package, it will be placed into /usr/bin/) The content of git-multimail.deb is: ``` This package provides the Python 3 modules and the git-multimail script. drwxr-xr-x root/root 0 2022-09-14 09:11 ./ drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/ drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/bin/ -rwxr-xr-x root/root 161143 2022-09-14 09:11 ./usr/bin/git_multimail.py drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/lib/ drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/lib/python3/ drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/lib/python3/dist-pack= ages/ drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/lib/python3/dist-pack= ages/git_multimail-1.6.0.egg-info/ -rw-r--r-- root/root 35851 2022-09-14 09:11 ./usr/lib/python3/dist-pack= ages/git_multimail-1.6.0.egg-info/PKG-INFO -rw-r--r-- root/root 1 2022-09-14 09:11 ./usr/lib/python3/dist-pack= ages/git_multimail-1.6.0.egg-info/dependency_links.txt -rw-r--r-- root/root 14 2022-09-14 09:11 ./usr/lib/python3/dist-pack= ages/git_multimail-1.6.0.egg-info/top_level.txt -rw-r--r-- root/root 161147 2022-07-21 07:30 ./usr/lib/python3/dist-pack= ages/git_multimail.py drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/share/ drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/share/doc/ drwxr-xr-x root/root 0 2022-09-14 09:11 ./usr/share/doc/git-multima= il/ -rw-r--r-- root/root 11317 2022-07-21 07:30 ./usr/share/doc/git-multima= il/README.rst.gz -rw-r--r-- root/root 210 2022-09-14 09:11 ./usr/share/doc/git-multima= il/changelog.Debian.gz -rw-r--r-- root/root 1755 2022-09-14 09:11 ./usr/share/doc/git-multima= il/copyright ``` I think the people found the issue also: https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1252= 529169 Certainly, lintian will give a kindly warning: W: git-multimail: script-with-language-extension [usr/bin/git_multimail.py] If I understand correctly, this is a bug as you said. The workround is still to use launcher file in d/ as in previous commit? Many thanks for your time to help me review it again :) --=20 Regards, -- Bo YU --jitoif6uww7fpgk6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEIcmhjYVTlmab0tjp+RVP3hQ+S68FAmMsJNgACgkQ+RVP3hQ+ S6+xNQ//fdhInRBpf4qSZReylSCte4OajjjkbYQ6AD6awB9F5batf1kEAHYW0nFQ FF8T0l52Kb103ZEnyF2T49D1xYxcibVI8JUc1jQI/slNxFfHWLUuMbCJo6ah7n8N xQKXNtavjn9ZjIKxTfXV8KsELCyG+csdrTu9ZA9GP5S80ipQSl+wk/UeK3wYkem8 uhlzuMDout6aw0OR6itMSfpD+1tEQNuidZaWwzkMEoEJAhU2uBFEpfkaxoZ2woPg dXQSDqh5zM8nur0Z/r7g/J+ksi/qF1Ezd9kkj1TckK6at+exdamMeI+ruz0qowzC 6N/m9oK++gEBo3qEAgH8C7se7TxTHB/P2HpweTAjxWUW0bQ495N5PC4dnKUX5P+Y m2Ob6fOP15anPg16zYgxjd0MoSxoR+w3ydrLYwvVHe0PORNBYXYqD6dQq4QxG61d 43EU4r18Rn0alWWcgolfu6i3b/FmJF2rvwVah9Vrav/sVXzJAVmyvCeLN5SeYsFN SQEud3ttc+DdU/4Y+e/jnid0tlFXfLGCoKMudFWN1njL3aNFxh8oaAtErraYsByW sFhcLJrBPT6imMzt29lHjdeh5NBh3Bhq5OcRd4GPYNmJwQGMDFRKZknftY+P3kqf KgoQpXFhK+4GtWsF+WSrkSLvSLxMN5//jCla5/yZStpjBe3J5VU= =mfCF -----END PGP SIGNATURE----- --jitoif6uww7fpgk6--