Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Antoine =?UTF-8?Q?Beaupr=C3=A9?= Newsgroups: linux.debian.bugs.dist,linux.debian.maint.python Subject: Bug#1007025: git-multimail 1.6.0 package review Date: Thu, 15 Sep 2022 18:40:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Thu Sep 15 16:36:11 2022 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -4.01 Reply-To: Antoine =?UTF-8?Q?Beaupr=C3=A9?= , 1007025@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: wnpp@debian.org, vimer X-Debian-Pr-Message: followup 1007025 X-Debian-Pr-Package: wnpp Organization: Debian MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Debian-Message: from BTS X-Mailing-List: archive/latest/1734395 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 69 Sender: robomod@news.nic.it X-Original-Cc: 1007025@bugs.debian.org, Bastian Germann , debian-python@lists.debian.org X-Original-Date: Thu, 15 Sep 2022 17:32:33 +0100 X-Original-Message-ID: <87illowqce.fsf@emma.anarc.at> X-Original-References: <20220317143411.rgiimub4gns3jyct@debian> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <878rt78k24.fsf@angela.anarc.at> <8735jf8a0w.fsf@angela.anarc.at> <8735jf8a0w.fsf@angela.anarc.at> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <5062951b-5c19-60a6-daa9-8acde45eaef6@debian.org> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <20220717152756.lyoqizifnfhykqrg@debian> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <20220717152756.lyoqizifnfhykqrg@debian> Xref: csiph.com linux.debian.bugs.dist:1117349 linux.debian.maint.python:14463 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi! I've done a quick review of the 1.6.0 package on salsa as of commit d5bd184a1cf73b752f80dea46d8080493a5e663b. It looks like there's some leftover stuff in debian/copyright, i would remove this: modified debian/copyright @@ -2,8 +2,6 @@ Format: https://www.debian.org/doc/packaging-manuals/copyri= ght-format/1.0/ Upstream-Name: git-multimail Upstream-Contact: Matthieu Moy Source: https://github.com/git-multimail/git-multimail =2D# =2D# Please double check copyright with the licensecheck(1) command. =20 Files: * Copyright: 2014-2022, Matthieu Moy Also, I didn't quite follow the work on the test cases, but why did you replace pep8 by pycodestyle in the patch in debian/patches? The patch itself doesn't actually explain the *why* (it explains the "what" but we typically want more than this...) It seems like you have README.rst both in debian/rules and debian/docs. Either one of those should be sufficient, and you should remove the other. Same with the launcher in python3-git-multimail.install vs debian/rules. I'm also surprised we need that launcher at all. Normally, the `setup.py` wrapper has a scripts=3D stanza which should install the upstream one, why do we do it differently? I would also name the binary package `git-multimail` instead of `python3-git-multimail`, since we don't really care that much that the thing is written in python, since it's not a library. I think that's what I have for now. I haven't double-checked the upstream branch to see if it matches the upstream repo I have here, but that would be my next step before uploading... just a formality to make sure everything matches up. Thanks for working on this package! =2D-=20 The greatest crimes in the world are not committed by people breaking the rules but by people following the rules. It's people who follow orders that drop bombs and massacre villages. - Banksy --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEexZCBNCWcjsBljWrPqHd3bJh2XsFAmMjU6EACgkQPqHd3bJh 2XsjAgf/cn+DULTaxJIc9fC3QWlG+I22QSp0BGX8BhreMmoXDTzGl2+pBdexpteH kJJrBoRqNiduBIEBSCiv3Au1tHvuoCE4oJctxm3+N/3lCDS5xKVuxb0w7WM/pIMN r3OGJ27wetoGpEt6PpT9HcfRAYwHpAl6vf2wxcpzXXM17DZ1GHBWUlBizqB0zlkq k6a6yiWR44nwSd1QE2SMS63hxOxzoq3TixnC7Ibz4njRZV8ezW1OMxXUaIzCKgSI QKC0h5wnem0YYv4cCxkVgM5VPEUnvXSHopsLsuiiqdRi9y+ni+/6Hyc0/8vWUAqA RfdGlnEm5t4SH4lAmfNen3b5uZEf8A== =mc4S -----END PGP SIGNATURE----- --=-=-=--