Path: csiph.com!1.us.feeder.erje.net!3.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Antoine =?UTF-8?Q?Beaupr=C3=A9?= Newsgroups: linux.debian.bugs.dist,linux.debian.maint.python Subject: Bug#1007025: git-multimail 1.6.0 package review Date: Thu, 15 Sep 2022 18:50:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Thu Sep 15 16:42:12 2022 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -4.01 Reply-To: Antoine =?UTF-8?Q?Beaupr=C3=A9?= , 1007025@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: wnpp@debian.org, vimer X-Debian-Pr-Message: followup 1007025 X-Debian-Pr-Package: wnpp Organization: Debian MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Debian-Message: from BTS X-Mailing-List: archive/latest/1734396 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 36 Sender: robomod@news.nic.it X-Original-Cc: 1007025@bugs.debian.org, Bastian Germann , debian-python@lists.debian.org X-Original-Date: Thu, 15 Sep 2022 17:38:35 +0100 X-Original-Message-ID: <87fsgswq2c.fsf@emma.anarc.at> X-Original-References: <20220317143411.rgiimub4gns3jyct@debian> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <878rt78k24.fsf@angela.anarc.at> <8735jf8a0w.fsf@angela.anarc.at> <8735jf8a0w.fsf@angela.anarc.at> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <5062951b-5c19-60a6-daa9-8acde45eaef6@debian.org> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <20220717152756.lyoqizifnfhykqrg@debian> <87illowqce.fsf@emma.anarc.at> <164694434412.23888.15342309351823597252.reportbug@angela.anarc.at> <87illowqce.fsf@emma.anarc.at> Xref: csiph.com linux.debian.bugs.dist:1117350 linux.debian.maint.python:14464 On 2022-09-15 17:32:33, Antoine Beaupr=C3=A9 wrote: > Hi! > > I've done a quick review of the 1.6.0 package on salsa as of commit > d5bd184a1cf73b752f80dea46d8080493a5e663b. [...] > Also, I didn't quite follow the work on the test cases, but why did you > replace pep8 by pycodestyle in the patch in debian/patches? The patch > itself doesn't actually explain the *why* (it explains the "what" but we > typically want more than this...) I have just found you have reported this upstream in: https://github.com/git-multimail/git-multimail/issues/221 ... which is great! Could you also open a PR against the repository and link that in the patch? You might want to review the patch tagging guidelines as well, as this is the kind of things it answers: https://dep-team.pages.debian.net/deps/dep3/ Finally, one fundamental issue with this package is that, as you correctly identified, it's unmaintained upstream. If we do ship it in Debian, maybe we'd want to keep it out of stable until that is settled? a. --=20 I've got to design so you can put it together out of garbage cans. In part because that's what I started from, but mostly because I don=E2=80=99t trust the industrial structure=E2=80=94they might decide to suppress us weirdos and try to deny us the parts we need. - Lee Felsenstein