Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: =?utf-8?Q?Antoine_Beaupr=C3=A9?= Newsgroups: linux.debian.maint.python Subject: Re: a review of your bumblebee-status package Date: Tue, 07 Jun 2022 17:00:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Jun 7 14:51:25 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-108.001 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.801, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -3.5 Organization: Debian MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailing-List: archive/latest/19981 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/87v8tcy1b7.fsf@curie.anarc.at Approved: robomod@news.nic.it Lines: 37 Sender: robomod@news.nic.it X-Original-Cc: Ben Westover , debian-python@lists.debian.org X-Original-Date: Tue, 07 Jun 2022 10:51:08 -0400 X-Original-Message-ID: <87v8tcy1b7.fsf@curie.anarc.at> X-Original-References: <87sfohoni3.fsf@curie.anarc.at> <0f84e96b-c0eb-2d0e-fc7e-a8b272549aea@gmail.com> <87fskhb44h.fsf@angela.anarc.at> <367c1fcc-e57e-bde4-61eb-787042586a60@gmail.com> <87pmjkzitm.fsf@curie.anarc.at> Xref: csiph.com linux.debian.maint.python:14154 On 2022-06-07 15:44:28, Julian Gilbey wrote: > On Tue, Jun 07, 2022 at 09:47:33AM -0400, Antoine Beaupr=C3=A9 wrote: >> On 2022-06-07 07:11:15, Julian Gilbey wrote: >> > [...] >> > As far as I understand, versioneer (or the _version.py generated by >> > it) uses a whole bunch of heuristics to determine the version number >> > of the package, for example by looking at git tags and so on. Several >> > times, I have found that _version.py in the PyPI release of a package >> > is a very small file (just a few lines long) stating the version >> > number of the package, while the _version.py in GitHub is huge and >> > doesn't work on a standalone packaged version. If I recall correctly, >> > In more than one package I (co-)maintain, I've gone for the PyPI >> > version of this file. >>=20 >> Uh! So you just keep the file around altogether? That seems like a break >> of policy... > > Maybe I wasn't clear: we pack the GitHub as the .orig.tar.gz and then > apply a patch (in debian/patches) to replace _version.py with the > version found in the PyPI package. (There are often good reasons to > prefer the GitHub version over the PyPI version.) I just looked > through my local packages and the only examples I could find were the > now-removed python-language-server and python-jsonrpc-server. > > I'm not sure how this would break policy. It seems to me that generated files shouldn't be shipped as part of the source we distributed to users. Those files should be (re)generated at build time. a. --=20 Be who you are and say what you feel Because those who mind don't matter And those who matter don't mind. - Dr. Seuss