Path: csiph.com!1.us.feeder.erje.net!3.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Julian Gilbey Newsgroups: linux.debian.maint.python Subject: Re: a review of your bumblebee-status package Date: Tue, 07 Jun 2022 16:50:01 +0200 Message-ID: References: X-Original-To: Antoine =?iso-8859-1?Q?Beaupr=E9?= X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Jun 7 14:44:44 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.19 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -4.6 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailing-List: archive/latest/19980 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/Yp9kTN3n7P3sCqRA@d-and-j.net Approved: robomod@news.nic.it Lines: 28 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Ben Westover , debian-python@lists.debian.org X-Original-Date: Tue, 7 Jun 2022 15:44:28 +0100 X-Original-Message-ID: X-Original-References: <87sfohoni3.fsf@curie.anarc.at> <0f84e96b-c0eb-2d0e-fc7e-a8b272549aea@gmail.com> <87fskhb44h.fsf@angela.anarc.at> <367c1fcc-e57e-bde4-61eb-787042586a60@gmail.com> <87pmjkzitm.fsf@curie.anarc.at> Xref: csiph.com linux.debian.maint.python:14152 On Tue, Jun 07, 2022 at 09:47:33AM -0400, Antoine Beaupré wrote: > On 2022-06-07 07:11:15, Julian Gilbey wrote: > > [...] > > As far as I understand, versioneer (or the _version.py generated by > > it) uses a whole bunch of heuristics to determine the version number > > of the package, for example by looking at git tags and so on. Several > > times, I have found that _version.py in the PyPI release of a package > > is a very small file (just a few lines long) stating the version > > number of the package, while the _version.py in GitHub is huge and > > doesn't work on a standalone packaged version. If I recall correctly, > > In more than one package I (co-)maintain, I've gone for the PyPI > > version of this file. > > Uh! So you just keep the file around altogether? That seems like a break > of policy... Maybe I wasn't clear: we pack the GitHub as the .orig.tar.gz and then apply a patch (in debian/patches) to replace _version.py with the version found in the PyPI package. (There are often good reasons to prefer the GitHub version over the PyPI version.) I just looked through my local packages and the only examples I could find were the now-removed python-language-server and python-jsonrpc-server. I'm not sure how this would break policy. Best wishes, Julian