Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: =?utf-8?Q?Antoine_Beaupr=C3=A9?= Newsgroups: linux.debian.maint.python Subject: Re: a review of your bumblebee-status package Date: Tue, 07 Jun 2022 16:00:01 +0200 Message-ID: References: X-Original-To: Ben Westover X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Jun 7 13:51:17 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-108.001 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.801, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -3.5 Organization: Debian MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailing-List: archive/latest/19978 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/87leu8zinw.fsf@curie.anarc.at Approved: robomod@news.nic.it Lines: 26 Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Tue, 07 Jun 2022 09:50:59 -0400 X-Original-Message-ID: <87leu8zinw.fsf@curie.anarc.at> X-Original-References: <87sfohoni3.fsf@curie.anarc.at> <601d870d-2ea0-ab42-33ac-42bcecc14fb2@gmail.com> Xref: csiph.com linux.debian.maint.python:14150 On 2022-06-06 23:42:19, Ben Westover wrote: > Here's another note: > > On 6/6/22 10:49 AM, Antoine Beaupr=C3=A9 wrote: >> * i'm really not sure I like that C binary to fetch the keyboard >> layout... surely there must be a more pythonic way of doing this? i >> guess there's another layout-xkb module that does the right thing, >> but it seems odd to have both there..=20 > > This is apparently an issue that upstream already knows about > (https://github.com/tobi-wan-kenobi/bumblebee-status/issues/790) > but hasn't done anything about for a year. > The fact that there shouldn't be a C binary here at all has just now > been reported by me: > https://github.com/tobi-wan-kenobi/bumblebee-status/issues/883 That's good. I wonder if we could just not do this ourselves and patch that thing out. Then we could submit that upstream as a fix for the above... But that's not a blocker. I think as long as you fix the Architecture fields, this should just work. (And it seems like you did, on salsa.) --=20 Tout ce qui n=E2=80=99est pas donn=C3=A9 est perdu. - Proverbe indien