Path: csiph.com!1.us.feeder.erje.net!3.us.feeder.erje.net!2.eu.feeder.erje.net!feeder.erje.net!news.uzoreto.com!aioe.org!bofh.it!news.nic.it!robomod From: =?utf-8?Q?Antoine_Beaupr=C3=A9?= Newsgroups: linux.debian.maint.python Subject: Re: a review of your bumblebee-status package Date: Tue, 07 Jun 2022 15:50:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Jun 7 13:47:49 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-108.021 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.801, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -3.5 Organization: Debian MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailing-List: archive/latest/19977 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/87pmjkzitm.fsf@curie.anarc.at Approved: robomod@news.nic.it Lines: 36 Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Tue, 07 Jun 2022 09:47:33 -0400 X-Original-Message-ID: <87pmjkzitm.fsf@curie.anarc.at> X-Original-References: <87sfohoni3.fsf@curie.anarc.at> <0f84e96b-c0eb-2d0e-fc7e-a8b272549aea@gmail.com> <87fskhb44h.fsf@angela.anarc.at> <367c1fcc-e57e-bde4-61eb-787042586a60@gmail.com> Xref: csiph.com linux.debian.maint.python:14148 On 2022-06-07 07:11:15, Julian Gilbey wrote: > Hi Ben, > > On Mon, Jun 06, 2022 at 10:42:53PM -0400, Ben Westover wrote: >> > > _version.py is not a copy of versioneer, it's *generated* by version= eer. >> > > However, there is versioneer.py in the root directory, which is. I'll >> > > exclude that from the source and repack. >> >=20 >> > hmm... how about that generated file though? shouldn't it be ... well, >> > generated at build time instead? :) >>=20 >> As far as I understand it, this file is used by the author of the progra= m, >> not end users. I don't understand it well, though, because I haven't put >> much time into researching what versioneer even does. >> If my hunch is correct, I may be able to just remove the file from the >> source altogether, but I haven't tried that yet. > > As far as I understand, versioneer (or the _version.py generated by > it) uses a whole bunch of heuristics to determine the version number > of the package, for example by looking at git tags and so on. Several > times, I have found that _version.py in the PyPI release of a package > is a very small file (just a few lines long) stating the version > number of the package, while the _version.py in GitHub is huge and > doesn't work on a standalone packaged version. If I recall correctly, > In more than one package I (co-)maintain, I've gone for the PyPI > version of this file. Uh! So you just keep the file around altogether? That seems like a break of policy... --=20 On reconnait la grandeur et la valeur d'une nation =C3=A0 la fa=C3=A7on dont celle-ci traite ses animaux. - Mahatma Gandhi