Path: csiph.com!1.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!weretis.net!feeder8.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Colin Watson Newsgroups: linux.debian.maint.python Subject: Re: Help needed with src:pkg click when building against Python 3.10 Date: Wed, 01 Jun 2022 17:10:01 +0200 Message-ID: References: X-Original-To: Mike Gabriel X-Mailbox-Line: From debian-python-request@lists.debian.org Wed Jun 1 15:09:54 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-107.921 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.801, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FOURLA=0.1, LDO_WHITELIST=-5, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailing-List: archive/latest/19950 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/YpeBHca5V4QWG44X@riva.ucam.org Approved: robomod@news.nic.it Lines: 17 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: doko@debian.org, marius@ubports.com, debian-python@lists.debian.org X-Original-Date: Wed, 1 Jun 2022 16:09:17 +0100 X-Original-Message-ID: X-Original-References: <20220529065221.Horde.tiXDSFCxCC9eVTD_t3A3xsq@mail.das-netzwerkteam.de> <20220601142930.Horde.FWLCbLDzdwbqU9v-yOs4j0D@mail.das-netzwerkteam.de> Xref: csiph.com linux.debian.maint.python:14122 On Wed, Jun 01, 2022 at 02:29:30PM +0000, Mike Gabriel wrote: > On So 29 Mai 2022 08:52:21 CEST, Mike Gabriel wrote: > > We see various test failures recently when running unit tests of click > > against Python 3.10. It seems that something regarding file descriptor > > inheritance in subprocess calls has changed between Python 3.9 and > > Python 3.10 which I fail to pinpoint exactly. > > The issue has been resolved by Marius: > https://gitlab.com/ubports/core/click/-/merge_requests/7 > > (silly version comparison flaw...). Ah yes, fair enough. This is a very complicated way to write `sys.version_info >= (3, 2)` though! -- Colin Watson (he/him) [cjwatson@debian.org]