Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Scott Kitterman Newsgroups: linux.debian.maint.python Subject: Re: pybuild-autopkgtest (was: Notes from the DC22 Python Team BoF) Date: Tue, 26 Jul 2022 17:50:01 +0200 Message-ID: References: X-Original-To: debian-python@lists.debian.org X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Jul 26 15:44:22 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.19 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 X-Greylist: delayed 349 seconds by postgrey-1.36 at bendel; Tue, 26 Jul 2022 15:44:11 UTC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailing-List: archive/latest/20119 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/0239A172-64F5-4B2A-A903-F50760F50D3B@kitterman.com Approved: robomod@news.nic.it Lines: 66 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Tue, 26 Jul 2022 15:37:50 +0000 X-Original-Message-ID: <0239A172-64F5-4B2A-A903-F50760F50D3B@kitterman.com> X-Original-References: Xref: csiph.com linux.debian.maint.python:14285 On July 26, 2022 2:50:19 PM UTC, Antonio Terceiro = wrote: >On Mon, Jul 25, 2022 at 09:04:27AM +0100, Julian Gilbey wrote: >> On Sat, Jul 23, 2022 at 07:52:19PM +0200, Louis-Philippe V=C3=A9ronneau= wrote: >> > =3D=3D pybuild improvements =3D=3D >> >=20 >> > getting the autopkgtest MR in would be great >> >=20 >> > https://salsa=2Edebian=2Eorg/python-team/tools/dh-python/-/merge_requ= ests/27 >> >=20 >> > We need people to test this MR some more, although it seems fairly ma= ture=2E >> >=20 >> > It might be a good idea to have a line in d/control to let us migrate= from >> > the existing autopkgtests running unit tests to the new automated MR= =2E >>=20 >> I've been looking at this a bit more=2E I'm not sure what this last >> paragraph means: the new "automated" autopkgtest will only be run if >> the maintainer explicitly adds: >>=20 >> Testsuite: autopkgtest-pkg-pybuild >>=20 >> to debian/control (see the autodep8 MR at >> https://salsa=2Edebian=2Eorg/ci-team/autodep8/-/merge_requests/27/diffs= - >> it will never automatically detect a pybuild package)=2E >> And a maintainer would presumably only add that if they are also >> removing their existing debian/tests/control (or want to run the >> pybuild tests in addition)=2E >>=20 >> An alternative would be for the autodep8 patch to try to determine >> whether to run pybuild-autopkgtest=2E One approach could be: >>=20 >> if the package would run autopkgtest-pkg-python: >> if debian/control does not contain an override_dh_auto_test stanza: >> run pybuild-autopkgtest >>=20 >> Note, though, that if autodep8 is called, it will run all of the >> detected tests=2E (At least that is what I believe happens from readin= g >> /usr/bin/autodep8; I haven't double-checked this=2E) So, for example, >> if a package specifies >>=20 >> Testsuite: autopkgtest-pkg-python >>=20 >> it will also run the autopkgtest-pkg-pybuild suite as it will be >> detected as being a Python package, and vice versa=2E That is a >> possible reason *not* to use the above suggestion, as it would >> potentially run pybuild-autopkgtest even if not desired=2E > >I think the notes did not capture the consensus correctly=2E The point wa= s >that it should be possible to automate updating the `Testsuite:` field >to run tests with pybuild-autopkgtest, and that we should probably do >that across team packages with the help of some scripting=2E I suppose this is fine as long as whoever does it fixes all the resulting = RC bugs=2E Scott K