Path: csiph.com!newsfeed.xs4all.nl!newsfeed7.news.xs4all.nl!bofh.it!news.nic.it!robomod From: =?UTF-8?Q?Louis-Philippe_V=c3=a9ronneau?= Newsgroups: linux.debian.maint.python Subject: Review of python-bonsai Date: Mon, 13 Dec 2021 23:10:01 +0100 Message-ID: X-Original-To: debian-python@lists.debian.org X-Mailbox-Line: From debian-python-request@lists.debian.org Mon Dec 13 22:07:25 2021 Old-Return-Path: X-Amavis-Spam-Status: No, score=-6.198 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, LDO_WHITELIST=-5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -4.6 X-Riseup-User-ID: 33641655E6053248CA5A0154845BF4AD19F3DDD2A3003BD866081A40DDD2C799 MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailing-List: archive/latest/19588 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/a6df8514-eb6c-708b-c527-59c3aaf5b53f@debian.org Approved: robomod@news.nic.it Lines: 78 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Robin Jarry X-Original-Date: Mon, 13 Dec 2021 17:07:06 -0500 X-Original-Message-ID: Xref: csiph.com linux.debian.maint.python:13778 Hi! Here's my review of python-bonsai: 1. d/control: * You don't need the "(>= 3.6)" restriction for python3-all-dev, as that version isn't even in oldstable. * sphinx-common isn't needed for the source package, as python3-sphinx depends on it * "python3 (>= 3.6)" is not required for python3-bonsai, ${python3:Depends} should take care of that for you. * IMO, python3-bonsai should recommend or suggest python3-bonsai-doc, but that's up to you. --------- 2. d/copyright: * you forgot to add a debian/* section. AFAIU, noirello isn't the one who wrote d/rules :) * .appveyor/run_with_env.cmd is licensed CC0. You probably don't need those files, so you can exclude them from the source package using Files-Excluded in d/copyright * the MIT license in Debian is named "Expat", for historical reasons. --------- 4. d/rules: * You left "export DH_VERBOSE = 1" uncommented. * I'm curious to why you need to set "export LC_ALL = C.UTF-8". --------- 5. d/tests: I don't have an autopkgtests setup that has machine-level isolation. You ran that code and it works? --------- 6. d/watch: You left "" in there instead of replacing it by the actual project's name (have a look at Lintian) :) Note you can use the "git tag" mode to simplify this file (not that it's required, your file works as-is): [1] --------- 7. Upstream code Have you read the upstream code? It's something you should do (and you should read all the changes for each new update). Not that you have to do a proper security audit, but you should go through the code to be sure there's no obvious or dangerous things in there. Otherwise, good job! Fix those, ping me and if it's OK, I'll read the upstream code myself and sponsor it. Cheers, [1]: https://salsa.debian.org/python-team/packages/python-mediafile/-/blob/debian/master/debian/watch -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau ⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org ⠈⠳⣄