Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Chiara Marmo Newsgroups: linux.debian.maint.python Subject: Re: sphinxext-opengraph new upstream version and tests Date: Sat, 01 Jan 2022 04:30:01 +0100 Message-ID: References:

X-Mailbox-Line: From debian-python-request@lists.debian.org Sat Jan 1 03:26:00 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-5.199 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=no autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 X-Gm-Message-State: AOAM5307SynOMBgMVsDxalQRP8StUCcJm7ilkzBMA2CGke7BGazsLDtZ mV0c8Vsjz2/G6QenYQIZb5v+mGxJFf45Gm95nJxuBarfJ/s= X-Google-SMTP-Source: ABdhPJw7Svid8EsztXzElDTFU8vXBRNnvqi6RBLnjS0uIWPMbvKuBAhi32dktPGiKyx7RoKkWyVF+U1eVPAmsVlBXGY= X-Received: by 2002:a05:6512:ac9:: with SMTP id n9mr31336205lfu.114.1641007545262; Fri, 31 Dec 2021 19:25:45 -0800 (PST) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cf252a05d47cd707" X-Mailing-List: archive/latest/19650 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAGfF14-ALB_63yCXL+zbBZE8_JazKreUps7oQPWBbO_knzCqLA@mail.gmail.com Approved: robomod@news.nic.it Lines: 65 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Fri, 31 Dec 2021 17:25:34 -1000 X-Original-Message-ID: X-Original-References: <20211231125124.13e4f73d@vip.jcf.pm> Xref: csiph.com linux.debian.maint.python:13837 --000000000000cf252a05d47cd707 Content-Type: text/plain; charset="UTF-8" Thanks Jeroen for your time and your review Enabling the CI on salsa for your package can be really helpful to > verify things work as expected. As an added benefit, it also lowers > the time and effort needed to review a package. > Indeed, I have enabled it. > Anyway, the current autopkgtest has a number of obvious flaws: > * the binary package it's trying to test isn't actually installed at > all because it's not listed as a test dependency; > * the same goes for the supported python versions the test loops over > (i.e. the necessary dependency on python3-all is missing). > * on the other hand, dependencies of the package being tested (such > as python3-sphinx) should not be duplicated as a test dependency; > * within the control file, the field identifying tests in a separate > file is called 'Tests', not 'Test-Command'. > I think the configuration is better now, as the CI passed too. Please let me know if the package is ready for the upload. Also, happy new year 2022 to all the people on the list! Best, Chiara --000000000000cf252a05d47cd707 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Thanks Jeroen for your time and your review

=

Enabling the CI on salsa for your package can be really helpful to
verify things work as expected. As an added benefit, it also lowers
the time and effort needed to review a package.

Indeed, I have enabled it.

=C2=A0

Anyway, the current autopkgtest has a number of obvious flaws:
* the binary package it's trying to test isn't actually installed a= t
=C2=A0 all because it's not listed as a test dependency;
* the same goes for the supported python versions the test loops over
=C2=A0 (i.e. the necessary dependency on python3-all is missing).
* on the other hand, dependencies of the package being tested (such
=C2=A0 as python3-sphinx) should not be duplicated as a test dependency; * within the control file, the field identifying tests in a separate
=C2=A0 file is called 'Tests', not 'Test-Command'.

I think the configuration is better now, as the= CI passed too.
Please let me know if the package is ready for th= e upload.

Also, happy new year 2022 to all the peo= ple on the list!

Best,

Ch= iara
=C2=A0

--000000000000cf252a05d47cd707--