Path: csiph.com!weretis.net!feeder6.news.weretis.net!4.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!newsfeed.xs4all.nl!newsfeed7.news.xs4all.nl!bofh.it!news.nic.it!robomod From: Dave Jones Newsgroups: linux.debian.bugs.dist,linux.debian.maint.python Subject: Bug#924643: RFS: colorzero/2.0-1 [ITP] -- Construct, convert, and manipulate colors in a Pythonic manner. Date: Mon, 21 Jun 2021 13:50:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Mon Jun 21 11:45:09 2021 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -3.751 Reply-To: Dave Jones , 924643@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: wnpp@debian.org X-Debian-Pr-Message: followup 924643 X-Debian-Pr-Package: wnpp X-Gm-Message-State: AOAM533gWpgODVvN84YMLyqJSOrgg4LdTKsonft/FB0T8IP0B67CF8y3 XRypdGPK8aeegH70J5wTV2vetQ== X-Google-SMTP-Source: ABdhPJwpRsYVOrcgafG57I3aPdBAyXOMAYB2zKURS/0/MqJ4N8wjUr3gzk4W4FvXFVMevcU7xYKT8w== X-Received: by 2002:a5d:65cf:: with SMTP id e15mr28637584wrw.310.1624275657705; Mon, 21 Jun 2021 04:40:57 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline User-Agent: NeoMutt/20191207 X-Debian-Message: from BTS X-Mailing-List: archive/latest/1668408 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 42 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: 924643@bugs.debian.org, Debian Python X-Original-Date: Mon, 21 Jun 2021 12:40:56 +0100 X-Original-Message-ID: <20210621114056.5gi3sveicj2irmmf@amaterasu> X-Original-References: <155264876356.22584.10802410818036635153.reportbug@spider> Xref: csiph.com linux.debian.bugs.dist:1062619 linux.debian.maint.python:13429 Hi Peter, On Sat, Jun 19, 2021 at 01:03:31PM +0100, Peter Green wrote: >Just done some reviewing/tweaking. I've pushed the following changes to >the git repo, please tell me if you have any objections. > >I added a gpb.conf to make git-buildpackage actually use pristine tar >and hence result in an orig tarball that was consistent with what is >already in Ubuntu. > >I found the clean target was not cleaning up the "egg-info" so I added >a command to do that. > >I added a closes: entry for the ITP bug. No objections at all -- all looks good to me! Still getting used to gbp (I was testing the builds with sbuild prior to uploading to Salsa, hence why I missed the not-cleaning-up-egg-info). >That leaves one issue that I think still needs to be sorted before I >sponsor the package. > >The file "copyrights" has no license header and the git history says it >was copied but not where from. Poking around I discovered a script of >the same name in gpiozero, containing what appears to be the same code >and committed by you with a commit message of "create copyright >header", so I presume this script is entirely your work, assuming it is >I would suggest adding a copyright header upstream and then picking the >commit up as a Debian patch until there is another upstream release. You're absolutely correct I shamelessly copied my "copyrights" script from gpio-zero :). I'll add a copyright header on there in a mo and pick the commit as a patch. >Finally would you consider adding me as a co-maintainer. Certainly -- I'll add you to "Uploaders" as Emmanuel suggests later in the thread. Thanks! Dave.