Path: csiph.com!weretis.net!feeder6.news.weretis.net!4.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!news.mb-net.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod From: Stefano Rivera Newsgroups: linux.debian.maint.python Subject: Re: RFS: python-splinter 0.14.0 (new package) Date: Fri, 21 May 2021 16:10:01 +0200 Message-ID: References: X-Original-To: debian-python@lists.debian.org X-Mailbox-Line: From debian-python-request@lists.debian.org Fri May 21 14:08:05 2021 Old-Return-Path: X-Amavis-Spam-Status: No, score=-6.851 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, LDO_WHITELIST=-5] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -4.6 Mail-Followup-To: debian-python@lists.debian.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Gpg-Public-Key: http://www.rivera.za.net/stefano.gpg User-Agent: NeoMutt/20180716 X-Mailing-List: archive/latest/19187 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20210521140752.gl6u2kurt67rxqha@satie.tumbleweed.org.za Approved: robomod@news.nic.it Lines: 29 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Fri, 21 May 2021 14:07:52 +0000 X-Original-Message-ID: <20210521140752.gl6u2kurt67rxqha@satie.tumbleweed.org.za> X-Original-References: Xref: csiph.com linux.debian.maint.python:13399 Hi Joseph (2021.05.20_00:53:31_+0000) > I finished packaging splinter, a Python package for testing web applications > using web browser automation (splinter uses selenium). Had a quick look at it. Had to rename things in the pristine-tar branch, to get a source package to build. Did you consider getting source from GitHub instead of PyPI? That way you could get the upstream test suite, docs, and license text. It would be nice to run the upstream test suite (if possible) and have autopkgtests. Did you need to list python3-selenium & python3-six in Depends? I would have expected dh_python3 to pick them up and list them in ${python3:Depends}. upstream/metadata: I don't think of GitHub as being an Archive, as described by the upstream metadata spec. But I can see why you may disagree. You could list the PyPI Registry entry. SR -- Stefano Rivera http://tumbleweed.org.za/ +1 415 683 3272