Path: csiph.com!newsfeed.xs4all.nl!newsfeed8.news.xs4all.nl!bofh.it!news.nic.it!robomod From: Sandro Tosi Newsgroups: linux.debian.maint.python Subject: Re: python-django-js-asset_1.2.2-3_source.changes REJECTED Date: Wed, 22 Sep 2021 00:40:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Sep 21 22:38:20 2021 Old-Return-Path: X-Amavis-Spam-Status: No, score=-6.501 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001] autolearn=ham autolearn_force=no X-Policyd-Weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-qk1-f171.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5 X-Gm-Message-State: AOAM533jpPLcTX6S9KkrfUslfeH7HYqrR7cysO/9COeNhUn2EaUSBVlK IgNe5tHAH+L47eakUTgRKijtyprrNB6txHHCmHKa66GC X-Google-SMTP-Source: ABdhPJyQ6oPs0UOHWUrpHoXI72QSfYTEcqhQYf+eesYCqClrJvK5eg+Y76DN2FaR4gptPFYajP3A+yi4A25PnLd0QFg= X-Received: by 2002:a25:3486:: with SMTP id b128mr14470119yba.138.1632263885318; Tue, 21 Sep 2021 15:38:05 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Mailing-List: archive/latest/19361 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAB4XWXzLAa-GFRXifAz9SUgyh+2UNwPugU5iaOuAcCkmtUU5Sg@mail.gmail.com Approved: robomod@news.nic.it Lines: 45 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Tue, 21 Sep 2021 18:37:39 -0400 X-Original-Message-ID: X-Original-References: <1f944d96-c152-3a50-a20f-f0c5137493ce@t-online.de> <256be314-dabd-a2cc-1c9e-a2bfaad030a5@t-online.de> Xref: csiph.com linux.debian.maint.python:13565 On Tue, Sep 21, 2021 at 5:00 PM Antonio Terceiro wrote: > > On Mon, Sep 20, 2021 at 11:14:44AM -0400, Sandro Tosi wrote: > > > That's because gbp does not use pristine-tar by default, and > > > debian/gbp.conf was missing `pristine-tar=True`. Just pushed a commit to > > > fix that. > > > > I dont think this is the right approach: the default options to work > > on DPT packages should be in gbp default config file (or in another, > > global, config file), and not live in each and every package > > debian/gbp.conf file; it is already inconsistently maintained with > > several packages having uncommon settings that will take precedence > > over the default ones. > > I agree with you in theory; my global gbp.cons enables pristine-tar. > > However, having it duplicated in every package means we as a team work > consistently regardless of people's global configuration, not at all, right now we dont have a *consistent* debian/gbp.conf in each package, everyone writes their own and it's currently a mess. what when we decide to add a new option, or change the value of an existing one? DPT currently has ~2500 packages: how do you maintain consistency in all of them? > and that's one > less detail people need to get just right to be able to contribute > effectively. > > Also, one's global configuration might not apply to all the packages > they contribute to; it's easier for everyone if gbp just does the > right thing based on per-package configuration than expecting people to > remember to switch their defaults, or to pass options explicitly. please refer to https://lists.debian.org/debian-python/2021/09/msg00065.html for how i see this being implemented. -- Sandro "morph" Tosi My website: http://sandrotosi.me/ Me at Debian: http://wiki.debian.org/SandroTosi Twitter: https://twitter.com/sandrotosi