Path: csiph.com!weretis.net!feeder8.news.weretis.net!usenet.goja.nl.eu.org!aioe.org!bofh.it!news.nic.it!robomod From: Devops PK Carlisle LLC Newsgroups: linux.debian.maint.python Subject: Re: Looking for a Sponsor - Papereshaper Date: Thu, 31 Dec 2020 04:00:03 +0100 Message-ID: References: X-Original-To: Paul Wise X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Dec 31 02:55:33 2020 Old-Return-Path: X-Amavis-Spam-Status: No, score=-5.555 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, LDO_WHITELIST=-5, NICE_REPLY_A=-0.001, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001] autolearn=no autolearn_force=no X-Policyd-Weight: using cached result; rate: -3.5 X-Greylist: delayed 1499 seconds by postgrey-1.36 at bendel; Thu, 31 Dec 2020 02:55:19 UTC X-Authority-Reason: nr=8 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Antiabuse: This header was added to track abuse, please include it with any abuse report X-Antiabuse: Primary Hostname - gator4161.hostgator.com X-Antiabuse: Original Domain - lists.debian.org X-Antiabuse: Originator/Caller UID/GID - [47 12] / [47 12] X-Antiabuse: Sender Address Domain - pkcarlisle.com X-Bwhitelist: no X-Source-IP: 75.117.203.187 X-Source-L: No X-Exim-ID: 1kunMx-001Q0f-RX X-Source-Sender: h187.203.117.75.dynamic.ip.windstream.net ([192.168.254.68]) [75.117.203.187]:35194 X-Source-Auth: devops+pkcarlisle.com X-Email-Count: 2 X-Source-Cap: cGtjbGxjO3BrY2xsYztnYXRvcjQxNjEuaG9zdGdhdG9yLmNvbQ== X-Local-Domain: yes X-Mailing-List: archive/latest/18867 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/5f0dcd25-4891-cce7-eb22-65c8556ef2b6@pkcarlisle.com Approved: robomod@news.nic.it Lines: 70 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Wed, 30 Dec 2020 21:07:15 -0500 X-Original-Message-ID: <5f0dcd25-4891-cce7-eb22-65c8556ef2b6@pkcarlisle.com> X-Original-References: <1262d7a2-5a19-dca7-8842-8276de343b47@pkcarlisle.com> Xref: csiph.com linux.debian.maint.python:13093 Excellent. Thank you for reviewing. Looks like I have a list of adjustments to make. On 12/30/20 8:02 PM, Paul Wise wrote: > On Wed, Dec 30, 2020 at 4:50 PM Devops PK Carlisle LLC wrote: > >> The git is here: https://github.com/pkcarlislellc/git-papershaper > > I don't intend to package nor sponsor this, but here is a review: > > Drop git- from the name of the GitHub repository. > > Add a git repository to the SourceForge project also and push to both repos. > > Remove the possibly non-free and or non-redistributable images in the > git repository. If they are actually redistributable and freely > licensed, please document the location where they were obtained from, > their copyright owner and license. If they are non-redistributable > then you will need to rewrite the history of the git repository to > exclude them. > > Merge the two scripts into one supporting both versions of Python (or > just drop the Python 2 one). IIRC you can use the print function in > Python 2 by adding the line below. After that the remaining changes > don't look necessary, or can be made conditional with > sys.version_info. > > from future import print_function > > The first thing in the README.md should be a one-sentence description > of what the program does. > > Drop the Google Code mention/link from the README.md. > > The README.md mentions that webcamgrab.txt was taken from another > program, but doesn't mention the copyright/license information for the > file anywhere. While the SourceForge project for the other program > says GPLv3, the tarball containing the list of webcams doesn't mention > any license. > > Change the GPL reference at the start of the README.md to mention > which versions. > > The list of webcams is liable to get out of date, especially when > shipped with the script, it might be a good idea to have continuous > monitoring of the list, plus a way to auto-update it on end-user > systems. > > Consider switching to the XDG standard for some of the paths: > > https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html > https://wiki.archlinux.org/index.php/XDG_Base_Directory > https://github.com/srstevenson/xdg > > When I run check-all-the-things in the source tree, a number of the > checks produce output that is worth reviewing. > > https://github.com/collab-qa/check-all-the-things/ > > grep -ri gimp > codespell > doc8 > grep -r http: > proselint > spellintian > pycodestyle > pyflakes > pylint > vulture >