Path: csiph.com!newsfeed.xs4all.nl!newsfeed8.news.xs4all.nl!feeder3.usenet.farm!feeder2.usenet.farm!feeder1.feed.usenet.farm!feed.usenet.farm!aioe.org!bofh.it!news.nic.it!robomod From: Emmanuel Arias Newsgroups: linux.debian.maint.python Subject: Re: Newcomers project: DPMT/PAPT pristine-tar verification Date: Tue, 06 Oct 2020 20:40:02 +0200 Message-ID: References: X-Original-To: =?UTF-8?Q?Louis=2DPhilippe_V=C3=A9ronneau?= X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Oct 6 18:37:07 2020 Old-Return-Path: X-Amavis-Spam-Status: No, score=-3.4 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, BODY_8BITS=1.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FOURLA=0.1, HTML_MESSAGE=2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=no autolearn_force=no X-Policyd-Weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .yaerobi. - helo: .mail-wm1-x32c.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yaerobi-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nGt2pA5cxcZAFyY0x+7QJLEyFQRVljlyNYnhAT9orNQ=; b=jKPICUll+SznNjcqG81V9wE/a3JZpQSU0M9nztF+IV8L+KviQ4qrsaybYyEU7UsR71 qOEHzWxJZMMqSbKnHBnpy9dQoDRT3QwuBygMDlB+/T3k8ILtZLqrg/mPTLYWIp77E5Ci oAlzwyyZ4tvWw7q+v3t0+bFIuHghEX0k53ebGzUyJSF8JGmVTteNu/wOGsRZ+/kog0qt q2uTSGB8fQ0WQ2sUbY8jaMYPazCHRyX4GM6Ya0wtWECJrRXlOhQBLsPB1JDbuTZqsiv+ cNP6wOKyTchkpWNNQUinGqPEKpeJd4g0CiB8KyCwKOsCrMTcz00HfDyrL6FvNkB1g0nv trCw== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nGt2pA5cxcZAFyY0x+7QJLEyFQRVljlyNYnhAT9orNQ=; b=f4D4MxkWaWyCKq3SGf+TST1YQ8bCpFwb9CVTJENFPeYjlGheTEE1oQYus1sT9/JDmu hXgZ+v5Wj1wgE02jCp7szUNnMJLbTTaHEyk4jtqAvmbH/DQQxHRVftw96U2341u5vC7v BNUmiQCxmZhkBMP8BX0Mh33N1O1qWarO4JSjxasXznII9kIhyBTTJ3LQhaumV4u9Le4R +d85X89CQ9V/rhX2IXIqAdF77pmg5u8JbmIvavDac/Y/1X10ogl33SpTviKiEsEIsS4h Imk4Klb7dry7OCQ9eYa5k5fLBkk/QZvy/dpfoiLEIyy/qNnMNo5XSmhM0RHTjLfv9y7k Xgew== X-Gm-Message-State: AOAM532jwSS+99FuqigU2DfkbSKi+Ldxst+yC/5Ltsq1QnJuf2/2W9dq XAuknpdMRi35YjNx2e9BRmoefatmsyYu2ghbclCAhQ== X-Google-SMTP-Source: ABdhPJyeTbgWJzqYaURetBgkRE2JWgpCzMMmzDpUrCkp9Nl5GyF1wlAR9IiimtUvcTSMPDRL5K2HpFTJcPRWvYfuMlE= X-Received: by 2002:a1c:6341:: with SMTP id x62mr6226125wmb.70.1602009409774; Tue, 06 Oct 2020 11:36:49 -0700 (PDT) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cbfd3e05b104e148" X-Mailing-List: archive/latest/18690 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAFNO5odQCuViM7+HfJoMtifSFN5+WUJfeUUGO4W31JZdLRTPGQ@mail.gmail.com Approved: robomod@news.nic.it Lines: 218 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python X-Original-Date: Tue, 6 Oct 2020 15:36:38 -0300 X-Original-Message-ID: X-Original-References: <85853c9e-0111-4194-4537-d3e26022e5a6@debian.org> <095af26e-a04e-630d-2433-b4110e947b73@debian.org> Xref: csiph.com linux.debian.maint.python:12932 --000000000000cbfd3e05b104e148 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, IMO this is a good job for Janitor. I don't know if I would like to add the possibility to make the merge without human approval, but for me a MR from Janitor could be enough. On Tue, Oct 6, 2020 at 1:14 PM Louis-Philippe V=C3=A9ronneau wrote: > On 2020-10-06 12 h 07, Louis-Philippe V=C3=A9ronneau wrote: > > On 2020-10-03 15 h 35, Sandro Tosi wrote: > >> attached the dd-list of the packages missing the pristine-tar branch > (some > >> may have been moved/removed, but these are actual repos in DPT) > >> > >> On Fri, Jul 10, 2020 at 12:38 AM Sandro Tosi wrote: > >> > >>> Hello, > >>> i would like to propose a project to make sure our teams (DPMT/PAPT) > >>> repos are using pristine-tar properly. > >>> > >>> The checks i have in mind for now, are: > >>> > >>> * pristine-tar branch must exist, if not -> it's a bug > >>> * pristine-tar + upstream branch must produce the same tarball as > >>> downloaded from the archive, if not -> it's a bug > >>> * bonus point: fix the repo if it doesn't generate the right tarball > >>> and or the branch is missing. > >>> * bonus point: make this into a service that runs regularly (not > >>> strictly necessary to be limited to us) > >>> > >>> i guess we should have a brief discussion about additional checks > >>> and/or procedures before "assigning" it to a volunteer. let's say up > >>> to 2 weeks of discussion, and during the same period volunteers can > >>> nominate themselves. > >>> > >>> I marked this project as newcomers as it doesn't require to be a DD/D= M > >>> to work on it, you just need a salsa account and access to our teams. > >>> a handy tool to retrieve all our repos is at > >>> > >>> https://salsa.debian.org/python-team/tools/python-modules > >>> https://salsa.debian.org/python-team/tools/python-apps > >>> > >>> that contains a config file for `mr` and a `checkout` script to fetch > >>> the repos registered in that config file. > >>> > >>> Please feel free to discuss this project now :) > > > > I had a chat with folks in #debian-qa last night, as I agree such check= s > > would be nice to have. > > > > 1. Lintian is not suited for that kind of checks, as it does not have > > network access. Frankensteining lintian to do that kind of stuff would > > surely be met with fierce opposition. > > > > 2. The vcswatch script [1] from the QA team already does something akin > > to what we would want. It's written in Perl [2], but doesn't look > > terribly complicated. When a check doesn't pass, it issues an > > action-item like this one [3]. > > > > I think the first step would be modifying vcswatcher to issue warnings > for: > > > > * the absence of pristine-tar branches > > * missing git tags > > * repositories using 'master' instead of 'debian/master' as the main > branch > > > > Once these are flagged, we can easily script a way to fix them, maybe > > even using lintian-brush? > > I meant Debian Janitor here. > > I don't know the codebase enough, but in my mind, having the thing that > fixes problems and the thing that flags them be separate is valuable. I > don't know if Janitor follows that philosophy though. > > -- > =E2=A2=80=E2=A3=B4=E2=A0=BE=E2=A0=BB=E2=A2=B6=E2=A3=A6=E2=A0=80 > =E2=A3=BE=E2=A0=81=E2=A2=A0=E2=A0=92=E2=A0=80=E2=A3=BF=E2=A1=81 Louis-= Philippe V=C3=A9ronneau > =E2=A2=BF=E2=A1=84=E2=A0=98=E2=A0=B7=E2=A0=9A=E2=A0=8B pollo@debian.o= rg / veronneau.org > =E2=A0=88=E2=A0=B3=E2=A3=84 > > > > --000000000000cbfd3e05b104e148 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

IMO this is a good job for Janitor.= I don't know if I would like to add the possibility=C2=A0to make the
merge without human approval, but for me a MR from=C2=A0Janitor co= uld=C2=A0be enough.=C2=A0



On Tue, Oct 6,= 2020 at 1:14 PM Louis-Philippe V=C3=A9ronneau <pollo@debian.org> wrote:
On 2020-10-06 12 h 07, Louis-Philippe V=C3=A9ro= nneau wrote:
> On 2020-10-03 15 h 35, Sandro Tosi wrote:
>> attached the dd-list of the packages missing the pristine-tar bran= ch (some
>> may have been moved/removed, but these are actual repos in DPT) >>
>> On Fri, Jul 10, 2020 at 12:38 AM Sandro Tosi <morph@debian.org> wrote:
>>
>>> Hello,
>>> i would like to propose a project to make sure our teams (DPMT= /PAPT)
>>> repos are using pristine-tar properly.
>>>
>>> The checks i have in mind for now, are:
>>>
>>> * pristine-tar branch must exist, if not -> it's a bug<= br> >>> * pristine-tar + upstream branch must produce the same tarball= as
>>> downloaded from the archive, if not -> it's a bug
>>> * bonus point: fix the repo if it doesn't generate the rig= ht tarball
>>> and or the branch is missing.
>>> * bonus point: make this into a service that runs regularly (n= ot
>>> strictly necessary to be limited to us)
>>>
>>> i guess we should have a brief discussion about additional che= cks
>>> and/or procedures before "assigning" it to a volunte= er. let's say up
>>> to 2 weeks of discussion, and during the same period volunteer= s can
>>> nominate themselves.
>>>
>>> I marked this project as newcomers as it doesn't require t= o be a DD/DM
>>> to work on it, you just need a salsa account and access to our= teams.
>>> a handy tool to retrieve all our repos is at
>>>
>>> https://salsa.debian.org/pytho= n-team/tools/python-modules
>>> https://salsa.debian.org/python-t= eam/tools/python-apps
>>>
>>> that contains a config file for `mr` and a `checkout` script t= o fetch
>>> the repos registered in that config file.
>>>
>>> Please feel free to discuss this project now :)
>
> I had a chat with folks in #debian-qa last night, as I agree such chec= ks
> would be nice to have.
>
> 1. Lintian is not suited for that kind of checks, as it does not have<= br> > network access. Frankensteining lintian to do that kind of stuff would=
> surely be met with fierce opposition.
>
> 2. The vcswatch script [1] from the QA team already does something aki= n
> to what we would want. It's written in Perl [2], but doesn't l= ook
> terribly complicated. When a check doesn't pass, it issues an
> action-item like this one [3].
>
> I think the first step would be modifying vcswatcher to issue warnings= for:
>
> * the absence of pristine-tar branches
> * missing git tags
> * repositories using 'master' instead of 'debian/master= 9; as the main branch
>
> Once these are flagged, we can easily script a way to fix them, maybe<= br> > even using lintian-brush?

I meant Debian Janitor here.

I don't know the codebase enough, but in my mind, having the thing that=
fixes problems and the thing that flags them be separate is valuable. I
don't know if Janitor follows that philosophy though.

--
=C2=A0 =E2=A2=80=E2=A3=B4=E2=A0=BE=E2=A0=BB=E2=A2=B6=E2=A3=A6=E2=A0=80
=C2=A0 =E2=A3=BE=E2=A0=81=E2=A2=A0=E2=A0=92=E2=A0=80=E2=A3=BF=E2=A1=81=C2= =A0 Louis-Philippe V=C3=A9ronneau
=C2=A0 =E2=A2=BF=E2=A1=84=E2=A0=98=E2=A0=B7=E2=A0=9A=E2=A0=8B=C2=A0 =C2=A0<= a href=3D"mailto:pollo@debian.org" target=3D"_blank">pollo@debian.org /= vero= nneau.org
=C2=A0 =E2=A0=88=E2=A0=B3=E2=A3=84



--000000000000cbfd3e05b104e148--