Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From: Rafael David Tinoco <rafael.tinoco@canonical.com>
Newsgroups: linux.debian.bugs.dist,linux.debian.kernel
Subject: Bug#856328: Fix nfs-mountd dependency on rpcbind
Date: Mon, 27 Feb 2017 22:30:02 +0100
Message-ID: <tfB1M-2XP-11@gated-at.bofh.it>
Old-Return-Path: <debbugs@buxtehude.debian.org>
Reply-To: Rafael David Tinoco <rafael.tinoco@canonical.com>, 856328@bugs.debian.org
Resent-To: debian-bugs-dist@lists.debian.org
Resent-Cc: Debian kernel team <debian-kernel@lists.debian.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Approved: robomod@news.nic.it
Lines: 49
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
Xref: csiph.com linux.debian.bugs.dist:810190 linux.debian.kernel:57111

Package: nfs-utils
Version: 1:1.3.4-2
Severity: important
Tags: patch, fixed-upstream, sid,

Hello maintainer,

I'm fixing this behavior in Ubuntu and I think fixing it in Debian is needed:

https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/1590799

You can follow the upstream discussion for this fix:

https://www.spinics.net/lists/linux-nfs/msg62022.html

"""
Following commit 91da135f - it replaced "rpcbind.target" by "rpcbind.socket" in
some unit files - "rpcbind.socket" should also be added to "nfs-mountd.service"
as a dependency to avoid race conditions.

Usually "rpcbind.socket" is either started as a "sockets.target" dependency, or
as a dependency for "nfs-server.service", when unit files include it in
"BindsTo" or "After". Unfortunately there is a possilibility to have
"nfs-mountd.service" started when the rpcbind socket is not yet created:

systemd[1]: Starting NFS Mount Daemon...
systemd[1]: nfs-mountd.service: Control process exited, code=exited status=1
systemd[1]: Failed to start NFS Mount Daemon.
systemd[1]: nfs-mountd.service: Unit entered failed state.
systemd[1]: nfs-mountd.service: Failed with result 'exit-code'.

Nowadays "nfs-mountd.service" uses "BindTo" directive to "nfs-server.service".
That, per se, doesn't guarantee ordering for NFS server to start rpcbind and for
nfs-mountd to depend on it.

https://bugs.launchpad.net/bugs/1590799

Signed-off-by: Rafael David Tinoco <rafael.tinoco@xxxxxxxxxxxxx>
"""

These comments show the problem when nfs-kernel-server starts before
rpcbind.service is brought online (by rpcbind.socket):

https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/1590799/comments/24

Explanation:

https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/1590799/comments/25
https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/1590799/comments/30