Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Romain Perier Newsgroups: linux.debian.bugs.dist,linux.debian.kernel Subject: Bug#963033: linux-image-arm64: kexec loses EFI system tables with Debian kernels Date: Fri, 24 Jul 2020 15:20:02 +0200 Message-ID: References:

X-Original-To: Gabriel Krisman Bertazi , 963033@bugs.debian.org X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Fri Jul 24 13:15:11 2020 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: 1.202 Reply-To: Romain Perier , 963033@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: Debian Kernel Team X-Debian-Pr-Message: followup 963033 X-Debian-Pr-Package: src:linux X-Debian-Pr-Source: linux X-Spam-Bayes: score:0.0000 Tokens: new, 24; hammy, 135; neutral, 51; spammy, 0. spammytokens: hammytokens:0.000-+--H*UA:1.10.1, 0.000-+--H*u:1.10.1, 0.000-+--H*UA:2018-07-13, 0.000-+--H*u:2018-07-13, 0.000-+--H*r:TLS1_3 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Voix4MRwWXVo7BuxlllQ63EvsS/mtlYJh9o1gdFz9PY=; b=dV5hilLdRYcPVzijqmzXwtWgRwv65g2EZHOd3L0xQOuOe3FfMOXj3PJP/v6pE4XRUs r8wGRKTmGk/5wO60vjmmAN0a1JcaIetK4AYwlW8qLJce5MOt+2X5qkY6tBR8AwLP1uXy 8T3GizdtHRb21DhGz3/QLy/Erhg1L8EbULNE0WSVrh/ygMUYKgdFDZfuxJH3kJ/+zqIv A4oXvKc5E//g6xS8BJYSBhOG3pAgqVs++dJAhFafwb0uHw5Mho7IkrThr+48PJf8KZf/ Nk+yoIqhoMnyC9h2I/yqXDCSV1XrNF0Ck8eMJ3TBKH+XvpAPW6pNyQLYZxa/6i1wEq1p a9OQ== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Voix4MRwWXVo7BuxlllQ63EvsS/mtlYJh9o1gdFz9PY=; b=CR/tRZYPLnJRASghPoUVr7NeEOWpxNBViIPdEOQhdzSVRgYgiwDX7mAs2j8q1z2rNv s+HKpSnovE37wxSeMKrxqio15piU50+BIALyrtTxLBZrCRyWAGf8DnSe0o7Q1pSB7Uzb 1GvENdPPJjNwGARMue/tleLmJV8PosANZtnEQoXNC1qzrOmlsvzejvOU0C9ksY6vWcpL e68qgYwLgWaBZUvt2Tf+/iaIXUUrrrJLNRiGbaNYf1zcTOR4JGeyYWiIS+nAm3ayV9Nn LhEUhzIRaTaGA5spDZBfJnIW1/jsLrzCWPU37YO3kF1krtYSuWoeJW41EOvzyqhvvBe9 lcdg== X-Gm-Message-State: AOAM530aQjHvj/2E2Itn0WOOmoM6r57bT3dPDAXuPnP5yax1WbUPOFS0 JY3932BKwSmVto8Z2M9OjAmw8DN4 X-Google-SMTP-Source: ABdhPJyB+Wg4yYaMkvLR3q7lnWdOa8od75xkZXkcH7HhQp6JDIFG/4tw3bfJs/srFwbItTbXLoAtxw== X-Received: by 2002:a1c:1dc7:: with SMTP id d190mr8448337wmd.36.1595596345681; Fri, 24 Jul 2020 06:12:25 -0700 (PDT) X-Google-Original-From: Romain Perier MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mYCpIKhGyMATD0i+" Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Debian-Message: from BTS X-Mailing-List: archive/latest/1615281 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 51 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Fri, 24 Jul 2020 15:12:22 +0200 X-Original-Message-ID: <20200724131222.GA20639@hp-probook-450> X-Original-References: <159245605342.407.6332206929547963206.reportbug@debian> <874kqx7ei3.fsf@collabora.com> <20200722191115.GA28942@taurus.defre.kleine-koenig.org> <159245605342.407.6332206929547963206.reportbug@debian> <87eep34ae0.fsf@collabora.com> <159245605342.407.6332206929547963206.reportbug@debian> <87eep34ae0.fsf@collabora.com> Xref: csiph.com linux.debian.bugs.dist:1019131 linux.debian.kernel:67589 --mYCpIKhGyMATD0i+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 22, 2020 at 03:28:39PM -0400, Gabriel Krisman Bertazi wrote: Hi, Well, after an analyze on my side, the EFI mode is detected based on the EFI stub, right ? Then the kernel populates the FDT with EFI properties into its own address space (based on what was previously found from the stub). Kexec simply does not preserve the EFI mode at all for arm64, it is only present for x86. With the original debian patch, we suppose that the "secure-boot" property will always be set in the FDT, simply because this information should be found in the EFI stub (unset, disabled, enabled, etc...), so the corresponding FDT property will always have a value and will always be present. So assume that it is always the case is correct, imho. Now, if the EFI stubs informations are not passed to the second stage kernel, either nor "system table" or "secure-boot" or the rest will be found, explaining the issue of the first comment (read the first comment it is "System table" that is not found). We should have a "setup_efi_info" like it is the case in the kexec-tools code base for x86, except we should have something similar for arm64. Regards, Romain --mYCpIKhGyMATD0i+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEbpWHxyX/nlEWTnf8WhIh6CKeimAFAl8a3i4ACgkQWhIh6CKe imD+NxAAn2PcJQFUghyUKxqGc0c+g15ioSAG9e9pJfBSJxBU1m/c77hG8giB05/t RYas+Vk0HV2O6WOraEvgHndOJjXEF95FY/R4iyML9QW3PdeZb+ZzvUywJRUiIZ9B sW9LCJpgNvMBjh9MucSgdY2vbOlIzzLAZABUG/G5bgEN3ptfAe1TuNu+ciHdRuxa Lu2mQnCVXKZXvfa99HzmkbcV+pUq9Ibz4ZHdq3p0kZAQlDHHrdC1KPgtu+6pst28 xJ2R9bYqbflBLamSrPuJ8u0KTz2J1xTyjOUunPguWUwI52FRljTRHgxPUr5EmWTH TwdvD5M3Q7NTiVrAqok91/VCavtXd99pjaafWXaboDhax66GZwF1IBHtA+b2P9uN 4z4JO3b0AFxzeQyR8JU71jpCJI/ClCYZU1V5awOnT8x3EntFEjtgflmJkIo2HRP3 7lc6XMGF0+tBM3gtDEPl0XGZJBkJBGHm7GDWg9YP1VUY3ejgD8TzY8y8avFfxqTm uEU053qY4VNi1r0QVqJjBYHMWQ17UqAX4NCgqOuBUWpauYT3olvctA6YVh2B3GYx rpSL7hHunNdiy7RT63G176QAcWlpI7o5pkaYcMtiv0GiPvk+jKgpPLmZlBzk570N yMU85dG5RfgQRVcnLzq/LbTQ91H9feLgSslakGpOGxCIX1zV+V8= =XUGx -----END PGP SIGNATURE----- --mYCpIKhGyMATD0i+--