Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Pascal Vibet - ADACIS Newsgroups: linux.debian.bugs.dist Subject: Bug#903641: Preserve numlock state during cryptdisk boot password prompt in plymouth Date: Thu, 12 Jul 2018 20:00:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Thu Jul 12 17:51:09 2018 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -0.788 Reply-To: Pascal Vibet - ADACIS , 903641@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: Debian Cryptsetup Team X-Debian-Pr-Message: followup 903641 X-Debian-Pr-Package: cryptsetup-initramfs X-Debian-Pr-Source: cryptsetup X-Spam-Bayes: score:0.0000 Tokens: new, 28; hammy, 149; neutral, 69; spammy, 1. spammytokens:0.990-+--goods hammytokens:0.000-+--manpage, 0.000-+--H*r:e34, 0.000-+--H*RU:e34, 0.000-+--Hx-spam-relays-external:e34, 0.000-+--sk:cryptse Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=JdXrQuIlqVwZz5xbO89njqEHU1Qwi10k2rlfAiMllxI=; b=qiGNPO1Izusl+akVklGnDz7aN75LdsW6YKI5Nh943zNzRlBH9caPdGOs5MdigNSnoz 7f1qf8LgISgRejKITBVDFqIEvDtCXr2dg+D+Q1GAVh75AgdebT7BevGzVPmMze/puh0B LifUBgtorGODBXdAFHHoMKIhAM5Yeh7pqlsV1/mOxh5Owx3Xj15ltGPs2d9QRxVYFd7z EFAitLMD24CPDCS9QwueO/Dos4YFQpPNF4Fl6Ll17xfh0CxZsC+rytHTo0qHojyUQbw1 n17rhCjt3OnXXM4IcklMmIR5MUksNtEb1Lh5x76dUY7ZxYAFORyUghYCDx4K8AcOtzCR R9FA== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=JdXrQuIlqVwZz5xbO89njqEHU1Qwi10k2rlfAiMllxI=; b=Q//xTRNdcDUgpPLFe0odwnn/eqyPenNSAm5cZro/idw/vGTFygiiVOx0roVctuIBdX cv/xbU5OzTsceavc1qUdJoWP7/al0Le8OfxtU/zwo2oa+J6pVTEyWRZci4z2Qg9KcdRX aIs8mSq/ef1C5cLCqgBYd8rM+/Ibm9qfxQuyO6caXXFf90GWiPQXJ+cJDl1y0MO4zlTX mMv5E2zW0qIwdLseFPm1EPyNhBzGZAQ4dOCGJyaQIofUg57CV7jcxBQF4ffJWMqhNkqG COXCZIt31FddnFodzmBUlca2uk3Vezh8+TGkG9ZJ5Zxbnzf1M7XmJVF0psW9LVXxxmlB MrlA== X-Gm-Message-State: AOUpUlHIS2Ve24Czd9ZfsHqAP1XbaKgaj/+TUMHM2WU4ed4KHN9U5Vxj hNs4mlpeH6RXKlEeKka8n/qYFQ== X-Google-SMTP-Source: AAOMgpdmE0HXhIgMCpahy6X915xpRwcgUve5RSuyzIanSVED9Af081PN85+26zq4wlCwysB+sfEx7w== X-Received: by 2002:adf:c4a7:: with SMTP id m36-v6mr2489207wrf.103.1531417564449; Thu, 12 Jul 2018 10:46:04 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="------------1F89A8556C552AC1AECB9413" Content-Language: en-US X-Debian-Message: from BTS X-Mailing-List: archive/latest/1472326 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 125 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Thu, 12 Jul 2018 19:46:02 +0200 X-Original-Message-ID: X-Original-References: <20180712134820.GA2525@localhost.localdomain> <20180712134820.GA2525@localhost.localdomain> Xref: csiph.com linux.debian.bugs.dist:907448 This is a multi-part message in MIME format. --------------1F89A8556C552AC1AECB9413 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Le 12/07/2018 à 15:48, Guilhem Moulin a écrit : > Why only in cryptopensc and not in cryptroot? Also /usr/bin/setleds > comes from the ‘kbd’ package which cryptsetup-initramfs doesn't depend > on (it's only a Recommends, not a hard Depends), so `copy_exec` needs to > wrapped to check for the program's existence. Because i don't test with cryptroot. For package depends or Recommends, the /usr/share/initramfs-tools/hooks/cryptopensc script need 'dpkg-architecture' program to work and it is in 'dpkg-dev' package||. But you are right, 'setleds'  is not the goods choice to keep numlock state. I will search a better program. Regards Le 12/07/2018 à 15:48, Guilhem Moulin a écrit : > Control: severity -1 minor > > Hi, > > On Thu, 12 Jul 2018 at 15:02:20 +0200, Pascal Vibet - ADACIS wrote: >> So, i apply modifications like this: >> in /usr/share/initramfs-tools/hooks/cryptopensc: >> […] >> in /usr/share/initramfs-tools/scripts/local-top/cryptopensc: > Why only in cryptopensc and not in cryptroot? Also /usr/bin/setleds > comes from the ‘kbd’ package which cryptsetup-initramfs doesn't depend > on (it's only a Recommends, not a hard Depends), so `copy_exec` needs to > wrapped to check for the program's existence. > >>> INITTY=/dev/tty[1-8] >>> for tty in $INITTY ; do >>>     setleds -D +num < $tty >>> done > Does that really *preserve* the numlock state? I'm not familiar with > setleds(1), but according to the manpage it *sets* numlock and changes > the default settings. > > Cheers, --------------1F89A8556C552AC1AECB9413 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi,

Le 12/07/2018 à 15:48, Guilhem Moulin a écrit :
Why only in cryptopensc and not in cryptroot?  Also /usr/bin/setleds
comes from the ‘kbd’ package which cryptsetup-initramfs doesn't depend
on (it's only a Recommends, not a hard Depends), so `copy_exec` needs to
wrapped to check for the program's existence.
Because i don't test with cryptroot. For package depends or Recommends, the /usr/share/initramfs-tools/hooks/cryptopensc script need 'dpkg-architecture' program to work and it is in 'dpkg-dev' package.

But you are right, 'setleds'  is not the goods choice to keep numlock state.
I will search a better program.

Regards

Le 12/07/2018 à 15:48, Guilhem Moulin a écrit :
Control: severity -1 minor

Hi,

On Thu, 12 Jul 2018 at 15:02:20 +0200, Pascal Vibet - ADACIS wrote:
So, i apply modifications like this:
in /usr/share/initramfs-tools/hooks/cryptopensc:
[…]
in /usr/share/initramfs-tools/scripts/local-top/cryptopensc:
Why only in cryptopensc and not in cryptroot?  Also /usr/bin/setleds
comes from the ‘kbd’ package which cryptsetup-initramfs doesn't depend
on (it's only a Recommends, not a hard Depends), so `copy_exec` needs to
wrapped to check for the program's existence.

INITTY=/dev/tty[1-8]
for tty in $INITTY ; do
    setleds -D +num < $tty
done
Does that really *preserve* the numlock state?  I'm not familiar with
setleds(1), but according to the manpage it *sets* numlock and changes
the default settings.

Cheers,

--------------1F89A8556C552AC1AECB9413--