Path: csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod From: Johannes Schauer Marin Rodrigues Newsgroups: linux.debian.bugs.dist Subject: Bug#1055065: doesnt find useradd Date: Mon, 18 Dec 2023 23:50:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Mon Dec 18 22:48:11 2023 Old-Return-Path: X-Spam-Flag: NO X-Spam-Score: -4.009 Reply-To: Johannes Schauer Marin Rodrigues , 1055065@bugs.debian.org Resent-To: debian-bugs-dist@lists.debian.org Resent-Cc: Matthias Klumpp X-Debian-Pr-Message: followup 1055065 X-Debian-Pr-Package: debspawn X-Debian-Pr-Keywords: upstream X-Debian-Pr-Source: debspawn Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="===============6325329358362959800==" MIME-Version: 1.0 Content-Disposition: inline User-Agent: alot/0.10 X-Debian-User: josch X-Debian-Message: from BTS X-Mailing-List: archive/latest/1811971 List-ID: List-URL: Approved: robomod@news.nic.it Lines: 99 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: hlieberman@debian.org, mh+debian-packages@zugschlus.de X-Original-Date: Mon, 18 Dec 2023 23:44:47 +0100 X-Original-Message-ID: <170293948786.1712802.827259598751255930@localhost> X-Original-References: <169868249739.59752.348931429370489346.reportbug@fan.zugschlus.de> Xref: csiph.com linux.debian.bugs.dist:1179231 --===============6325329358362959800== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, I'm the author of the change that removed Priority:Required packages from build-essential. Since there has been no other input to this bug I thought I just weigh in with my two cents. On Tue, 5 Dec 2023 22:39:51 +0000 Harlan Lieberman-Berg wrote: > On Mon, 30 Oct 2023 17:14:57 +0100 Marc Haber > wrote: > > debspawn create sid errors out because the tool cannot find useradd. I > > have added adduser manually to "include_pkgs" in osbase.py and this > > allows debspawn create sid to finish. >=20 > I've done a bit of digging, and I traced this problem back to a change > in the way debootstrap works when installing the buildd variant, which > is what debspawn uses. In bug 837060, debootstrap stopped installing > packages which were Priority: Required but not essential. You CC-ed that bug in your last message but since the bug is archived I don= 't think that had the effect you intended. > Specifically, the passwd package is the cause here; failure to install > passwd means that the `useradd` command is not available. The reason > that installing the adduser package fixed this is that adduser depends > on passwd, so it was indirectly pulled in. > It's certainly easy enough for us to fix on the debspawn side -- we can j= ust > unilaterally add the passwd package -- but it is a bit... strange for us= to > have to fix. It seems, to me, like this is something we should be able to > rely on debootstrap for. I've copied the relevant bug; hopefully we can = get > some input from the bootstrap folx. (Maybe we should be using the minbase > variant instead? Except we're always building packages... should we be us= ing > a specific user? I'm not sure!) My main motivation for this change in debootstrap was to prevent source packages from missing to declare build dependencies because the buildd debootstrap variant automatically pulls in Priority:required packages and t= hus missing B-Ds on mount or tzdata or similar would go unnoticed. I think my change had a similar effect here. Your code requires a package t= hat is not Essential:yes (passwd) and you did not explicitly install it but rel= ied on it getting installed implicitly. In my opinion, the correct way forward would be to explicitly pull in all the packages your code needs (except of course if they are Essential:yes). I'm sorry that my change has caused you = more work but in the end I think it helped discover a dependency of your code th= at you did not make explicit. Thanks! cheers, josch P.S.: Funny side note: missing passwd in the buildd profile is actually only possible due to *two* changes that I triggered. One is the change in debootstrap that you found but the other is apt no longer depending on addu= ser. If it still did, you would not have a problem even with the current handlin= g of the buildd variant. See https://salsa.debian.org/apt-team/apt/-/merge_requests/260/diffs --===============6325329358362959800== MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Description: signature Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmWAy1wACgkQ8sulx4+9 g+Ff8g/+JrjCiN5S/AggfX1N+BY8NiZPohGWe0Od9CureoTeSgU4J75qE+ifwp2d gC8DxBIunxG5aYvVCf9uHObe91G6seAgaOw62hK+8hEg1Ryikzn0sHZwu0uIxj90 Wji3bjg8kA+nJg/IPOv0Fd36vxPqyUSWp5g8Ry3uyTx3DwJdYrXqRvVT7CatvO+o FCDY3N7WxB+r6OCVBvIqf1osuA9rFRIfJ0ZDOjUpTCdP1spMHdDNQnA2LKyTPqzQ y9fl4ohW/DGs2vhHjVGAScZ3I6UHuE9YZfJPn9Z7N3KGOBvg9yc6lEDxl/TT+fU6 h9643TXgwzzRyT0TjJbusGmsK0DxP18KYfWo0mXcrfCULsXUuxFq9vdNpDxA9RZr RfJ0nfttmZ0GoDhsB9LSPfajKNp9tSAl/1Oo9TmN8numOUIbHVQKZ3ySNrNzYIh+ HPFlHWB7KrtUlyzqUw8hdsz1T/p7Jg0hwCFUsuxNHtxznxVdHTccLTNE4R1Eljot YqJzvCNtb7pMEB0FQzyGveIBFJrveeDFbHPU8lfeQPTPeETkEP4miY1VfuHzbk3u Vd9O8gxlLKP41JJWrPtLtzD433Pi5TxfJvEQJ/1DZYTP1qW7uhidF8/Ii4w1s6hF WJjUvNigP5kyI6nNxaB0a+QjRqd7vQyd2tK4KYNCgbJ2xRcvEOQ= =lyBW -----END PGP SIGNATURE----- --===============6325329358362959800==--