Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed2a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.009 X-Spam-Evidence: '*H*': 0.98; '*S*': 0.00; 'returned.': 0.07; 'builtin': 0.09; 'function,': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'subject:How': 0.10; 'jan': 0.12; 'iterator': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'reedy': 0.16; 'wrote:': 0.18; 'header:User-Agent:1': 0.23; "shouldn't": 0.24; 'define': 0.26; 'order.': 0.26; 'defined': 0.27; 'values': 0.27; 'header:X -Complaints-To:1': 0.27; 'van': 0.27; 'header:In-Reply-To:1': 0.27; 'function': 0.29; 'am,': 0.29; "doesn't": 0.30; 'comparison': 0.31; 'keys': 0.31; 'agree': 0.35; 'leads': 0.36; 'returning': 0.36; 'doing': 0.36; 'useful': 0.36; 'wrong': 0.37; 'to:addr:python-list': 0.38; 'fact': 0.38; 'to:addr:python.org': 0.39; 'received:org': 0.40; 'called': 0.40; 'according': 0.40; 'maximum': 0.63; 'refer': 0.63; 'default': 0.69; 'received:fios.verizon.net': 0.84; 'albert': 0.91; 'items,': 0.91; 'received:108': 0.93 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Terry Reedy Subject: Re: How is max supposed to work, especially key. Date: Thu, 04 Dec 2014 10:47:21 -0500 References: <547760b3$0$6876$e4fe514c@dreader36.news.xs4all.nl> <548032dd$0$15926$e4fe514c@dreader35.news.xs4all.nl> <548038f8$0$15841$e4fe514c@dreader35.news.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: pool-108-16-203-145.phlapa.fios.verizon.net User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: <548038f8$0$15841$e4fe514c@dreader35.news.xs4all.nl> X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 19 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1417708068 news.xs4all.nl 2976 [2001:888:2000:d::a6]:33091 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:81912 On 12/4/2014 5:35 AM, Albert van der Horst wrote: > I agree that it is a useful function and that it is doing > the right thing. What is wrong is the name. > I refer to the fact that it is not returning the maximum. > It returns the iterator value that leads to the maximum. > A function that doesn't return a maximum shouldn't be called > maximum. The key function serves the same purpose as with sort. It define a custom ordering of items, not the values returned. 'x < y' is defined as key(x) < key(y), where the comparison of keys uses the standard (and for numbers, natural) built-in ordering. So max returns the max value according to the order you define with the key function. The default key is the identity function, so the default order is the builtin order. -- Terry Jan Reedy