Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed4a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <002001d0072d$b9b5da50$2d218ef0$@gmail.com>
References: <002001d0072d$b9b5da50$2d218ef0$@gmail.com>
Date: Mon, 24 Nov 2014 02:21:35 +1100
Subject: Re: Comprehension with two variables - explanation needed
From: Chris Angelico <rosuav@gmail.com>
Cc: "python-list@python.org" <python-list@python.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.16186.1416756098.18130.python-list@python.org>
Lines: 130
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:81370

On Mon, Nov 24, 2014 at 1:56 AM, Ivan Evstegneev
<webmailgroups@gmail.com> wrote:
>
> Hello guys,
>
> I would like to ask you for some explanations on comprehensions. (Don=E2=
=80=99t be scared, it just some particular example ^_^)
>
> I found this little =E2=80=9Cfind prime number=E2=80=9D example over the =
internet:
>
> >>> noprimes =3D [j for i in range(2, 8) for j in range(i*2, 50, i)]
> >>> primes =3D [x for x in range(2, 50) if x not in noprimes]
> >>> print primes
>
> [2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47]

Okay, this is a pretty ham-fisted way of enumerating prime numbers,
but let me walk you through it. First, let's look at the composite
numbers (the 'noprimes' list). That comprehension is identical (apart
from some details that don't matter here) to this:

noprimes =3D []
for i in range(2,8):
    for j in range(i*2, 50, i):
        noprimes.append(j)

So, as you correctly deduced below, what you have is this list:
[4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30, 32, 34, 36, 38,
40, 42, 44, 46, 48, 6, 9, 12, 15, 18, 21, 24, 27, 30, 33, 36, 39, 42,
45, 48, 8, 12, 16, 20, 24, 28, 32, 36, 40, 44, 48, 10, 15, 20, 25, 30,
35, 40, 45, 12, 18, 24, 30, 36, 42, 48, 14, 21, 28, 35, 42, 49]

The inner loop (with j as its iteration variable) counts up in
increments of i, starting at twice i, stopping once it's gone past
fifty. That means it's every multiple of i other than i itself, which
means these are by definition composite numbers. Note that quite a few
of the numbers are coming up more than once; this would be more
efficient as a set comprehension, but leave that aside for now.

Note also that the range for i has to go as far as the square root of
the number we're working with - we have to go as far as 7*7=3D=3D49. If
you want primes to some higher cap, say 100, you'd need to also
increase that, eg range(2,11).

> The change that I tried to apply to this comprehension would lead to the =
following pattern: noprimes =3D =3D [[4, 6,8=E2=80=A648], [6, 9, 12=E2=80=
=A6.], =E2=80=A6.,[some numbers]]
>
> But despite my struggling on it for the whole day, I haven=E2=80=99t got =
to the desirable result(using comprehensions only)
>
> Please, don=E2=80=99t get me wrong, I=E2=80=99m not a lazy one (just a be=
ginner).
>
> In my case, I  made some googling, and found some patterns for matrices, =
that look this one(for example):
>
> Matrix =3D [[0 for x in range(5)] for x in range(5)]

The inner lists there can be created more simply, since you're working
with integers:

[[0]*5 for x in range(5)]

> But when I tried to use square brackets with my code, it yields an error =
about definition of =E2=80=9Ci=E2=80=9D, for instance:
>
> File "<pyshell#30>", line 1, in <module>
>
> noprimes =3D [[j for i in range(2, 8)] for j in range(i*2, 50, i)]
>
> NameError: name 'i' is not defined.

That's because you have your nesting backwards. Instead of having the
for loops running left-to-right, they now are explicitly bracketed to
be the other way around. This is more like:

noprimes =3D []
for j in range(i*2, 50, i):
    noprimes.append([j for i in range(2, 8)])

which can be unrolled another level:

noprimes =3D []
for j in range(i*2, 50, i):
    tmp =3D []
    for i in range(2, 8):
        tmp.append(j)
    noprimes.append(tmp)

Now you can see why i doesn't exist there.

> So I moved further, and succeeded to solve my problem in a different mann=
er:
> >>> noprimes=3D[]
>
> >>> for i in range(2,8):
>
> noprimes.append(list(range(i*2,50,i)))
>
> Which yields, in fact, the matrix I wanted from the beginning:
>
> Yep, this the =E2=80=9Cclassical=E2=80=9D way for me, on the other hand I=
 have the feeling, that this is not, the ultimate solution. ^_^

In fact, this is exactly right, and now you can easily translate that
back to list comp syntax:

noprimes =3D [list(range(i*2,50,i)) for i in range(2,8)]

> So my questions is still persists:
>
> 1)      Is it possible to realize such a thing by applying changes only t=
o initial comprehension? If yes, it would be nice to see the solution.
> 2)      How actually bad is my solution? I mean, after all, there are nes=
ted functions call in my code,  so how much the speed is affected(if any)?

Don't worry about speed of function calls. The algorithm used here is
so utterly appalling that it's going to get in your way long before
the performance of Python will. :)

List comprehensions are fairly readily convertible to and from
explicit loops. There are a couple of minor differences (a list comp
is actually executed inside a nested function, so the loop iterator
variable can't leak out), but generally, if you're having trouble,
just unroll the comprehension into a loop and see if it makes more
sense.

ChrisA