Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!news.albasani.net!news.stack.nl!newsfeed.xs4all.nl!newsfeed1a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
From: Juan Christian <juan0christian@gmail.com>
Date: Sun, 23 Nov 2014 13:44:31 +0000
Subject: Python Signal/Slot + QThred code analysis
To: Python <python-list@python.org>
Content-Type: multipart/alternative; boundary=001a11c1ee24ae5e2a050886e020
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.16182.1416750280.18130.python-list@python.org>
Lines: 89
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:81364

--001a11c1ee24ae5e2a050886e020
Content-Type: text/plain; charset=UTF-8

This is a continuation of my other topic "How to access Qt components
loaded from file", it was getting big and the focus changed completely, the
real question there was already answered, and we were talking about
signal/slot, QThred and other things.

So, I read on the web (didn't find books talking about QThred, Signal/Slot)
and I came up with this code:

Python 3.4.2
PySide 1.2.2

from PySide.QtCore import QObject, QThread, Signal
import requests
import bs4

class Outpost(QObject, QThread):
    received = Signal()

def __init__(self, uid, *args, **kwargs):
    super().__init__(*args, **kwargs)
    self.url = 'http://www.myurl.com/user/' + uid

def run(self):
    soup = bs4.BeautifulSoup(requests.get(self.url).text)

    with soup.select('div.stat_box div.value')[0].get_text().replace(',',
'') as a, soup.select('div.stat_box div.value')[1].get_text() as b:
        self.info_a = a
        self.info_b = b

    self.received.emit(self)

Is this code good?

I'll explain what I think this code does, when I was doing this: First I
created my custom signal, 'received'. Then I made my __init__ just to set a
uid.

Then, the run func, I read that's the one that will run when working with
threads. Here I set the soup and I get the page content using requests,
that's the part that will take more time.

Then I use bs4 to set my data, and yes, I know that getting data this way
isn't the best option, but I don't have other choice, they don't give APIs
for this stuff.

Later I emit my signal when I have everything set and I pass the entire
class with it so I can call the 'var.info_a' and 'bar.info_b' wherever I
want.

Did I think correctly, can I do anything better here? Many thanks.

--001a11c1ee24ae5e2a050886e020
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

This is a continuation of my other topic &quot;How to access Qt components =
loaded from file&quot;, it was getting big and the focus changed completely=
, the real question there was already answered, and we were talking about s=
ignal/slot, QThred and other things.<br><br>So, I read on the web (didn&#39=
;t find books talking about QThred, Signal/Slot) and I came up with this co=
de:<br><br>Python 3.4.2<div>PySide 1.2.2<br><br>from PySide.QtCore import Q=
Object, QThread, Signal<br>import requests<br>import bs4<br><br>class Outpo=
st(QObject, QThread):<br>=C2=A0 =C2=A0 received =3D Signal()<br><br> def __=
init__(self, uid, *args, **kwargs):<br>=C2=A0 =C2=A0 super().__init__(*args=
, **kwargs)<br>=C2=A0 =C2=A0 self.url =3D &#39;<a href=3D"http://www.myurl.=
com/user/">http://www.myurl.com/user/</a>&#39; + uid<br><br>def run(self):<=
br>=C2=A0 =C2=A0 soup =3D bs4.BeautifulSoup(requests.get(self.url).text)<br=
><br>=C2=A0 =C2=A0 with soup.select(&#39;div.stat_box div.value&#39;)[0].ge=
t_text().replace(&#39;,&#39;, &#39;&#39;) as a, soup.select(&#39;div.stat_b=
ox div.value&#39;)[1].get_text() as b:<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.=
info_a =3D a<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.info_b =3D b<br><br>=C2=A0=
 =C2=A0 self.received.emit(self)<br><br>Is this code good?<br><br>I&#39;ll =
explain what I think this code does, when I was doing this: First I created=
 my custom signal, &#39;received&#39;. Then I made my __init__ just to set =
a uid.<br><br>Then, the run func, I read that&#39;s the one that will run w=
hen working with threads. Here I set the soup and I get the page content us=
ing requests, that&#39;s the part that will take more time.<br><br><div>The=
n I use bs4 to set my data, and yes, I know that getting data this way isn&=
#39;t the best option, but I don&#39;t have other choice, they don&#39;t gi=
ve APIs for this stuff.<br><br>Later I emit my signal when I have everythin=
g set and I pass the entire class with it so I can call the &#39;var.info_a=
&#39; and &#39;bar.info_b&#39; wherever I want.<br><br>Did I think correctl=
y, can I do anything better here? Many thanks.<br></div></div>

--001a11c1ee24ae5e2a050886e020--