Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed4a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
Return-Path: <python.list@tim.thechases.com>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.001
X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'root': 0.05; 'finally:': 0.07; 'except:': 0.09; 'exception,': 0.09; 'raises': 0.09; 'try:': 0.09; 'cc:addr:python-list': 0.11; '-tkc': 0.16; 'from:addr:python.list': 0.16; 'from:addr:tim.thechases.com': 0.16; 'from:name:tim chase': 0.16; 'received:174.136': 0.16; 'underlying': 0.16; 'exception': 0.16; 'wrote:': 0.18; 'cc:addr:python.org': 0.22; 'alternate': 0.24; 'skip:e 30': 0.24; 'cc:2**0': 0.24; 'gets': 0.27; 'header:In-Reply-To:1': 0.27; 'chris': 0.29; 'generally': 0.29; 'raise': 0.29; 'something': 0.35; 'case,': 0.35; 'but': 0.35; 'received:10': 0.37; 'to:addr:gmail.com': 0.65; 'bare': 0.84
X-Sender-Id: wwwh|x-authuser|tim@thechases.com
X-Sender-Id: wwwh|x-authuser|tim@thechases.com
X-MC-Relay: Neutral
X-MailChannels-SenderId: wwwh|x-authuser|tim@thechases.com
X-MailChannels-Auth-Id: wwwh
X-MC-Loop-Signature: 1416017532002:3224917904
X-MC-Ingress-Time: 1416017532002
Date: Fri, 14 Nov 2014 20:14:53 -0600
From: Tim Chase <python.list@tim.thechases.com>
To: Chris Angelico <rosuav@gmail.com>
Subject: Re: I love assert
In-Reply-To: <CAPTjJmr-k=b-JEXXJDA4K+hK2Zvnf8o7N3AZBeNVQzUa3YwtYQ@mail.gmail.com>
References: <96c138e4-ab95-4e5f-a0c8-e696b5a926bb@googlegroups.com> <cf68f3b4-3312-4dda-a224-8f30f7b31b55@googlegroups.com> <87a93wqeq3.fsf@elektro.pacujo.net> <mailman.15744.1415829173.18130.python-list@python.org> <87y4rgozgd.fsf@elektro.pacujo.net> <mailman.15746.1415829905.18130.python-list@python.org> <0cdc67f4-d9d5-4a73-91fe-7558161246af@googlegroups.com> <mailman.15750.1415832125.18130.python-list@python.org> <28e159ff-3d64-4793-9082-05cf1553c7c2@googlegroups.com> <87h9y4owgc.fsf@elektro.pacujo.net> <54669308$0$13002$c3e8da3$5496439d@news.astraweb.com> <87h9y1l3tt.fsf@elektro.pacujo.net> <mailman.15836.1416013493.18130.python-list@python.org> <87a93tl07u.fsf@elektro.pacujo.net> <CAPTjJmr-k=b-JEXXJDA4K+hK2Zvnf8o7N3AZBeNVQzUa3YwtYQ@mail.gmail.com>
X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-AuthUser: tim@thechases.com
Cc: "python-list@python.org" <python-list@python.org>
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <https://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list/>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <https://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.15838.1416017544.18130.python-list@python.org>
Lines: 28
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1416017544 news.xs4all.nl 2847 [2001:888:2000:d::a6]:44153
X-Complaints-To: abuse@xs4all.nl
Xref: csiph.com comp.lang.python:80800

On 2014-11-15 12:48, Chris Angelico wrote:
> conn =3D establish_database_connection()
> try:
>     do_stuff()
> finally:
>     conn.rollback()

this sounds suspiciously like you'd never actually commit.  Do you
mean something like

  conn =3D establisth_database_connection()
  try:
    do_stuff(conn)
  except:
    conn.rollback()
    raise

instead?

I don't generally like bare excepts, but in this case, the exception
just gets re-raised, so I feel Less Bad=E2=84=A2 about it (there's still the
case where the rollback call raises some alternate exception,
obfuscating the underlying root issue).

-tkc