Path: csiph.com!usenet.pasdenom.info!news.albasani.net!feeder.erje.net!eu.feeder.erje.net!bcyclone03.am1.xlned.com!bcyclone03.am1.xlned.com!newsfeed.xs4all.nl!newsfeed3.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.056 X-Spam-Evidence: '*H*': 0.89; '*S*': 0.00; 'initialize': 0.07; 'killer': 0.07; 'none:': 0.07; 'variables': 0.07; 'immutable': 0.09; 'mess': 0.09; 'cc:addr:python-list': 0.11; 'python': 0.11; '2.7': 0.14; "wouldn't": 0.14; '"in': 0.16; 'determines': 0.16; 'throw': 0.16; 'two.': 0.16; 'wrote:': 0.18; 'thanks.': 0.20; 'putting': 0.22; 'cc:addr:python.org': 0.22; 'either.': 0.24; 'refers': 0.24; 'subject:Code': 0.24; 'cc:2**0': 0.24; 'cc:no real name:2**0': 0.24; 'define': 0.26; 'order.': 0.26; 'player': 0.26; 'suggested': 0.26; 'second': 0.26; 'header:In-Reply-To:1': 0.27; 'wondering': 0.29; 'message-id:@mail.gmail.com': 0.30; 'url:mailman': 0.30; 'code': 0.31; 'comments': 0.31; 'lines': 0.31; 'types.': 0.31; 'writes:': 0.31; 'class': 0.32; 'lists': 0.32; 'url:python': 0.33; 'comment': 0.34; 'table': 0.34; 'could': 0.34; 'classes': 0.35; 'received:google.com': 0.35; 'like,': 0.36; 'done': 0.36; 'url:listinfo': 0.36; 'url:org': 0.36; 'should': 0.36; 'two': 0.37; 'being': 0.38; 'button': 0.38; 'feedback': 0.38; 'lists.': 0.38; 'nov': 0.38; 'pm,': 0.38; 'does': 0.39; 'url:mail': 0.40; 'read': 0.60; 'blank': 0.60; 'games,': 0.60; 'medical': 0.61; 'john': 0.61; "you're": 0.61; 'first': 0.61; 'real': 0.63; 'more': 0.64; 'cards': 0.65; 'pays': 0.65; 'to:addr:gmail.com': 0.65; 'biggest': 0.67; 'smith': 0.68; 'serial': 0.72; 'increase': 0.74; 'hand': 0.80; 'amateur': 0.84; 'email addr:panix.com': 0.84; 'doctor': 0.91; 'sitting': 0.91; 'imagine': 0.93; 'tomorrow': 0.95 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=NZ0UpFUATyRWP26+JwcyCGpKtu0UVyN2cFKDZBenD50=; b=eqDhR+9ueFfQLPg3hRthi5U3d0TiGeDHE/WExMQ531Cbg8fGwrCuyS/jMWQN9Qo2NY LDuZJTK8KZAGiUWR4iWGXEqu3RD20c/+fwuWNBB8ttj+YXD5Y1AVpRMMGHqAsyXjjuPS ptfpDGJTFGBvsApKxzI61L0WB5LJvCYpiR4r8LQXd93gDLvvGYlztaalPBUj9P7k+FE6 hNRotV4K/HvHaColQnHJnWg0ZUrwv/2N59PPczsDSCGVB4ThreViluGqJ9SoKMTR+oCL qx5nP8p6rDw1NKXiYo2ZxdqnaC3bUajkBEpmVgUJFi5G8ZTJxr+N7OcyeHaC4f+j1syf zWGw== MIME-Version: 1.0 X-Received: by 10.112.41.168 with SMTP id g8mr63884579lbl.59.1415168619988; Tue, 04 Nov 2014 22:23:39 -0800 (PST) In-Reply-To: <19b75713-78cd-4dad-976d-096653c058de@googlegroups.com> References: <19b75713-78cd-4dad-976d-096653c058de@googlegroups.com> Date: Tue, 4 Nov 2014 22:23:39 -0800 Subject: Re: Code review From: C Smith To: sohcahtoa82@gmail.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: python-list@python.org X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 53 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1415168622 news.xs4all.nl 2926 [2001:888:2000:d::a6]:45832 X-Complaints-To: abuse@xs4all.nl X-Received-Bytes: 5969 X-Received-Body-CRC: 3568021 Xref: csiph.com comp.lang.python:80247 >Jean-Michel wrote: >replace > if left_to_act is None: > left_to_act =3D [] > self.left_to_act =3D left_to_act >by > self.left_to_act =3D left_to_act or [] I read that with 2.7 that I had to initialize class variables to immutable types. I think because I was working with the lists before they had been altered and were still empty lists. I will mess around tomorrow with the classes you suggested as I have yet to make use of decorators. Thanks. I will work on putting some more comments in as well. On Tue, Nov 4, 2014 at 4:09 PM, wrote: > On Tuesday, November 4, 2014 12:35:32 PM UTC-8, John Gordon wrote: >> C Smith writes: >> >> > I was wondering if I could get some feedback on the biggest thing I >> > have done as an amateur Python coder. >> >> Comments. >> >> You need a *lot* more comments. >> >> Like, every line or two of code should have a comment explaining what is >> being accomplished. Seriously. Every line or two. >> >> Some blank lines wouldn't hurt either. >> >> Also it would be nice to define some of the terms you're using. What is >> a blind? What does "in front" mean? What is a "muck hand"? >> >> -- >> John Gordon Imagine what it must be like for a real medical doct= or to >> gordon@panix.com watch 'House', or a real serial killer to watch 'Dex= ter'. > > A "blind" is a required bet that the two people sitting to the left of th= e button have to make before a hand begins. The first player pays the smal= l blind and the second player pays the big blind, which is double the small= blind. For tournament games, the blinds increase periodically. > > Mucking a hand means to throw your cards away without revealing them. In= professional Poker, you typically give them to the dealer. > > "In front" just refers to table position which determines play order. > -- > https://mail.python.org/mailman/listinfo/python-list