Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed4a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.002 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'from:addr:yahoo.co.uk': 0.04; 'args': 0.07; 'tries': 0.07; 'lawrence': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'repeated': 0.09; 'try:': 0.09; 'def': 0.12; 'language.': 0.14; 'func': 0.16; 'letting': 0.16; 'optional.': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'sure.': 0.16; 'subject:python': 0.16; 'language': 0.16; 'wrote:': 0.18; 'variable': 0.18; 'header :User-Agent:1': 0.23; "aren't": 0.24; 'mathematical': 0.24; 'suggested': 0.26; 'pass': 0.26; 'header:X-Complaints-To:1': 0.27; 'header:In-Reply-To:1': 0.27; 'idea': 0.28; 'function': 0.29; 'is?': 0.30; "i'm": 0.30; 'program,': 0.31; 'subject:some': 0.31; 'text': 0.33; 'entirely': 0.33; 'display': 0.35; 'but': 0.35; 'google': 0.35; 'should': 0.36; 'feedback': 0.38; 'to:addr:python- list': 0.38; 'rather': 0.38; 'does': 0.39; 'to:addr:python.org': 0.39; 'received:org': 0.40; 'hope': 0.61; 'email addr:gmail.com': 0.63; 'our': 0.64; 'charset:windows-1252': 0.65; 'funny': 0.74; 'subject:!!!': 0.74; 'subject:get': 0.81; 'again?': 0.84; 'excessive': 0.84; 'subject:Love': 0.91 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Mark Lawrence Subject: Re: Love to get some feedback on my first python app!!! Date: Mon, 22 Sep 2014 17:10:24 +0100 References: <42e68de9-7528-46fc-8c74-c0baa1d6199e@googlegroups.com> <9bed8e07-9e22-4131-92e8-f950cb5c0d18@googlegroups.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: host-92-18-1-76.as13285.net User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 In-Reply-To: X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 36 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1411402454 news.xs4all.nl 2934 [2001:888:2000:d::a6]:44725 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:78159 On 22/09/2014 12:47, vek.m1234@gmail.com wrote: > 1. It's feedback not a mathematical proof. What is? > 2. I hope the OP tries what I suggested - it's all entirely optional. Which is? > > @OP > I have no idea what that program does because it's well commented. You aren't using variable and function names to good effect and are resorting to excessive comments. > > Additionally, I think you are mangling your display text but I'm not sure. > textDisplay.insert should be a function that you pass args to. > > def spit_msg(text): > textDisplay.insert(text) > > spit_msg("go away doo doo bird") > > Any time you see repeated text in your program, wrap it in a single func and simplify. > > try: > def create_root_window(): > rather than letting all your funny parts dangle around naked. > Google groups rides again? -- My fellow Pythonistas, ask not what our language can do for you, ask what you can do for our language. Mark Lawrence