Path: csiph.com!usenet.pasdenom.info!news.franciliens.net!fdn.fr!usenet-fr.net!nerim.net!novso.com!newsfeed.xs4all.nl!newsfeed2.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.084 X-Spam-Evidence: '*H*': 0.83; '*S*': 0.00; '22,': 0.09; 'comments?': 0.09; 'guys.': 0.09; 'url:faqs': 0.09; 'cc:addr:python-list': 0.11; 'mostly': 0.14; 'from:addr:rosuav': 0.16; 'from:name:chris angelico': 0.16; 'readable': 0.16; 'url:catb': 0.16; 'url:hacker- howto': 0.16; 'subject:python': 0.16; 'fix': 0.17; 'wrote:': 0.18; 'cc:addr:python.org': 0.22; "aren't": 0.24; 'mon,': 0.24; 'cc:2**0': 0.24; 'header:In-Reply-To:1': 0.27; 'message- id:@mail.gmail.com': 0.30; "i'm": 0.30; 'code': 0.31; 'comments': 0.31; 'helpful.': 0.31; 'sep': 0.31; 'subject:some': 0.31; 'yourself.': 0.31; 'this.': 0.32; 'text': 0.33; 'something': 0.35; 'but': 0.35; 'received:google.com': 0.35; 'next': 0.36; 'thanks': 0.36; 'url:org': 0.36; 'wrong': 0.37; 'feedback': 0.38; 'pm,': 0.38; 'how': 0.40; 'read': 0.60; 'future': 0.60; 'tips': 0.61; 'such': 0.63; 'become': 0.64; 'great': 0.65; 'six': 0.68; 'obvious': 0.74; 'subject:!!!': 0.74; 'yourself': 0.78; 'subject:get': 0.81; 'commenting': 0.84; 'touched': 0.84; 'subject:Love': 0.91; 'to:none': 0.92; 'imagine': 0.93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type:content-transfer-encoding; bh=zAvp+EcIOa3g+t5H08NWSGjqhlQMkkoT6Oc0tsfMN70=; b=APsA9EFknPZ4sKCd2DNLdiUk1CXx2uJku0l/Pl/GYo+vivI74hqiVwNVnmorONpwK2 rNyXCLoZOtQzz4W0W1nN7EIMhRUC5Hg3sSA4O5dOUPVc/PSmA24UvWPj9DK5Vv/6TMlA 1YfrQe/o/Jj941gimSflijLpFol/oOKLTvRiHpdbQ1JUv0z/rcVS2wnWG9niXrlIC4PA F/cfCTD8ieV2hoYQKrsHFFxPAjN6hEgvSyVnV3BhXcvhJhGlzxolxFT2cfAH1B2subha BQ0QuMPteZm4uone5dSFp0HbByC4dD7xqiTiUr+OcNmjKy4JFCc7PQmYIUdkHLy/lbd4 sc8w== MIME-Version: 1.0 X-Received: by 10.50.66.234 with SMTP id i10mr14431377igt.34.1411392528383; Mon, 22 Sep 2014 06:28:48 -0700 (PDT) In-Reply-To: References: <42e68de9-7528-46fc-8c74-c0baa1d6199e@googlegroups.com> Date: Mon, 22 Sep 2014 23:28:48 +1000 Subject: Re: Love to get some feedback on my first python app!!! From: Chris Angelico Cc: "python-list@python.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 20 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1411392530 news.xs4all.nl 2839 [2001:888:2000:d::a6]:47094 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:78146 On Mon, Sep 22, 2014 at 11:17 PM, Nicholas Cannon wrote: > Ok I'm confused. Do I need to do better comments? I know the text is not = that great but that is my next obstacle I am going to tackle. I mostly need= to know where I am going wrong such as what is expectable readable code an= d what is not and how to fix this. This is good feedback thanks to all of y= ou guys. All I want to do is learn and become better and neater! > Your comments aren't terrible. Just imagine yourself reading this code six months from now, having not touched it in between, and imagine all the questions you'd ask yourself. Then answer them. Conversely, if something would be patently obvious to your future self, don't bother commenting it. Have a read of some of the tips here. You may find them helpful. http://www.catb.org/esr/faqs/hacker-howto.html ChrisA