Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!news.swapon.de!eternal-september.org!feeder.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail From: Marko Rauhamaa Newsgroups: comp.lang.python Subject: Re: ThreadPoolExecutor - callback guaranteed to run in same thread as the submitted function? Date: Thu, 25 Sep 2014 12:46:55 +0300 Organization: A noiseless patient Spider Lines: 28 Message-ID: <871tr06nhs.fsf@elektro.pacujo.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: mx05.eternal-september.org; posting-host="ff5cf27ef3d5b31f034d3b72bdc27a41"; logging-data="5979"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX18AVK3J+xuCdcyX4sw5C6cS" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) Cancel-Lock: sha1:N2cpEQB/XosK7d9uNbesmrNI6zw= sha1:BPjlNVhu8muqtI4h0bLT9ES9u68= Xref: csiph.com comp.lang.python:78332 Ian Kelly : > The documentation for Future.add_done_callback says: "If the future > has already completed or been cancelled, fn will be called > immediately." That sounds really bad. There should be a guarantee that the callback is not called from the same thread before returning from Future.add_done_callback. Otherwise, the caller may have a really difficult time handling preemption and avoiding deadlocks at the same time. Example (pseudocode): def callback(self): with self.lock: ... def xyz(self, f): with self.lock: ... f.add_done_callback(self.callback) The code will deadlock if the callback is invoked immediately. Marko