Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!1.eu.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!eternal-september.org!feeder.eternal-september.org!mx02.eternal-september.org!.POSTED!not-for-mail
From: Ben Bacarisse <ben.usenet@bsb.me.uk>
Newsgroups: comp.lang.javascript
Subject: Re: Why does it slow down for bases above 10?
Date: Fri, 15 May 2015 23:34:05 +0100
Organization: A noiseless patient Spider
Lines: 62
Message-ID: <877fs91ndu.fsf@bsb.me.uk>
References: <149684fb-a50c-4a73-ba20-f7f392f1ce5c@googlegroups.com> <bdffa5ba-4192-4112-8a5a-cce6b349aef2@googlegroups.com> <87oall1slp.fsf@bsb.me.uk> <2805604.EO7ul1Ts0Q@PointedEars.de> <f302e2cc-e93c-4901-9f74-3451814bbf45@googlegroups.com>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: mx02.eternal-september.org; posting-host="017616aa25f81ec581c44d76d61ba2f3"; logging-data="31394"; mail-complaints-to="abuse@eternal-september.org";	posting-account="U2FsdGVkX18qx55Td+9LhP8UrOyM25aoT/z/JEEmvp0="
Cancel-Lock: sha1:Mq8gpJUdZN2f42LbCUwfojfRuq4= sha1:Qt7RzUcFoGXEd1HK1dggjaBfTLc=
X-BSB-Auth: 1.056e82b02fccda59214c.20150515233405BST.877fs91ndu.fsf@bsb.me.uk
Xref: csiph.com comp.lang.javascript:27651

jonas.thornvall@gmail.com writes:

> Den fredag 15 maj 2015 kl. 23:24:15 UTC+2 skrev Thomas 'PointedEars' Lahn:
>> Ben Bacarisse wrote:
>> 
>> > jonas.thornvall@gmail.com writes:
>> >> Den fredag 15 maj 2015 kl. 20:58:10 UTC+2 skrev jonas.t...@gmail.com:
>> >>> http://jt.node365.se/baseconversion.html
>> >>
>> >> If someone can point out the bug for base above 10 in my generic
>> >> basechanger it would be great.
>> > 
>> > That's unlikely.  The code is some of the least inviting I've ever seen.
>> > Global variables all over the place.  Functions that should return
>> > values depositing results into globals instead.  Names that carry little
>> > or no meaning ("loop", "looptwo", "arrCompareTwo").  It's almost
>> > impossible to follow.
>> 
>> Add to that
>> 
>> <http://validator.w3.org/check?uri=jt.node365.se%2Fbaseconversion.html&ss=1&verbose=1>
>> 
>> All that is to be expected when a wannabe does "javascript".
>> 
>> -- 
>> PointedEars
>> FAQ: <http://PointedEars.de/faq> | SVN: <http://PointedEars.de/wsvn/>
>> Twitter: @PointedEars2 | ES Matrix: <http://PointedEars.de/es-matrix>
>> Please do not cc me. / Bitte keine Kopien per E-Mail.
>
> Well i am more of a do just do it kind of programmer, if you want a
> fully fledged optimized generic basechanger that even do
> bignumbs. That would be a quite challenging task. Especially if you
> want to use Javascript to it's full potential.

No, that's not the aim.  Your aim is simply to get the code to work but
you've make it it too complicated for you to understand and too
complicated for anyone else to try to understand.  I suppose you might e
able to work out what's wrong, but it seems unlikely.  And if you do,
you'll hit another bug, and another and another... because the structure
of the code makes more bugs inevitable.

<snip>
> And it is a generic basechanger working on bignumbs afterall so it is
> not preciely easy logic.

The logic is easy if you decompose the problem into the right
components, but you've make all the parts interlinked through globals.

> I was concentrated on get it to work, and i am partially
> there. Optimization would rather be to implement the search for
> digitplace rather than, make the code wonderful.
>
> Fixing details can always be done when something working, or partially
> working.

Generations of programmers have found that this approach does not work.
You have to get the right structure to stat with or the program just
gets more and more impenetrable as it develops.

-- 
Ben.