Path: csiph.com!weretis.net!feeder4.news.weretis.net!news.mb-net.net!open-news-network.org!.POSTED.35.233.197.178.dynamic.wless.lssmb00p-cgnat.res.cust.swisscom.ch!not-for-mail
From: Thomas 'PointedEars' Lahn <PointedEars@web.de>
Newsgroups: comp.lang.javascript
Subject: Re: Cloning an object
Date: Thu, 05 Jul 2018 23:35:18 +0200
Organization: PointedEars Software (PES)
Lines: 49
Message-ID: <5399415.lOV4Wx5bFT@PointedEars.de>
References: <aYCdnU3Tes0_oLbGnZ2dnUU7-LHNnZ2d@westnet.com.au> <1620852.VI2in3QvqR@PointedEars.de> <d9423a2c-3ca3-7571-6fa0-aca40b1c6d0f@PointedEars.de> <9909bfec-c6e7-2a4a-2a54-ec9f271691c8@PointedEars.de> <phdcst$1hro$1@csiph.com> <4395113.31r3eYUQgx@PointedEars.de> <phkj7m$2ugj$1@csiph.com> <506b67da-b086-3d0e-5985-d0f8214da432@PointedEars.de> <phloi4$kb2$1@csiph.com>
Reply-To: Thomas 'PointedEars' Lahn <usenet@PointedEars.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8Bit
Injection-Info: gwaiyur.mb-net.net; posting-host="35.233.197.178.dynamic.wless.lssmb00p-cgnat.res.cust.swisscom.ch:178.197.233.35"; logging-data="8942"; mail-complaints-to="abuse@open-news-network.org"
User-Agent: KNode/4.14.2
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXTxa4RFk5dUWANED8PFEfy7+MGBiW+n3ZNF/QuAAACaElEQVQ4jVXUwVOcMBQG8Dc7Rc4PUntdWV2uxjDpGaGeozOp1woar4jd5t/v9wLstMwsA/ntlxdCAgUc1hjTc9/JCZfGoo3wG3HdmdAWrIJRHe7GM/TmpY5VFefuVcAkkPbLIaN8rmPmjloyZxgyR3GuJ4K0AGtJ2htz8o7yqikm759fldQXaMpbDzjKAG+8v+AugVTOPO5DOjLvGtUYQwh0CPjnVMyGd+8/GfUB5nLKJDD2aLDh5HYyMDJGDwQIo2ZmZcKbowNmAdB/AzyFhrmF2MHRb0QJJfaAnwGB6orZhoykLzJtGwF/xpYxI1dswomiUj3gTuAIqCn/4C7cULwGNBtwMTk3Y4LfKB5YUaOKBKYtpplm7u0vip8tU1NWWyI/7XdcSuIDoMt6rVHMWT0DbjHPGqDqZVSa6zleLcUTcIKLoMv3ueJluALtAo9B302zPPlrtiVScRdCjXvVh3e3JpYa/jjkuC9N+LrBMlz/eAN4eQijX2EdLo6c5tGGHwLyHFtXk89dDGHwCVhG9T0S/j55AhRZgkMCmUQXJ49TnS1wnQDvw0eAh9ICeMmEFbCnPMFzjAvsWoEWEFdYEx+S0MoUZ1gT1wId8+AF3Bl2OoEu906AUHx5VLw/gXYg/x84loOah/2UYNrgiwSwGO7RfUzVBbx/kgpckumGOi6QirtD6gkLTitbnxNol47S2jVc2vsN5kPqaAHT8uUdAJM4v/DanjYOwmUjWznGfwB7sGtAtor5BgofDuzaRj4kSQAqDakTsKORa3Q3xKi3gE1fhl71KRMqrdZ2AWNNg/YOhQyrVBnb+i+nEg4bsDA+egAAAABJRU5ErkJggg==
Cancel-Lock: sha1:Cr0vfA16hE69zWVeeZ4PndekD8A=
X-Face: %i>XG-yXR'\"2P/C_aO%~;2o~?g0pPKmbOw^=NT`tprDEf++D.m7"}HW6.#=U:?2GGctkL,f89@H46O$ASoW&?s}.k+&.<b';Md8`dH6iqhT)6C^.Px|[=M@7=Ik[_w<%n1Up"LPQNu2m8|L!/3iby{-]A+#YE}Kl{Cw$\U!kD%K}\2jz"QQP6Uqr],./"?;=4v
X-User-ID: U2FsdGVkX1+o/c4gvzQj9n9s9d0gWpZJV+TjeKe09PNwy3JMONRaOQ==
Xref: csiph.com comp.lang.javascript:35354

Cezary Tomczyk wrote:

> On 05/07/2018 19:49, Thomas 'PointedEars' Lahn wrote:
>> Cezary Tomczyk wrote:
>>> On 04/07/2018 23:25, Thomas 'PointedEars' Lahn wrote:
>>>>     function clone (obj, deepCopy)
                              ^^^^^^^^
>>>>     {
>>>>       […]
>>>>       Object.getOwnPropertyNames(obj).forEach((name) => {
>>>>         […]
>>>>         if (deepCopy)
                 ^^^^^^^^
>>>>         {
>>>>           /* FIXME: Standardize Object.isObject() */
>>>>           if (/* […] */)
>>>>           {
>>>>             DESC.value = clone(DESC.value);
                                              ^^
>>>>           }
>>>> […]
>>> It passes for simple objects, but if the property has a value as an
>>> array or Date object then it doesn't work.
>> I agree regarding Date instances, but where is the problem with Array
>> instances?
> 
> It doesn't create a real Array copy. Try clone following object:
> 
> […]
> var cloned = clone(o);
                      ^^
> […]
> 
> This test doesn't pass. Basically, modifications on original object
> should not modify cloned object.

In a way it both works as designed and in another it is b0rken as designed: 

You forgot to tell clone() to make a deep copy – as did I in the code above 
(but not in my later tests) :)

.
.
.

-- 
PointedEars
FAQ: <http://PointedEars.de/faq> | <http://PointedEars.de/es-matrix>
<https://github.com/PointedEars> | <http://PointedEars.de/wsvn/>
Twitter: @PointedEars2 | Please do not cc me./Bitte keine Kopien per E-Mail.