Path: csiph.com!weretis.net!feeder4.news.weretis.net!feeder5.news.weretis.net!news.solani.org!.POSTED!not-for-mail From: Thomas 'PointedEars' Lahn Newsgroups: comp.lang.javascript Subject: Re: Object.defineProperties Date: Fri, 05 May 2017 20:11:54 +0200 Organization: PointedEars Software (PES) Lines: 66 Message-ID: <1592229.TLkxdtWsSY@PointedEars.de> References: <1943190.NgBsaNRSFp@PointedEars.de> Reply-To: Thomas 'PointedEars' Lahn Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8Bit X-Trace: solani.org 1494007915 31846 eJwFwQkBgAAIA8BKIBtgHPn6R/CO5uodcDp4vPl8Nym679QJqgtahlyVwOgUFhxLPhPX8QMu5xGM (5 May 2017 18:11:55 GMT) X-Complaints-To: abuse@news.solani.org NNTP-Posting-Date: Fri, 5 May 2017 18:11:55 +0000 (UTC) User-Agent: KNode/4.14.2 X-User-ID: eJwNzAkBACEIBMBKiixCnJWnf4S7CTA4ti2vGkwxmDvbkUyB7pOjsa5UvNb2KgZNjFztImQ7AGZuesafnPXqA19ZFhw= Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXTxa4RFk5dUWANED8PFEfy7+MGBiW+n3ZNF/QuAAACaElEQVQ4jVXUwVOcMBQG8Dc7Rc4PUntdWV2uxjDpGaGeozOp1woar4jd5t/v9wLstMwsA/ntlxdCAgUc1hjTc9/JCZfGoo3wG3HdmdAWrIJRHe7GM/TmpY5VFefuVcAkkPbLIaN8rmPmjloyZxgyR3GuJ4K0AGtJ2htz8o7yqikm759fldQXaMpbDzjKAG+8v+AugVTOPO5DOjLvGtUYQwh0CPjnVMyGd+8/GfUB5nLKJDD2aLDh5HYyMDJGDwQIo2ZmZcKbowNmAdB/AzyFhrmF2MHRb0QJJfaAnwGB6orZhoykLzJtGwF/xpYxI1dswomiUj3gTuAIqCn/4C7cULwGNBtwMTk3Y4LfKB5YUaOKBKYtpplm7u0vip8tU1NWWyI/7XdcSuIDoMt6rVHMWT0DbjHPGqDqZVSa6zleLcUTcIKLoMv3ueJluALtAo9B302zPPlrtiVScRdCjXvVh3e3JpYa/jjkuC9N+LrBMlz/eAN4eQijX2EdLo6c5tGGHwLyHFtXk89dDGHwCVhG9T0S/j55AhRZgkMCmUQXJ49TnS1wnQDvw0eAh9ICeMmEFbCnPMFzjAvsWoEWEFdYEx+S0MoUZ1gT1wId8+AF3Bl2OoEu906AUHx5VLw/gXYg/x84loOah/2UYNrgiwSwGO7RfUzVBbx/kgpckumGOi6QirtD6gkLTitbnxNol47S2jVc2vsN5kPqaAHT8uUdAJM4v/DanjYOwmUjWznGfwB7sGtAtor5BgofDuzaRj4kSQAqDakTsKORa3Q3xKi3gE1fhl71KRMqrdZ2AWNNg/YOhQyrVBnb+i+nEg4bsDA+egAAAABJRU5ErkJggg== X-Face: %i>XG-yXR'\"2P/C_aO%~;2o~?g0pPKmbOw^=NT`tprDEf++D.m7"}HW6.#=U:?2GGctkL,f89@H46O$ASoW&?s}.k+&. On 05/05/2017 18:14, Thomas 'PointedEars' Lahn wrote: >> Cezary Tomczyk wrote: > [...] >>> I use: >>> >>> function isTypeOf(obj, typeToCheck) { >>> if (arguments.length < 2) { >>> return false; >>> } >>> return Object.prototype.toString.call(obj).slice(8, >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> -1).toLowerCase() === typeToCheck.toLowerCase(); >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> } >>> >>> which gives me more precisely a type of object. >> I hope you have optimized that somewhat. > > I can't find a reliable way at the moment. Perhaps I should combine few > methods, but that might be an overengineering. To begin with, you should have var _toString = {}.toString; function isTypeOf(obj, typeToCheck) { if (arguments.length < 2) { return false; } return _toString.call(obj).slice(8, -1).toLowerCase() === typeToCheck.toLowerCase(); } >>> The Object.defineProperties says about object, but function, array are >>> also objects. That's why: >>> >>> if (typeof obj !== 'object' || obj === null) >>> throw new TypeError('bad obj'); >>> >>> looks like a bug to me. >> typeof [] === "object", so that is OK. (common misconception) > > In a sense of that [] is an object - yes, but I'd prefer to know that > tested object is in fact an Array type. Operator instanceof looks > promising, but I need to check it anyway. Array.isArray() exists (since ECMAScript Ed. 5). For general and own (array) types, I am using “instanceof” or “constructor”. Most of the time, though, duck typing instead (“quack” ;-)). >> typeof function () {} === "function", so that is not OK in theory; >> however, one might decide that it is not OK to modify function objects. > > Functions are objects so they can be extended like any other objects. They also have built-in, non-inherited, read-only properties. I augment function objects only as a last resort (currently, to tag them as user- defined). -- PointedEars FAQ: | | Twitter: @PointedEars2 | Please do not cc me./Bitte keine Kopien per E-Mail.