Path: csiph.com!aioe.org!news.mb-net.net!open-news-network.org!.POSTED!not-for-mail
From: Thomas 'PointedEars' Lahn <PointedEars@web.de>
Newsgroups: comp.lang.javascript
Subject: Re: Overriding function and adding a bit
Date: Wed, 10 May 2017 19:22:38 +0200
Organization: PointedEars Software (PES)
Lines: 62
Message-ID: <1565645.VLH7GnMWUR@PointedEars.de>
References: <RJGdnYVKAvCI6Y_EnZ2dnUU7-SXNnZ2d@westnet.com.au> <2811137.5fSG56mABF@PointedEars.de>
Reply-To: Thomas 'PointedEars' Lahn <usenet@PointedEars.de>
NNTP-Posting-Host: 170.224.197.178.dynamic.wless.zhbmb00p-cgnat.res.cust.swisscom.ch
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8Bit
X-Trace: gwaiyur.mb-net.net 1494436960 7090 178.197.224.170 (10 May 2017 17:22:40 GMT)
X-Complaints-To: abuse@open-news-network.org
NNTP-Posting-Date: Wed, 10 May 2017 17:22:40 +0000 (UTC)
User-Agent: KNode/4.14.2
X-Face: %i>XG-yXR'\"2P/C_aO%~;2o~?g0pPKmbOw^=NT`tprDEf++D.m7"}HW6.#=U:?2GGctkL,f89@H46O$ASoW&?s}.k+&.<b';Md8`dH6iqhT)6C^.Px|[=M@7=Ik[_w<%n1Up"LPQNu2m8|L!/3iby{-]A+#YE}Kl{Cw$\U!kD%K}\2jz"QQP6Uqr],./"?;=4v
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXTxa4RFk5dUWANED8PFEfy7+MGBiW+n3ZNF/QuAAACaElEQVQ4jVXUwVOcMBQG8Dc7Rc4PUntdWV2uxjDpGaGeozOp1woar4jd5t/v9wLstMwsA/ntlxdCAgUc1hjTc9/JCZfGoo3wG3HdmdAWrIJRHe7GM/TmpY5VFefuVcAkkPbLIaN8rmPmjloyZxgyR3GuJ4K0AGtJ2htz8o7yqikm759fldQXaMpbDzjKAG+8v+AugVTOPO5DOjLvGtUYQwh0CPjnVMyGd+8/GfUB5nLKJDD2aLDh5HYyMDJGDwQIo2ZmZcKbowNmAdB/AzyFhrmF2MHRb0QJJfaAnwGB6orZhoykLzJtGwF/xpYxI1dswomiUj3gTuAIqCn/4C7cULwGNBtwMTk3Y4LfKB5YUaOKBKYtpplm7u0vip8tU1NWWyI/7XdcSuIDoMt6rVHMWT0DbjHPGqDqZVSa6zleLcUTcIKLoMv3ueJluALtAo9B302zPPlrtiVScRdCjXvVh3e3JpYa/jjkuC9N+LrBMlz/eAN4eQijX2EdLo6c5tGGHwLyHFtXk89dDGHwCVhG9T0S/j55AhRZgkMCmUQXJ49TnS1wnQDvw0eAh9ICeMmEFbCnPMFzjAvsWoEWEFdYEx+S0MoUZ1gT1wId8+AF3Bl2OoEu906AUHx5VLw/gXYg/x84loOah/2UYNrgiwSwGO7RfUzVBbx/kgpckumGOi6QirtD6gkLTitbnxNol47S2jVc2vsN5kPqaAHT8uUdAJM4v/DanjYOwmUjWznGfwB7sGtAtor5BgofDuzaRj4kSQAqDakTsKORa3Q3xKi3gE1fhl71KRMqrdZ2AWNNg/YOhQyrVBnb+i+nEg4bsDA+egAAAABJRU5ErkJggg==
Xref: csiph.com comp.lang.javascript:33263

Thomas 'PointedEars' Lahn wrote:

> Andrew Poulos wrote:
>> function ObjLayerMoveTo(x, y) {
>>    /* 100+ lines of spaghetti code */
>> }
>> 
>> […]
>> var myObjLayerMoveTo = window.ObjLayerMoveTo;
>> 
>> window.ObjLayerMoveTo = function(x, y) {
>>    if (this.id == "foo") return;
>>    myObjLayerMoveTo(x, y);
>> };
>> 
>> 
>> Is this the way to approach this?
> 
> No, it should be
> 
>   var myObjLayerMoveTo = ObjLayerMoveTo;
> 
>   ObjLayerMoveTo = function (x, y) {
>      if (this.id == "foo") return;
>      myObjLayerMoveTo(x, y);
>   };
> 
> Do not confuse the “window” object with the ECMAScript global object.

Or, to keep the global namespace clean:

  /* in global context */
  (function (global) {
    var _ObjLayerMoveTo = global.ObjLayerMoveTo;
 
    global.ObjLayerMoveTo = function (x, y) {
       if (this.id == "foo") return;
       _ObjLayerMoveTo(x, y);
    };
  }(this));

or

  /* in global context */
  ObjLayerMoveTo = (function (global) {
    var _ObjLayerMoveTo = global.ObjLayerMoveTo;
 
    return function (x, y) {
       if (this.id == "foo") return;
       _ObjLayerMoveTo(x, y);
    };
  }(this));
 
I recommend either “_ObjLayerMoveTo” or “theirObjLayerMoveTo”, because 
“myObjectLayerMoveTo” would semantically be the function with which you 
override *their* “ObjLayerMoveTo”.

-- 
PointedEars

Twitter: @PointedEars2
Please do not cc me. / Bitte keine Kopien per E-Mail.