Path: csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!1.eu.feeder.erje.net!eternal-september.org!feeder.eternal-september.org!mx02.eternal-september.org!.POSTED!not-for-mail
From: Cecil Westerhof <Cecil@decebal.nl>
Newsgroups: comp.lang.java.programmer
Subject: Re: How to test my @NotEmpty with JUnit
Date: Wed, 22 Jul 2015 12:09:04 +0200
Organization: Decebal Computing
Lines: 74
Message-ID: <87r3o0o667.fsf@Equus.decebal.nl>
References: <87io9jyycu.fsf@Equus.decebal.nl> <moap0a$qil$1@dont-email.me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: mx02.eternal-september.org; posting-host="528adfd6ad074c92fdc6a7f8fb9e23d8"; logging-data="5837"; mail-complaints-to="abuse@eternal-september.org";	posting-account="U2FsdGVkX1/Hw5AHr470b3bwznPOYJ8sZvjvkpgM610="
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Cancel-Lock: sha1:BNHVodF6AwHh0yXa/HX4NxVvAZU= sha1:8zZq75zc1fsojjawGdnDmXi3Ggs=
X-Homepage: http://www.decebal.nl/
Xref: csiph.com comp.lang.java.programmer:32104

On Friday 17 Jul 2015 13:27 CEST, Jeff Higgins wrote:

> On 07/17/2015 04:36 AM, Cecil Westerhof wrote:
>> We have to remove almost every framework used in the code. I
>> started with the @NotEmpty from Hibernate. It was the only class
>> used from Hibernate, so low hanging fruit we thought.
>>
>> I wrote the following implementation:
>>
>> import        java.lang.annotation.Documented;
>> import static java.lang.annotation.ElementType.FIELD;
>> import        java.lang.annotation.Retention;
>> import static java.lang.annotation.RetentionPolicy.RUNTIME;
>> import        java.lang.annotation.Target;
>>
>> import        javax.validation.Constraint;
>> import        javax.validation.constraints.NotNull;
>> import        javax.validation.constraints.Size;
>> import        javax.validation.ReportAsSingleViolation;
>>
>> @Documented
>> @Constraint(validatedBy = {})
>> @Target({ FIELD })
>> @Retention(RUNTIME)
>> @ReportAsSingleViolation
>> @NotNull
>> @Size(min = 1)
>> public @interface NotEmpty {
>> public abstract String message() default "Field has to be filled";
>> }
>>
>>
>> But it should be tested also of-course. So I wrote the following
>> test:
>>
>> import org.junit.Test;
>>
>> class NotEmptyClass {
>> @NotEmpty
>> String notEmpty;
>>
>> NotEmptyClass(String value) {
>> notEmpty = value;
>> }
>> }
>>
>> public class NotEmptyTest {
>> @Test
>> public void firstTest() {
>> new NotEmptyClass(null);
>> }
>> }
>>
>> I would expect this test not to pass, but it does. So clearly I am
>> doing something wrong, but I have no idea what. (This is the first
>> time I really work with annotations.) I did some Googling but until
>> now to no avail. So if someone could point me to the right
>> direction …
>>
> As I stated before I'm not a JPA or JavaEE user so this might be
> CompleteBS. I also did some googling "test custom bean validation"
> and from what I read I wonder why you don't show a
> ConstraintValidator class. And also the JUnit tests I ran across

That was the problem yes. I am complete new to this kind of stuff, but
I learned a lot now. :-D

I'll try to share my findings in the weekend, because I think that
what I have learned could be interesting for other people also.

-- 
Cecil Westerhof
Senior Software Engineer
LinkedIn: http://www.linkedin.com/in/cecilwesterhof