Path: csiph.com!aioe.org!eternal-september.org!feeder.eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail From: Cecil Westerhof Newsgroups: comp.lang.java.programmer Subject: Re: What do you think of my CropImage class Date: Thu, 21 Jul 2016 12:25:18 +0200 Organization: Decebal Computing Lines: 92 Message-ID: <87mvlb70fl.fsf@Equus.decebal.nl> References: <87twfk93vu.fsf@Equus.decebal.nl> <874m7k86ll.fsf@Equus.decebal.nl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: mx02.eternal-september.org; posting-host="12baf5125b19322b899c79c2e3878015"; logging-data="11600"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX1+WH1R2v0jJxG6l2hm2OL2KKtdjCvQ6M4I=" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Homepage: http://www.decebal.nl/ Cancel-Lock: sha1:f+XZdCNCcf2IHuqFYe3zbBUH3nI= sha1:lZH1bh0bQwhSnGkSmBpdL44enNY= Xref: csiph.com comp.lang.java.programmer:35034 On Wednesday 20 Jul 2016 22:46 CEST, Knute Johnson wrote: > On 7/20/2016 12:14, Cecil Westerhof wrote: >> On Wednesday 20 Jul 2016 19:02 CEST, Knute Johnson wrote: >> >>> On 7/20/2016 00:15, Cecil Westerhof wrote: >>>> I need to crop some images and decide to write a Java program for >>>> it. At the moment it is very rudimentary, I plan to add some >>>> functionalities and because I have very little experience with >>>> GUI comments on how to implement the GUI better are welcome. >>>> >>>> >>>> At the moment it is build with my camera's in mind and cropping >>>> for InstaGram, but when it is seen as useful I will make it more >>>> generic. >>>> >>>> >>>> I have a few problems, the most important are: - After loading >>>> the first or a new image the first click makes the image >>>> disappear and painted again. Subsequent clicks do not have this >>>> problem. >>> >>> We'd need to see the code >> >> That is stupid: I thought I had pasted the link, but I did not. >> >:-( >> >> Here it is: >> https://github.com/CecilWesterhof/JavaExamples/blob/master/CropImage/CropImage.java >> > > I looked at your code and find it a bit disjointed (but I do have a > rather linear outlook). I guess it really depends on what you > ultimately are trying to do though. I wrote a better explanation as reply on my original post. If it is still not clear: do not hesitate to ask. > If I were going to write a GUI > program to crop images today, I would: > 1) have a dialog to load an image (you have that) and display it > along with its current dimensions Good extension. > 2) have a method to scale the displayed image so that you can > operate on images bigger than your monitor That is not what I want: I want to see the complete picture. > 3) use something along the lines of my CropComponent to visually > crop the image, showing the dimensions of the crop I was thinking about that. But it has to be scaled down otherwise it does not fit. But I probably could display a 540x540 image. I do not think it is the first thing I will implement, but I certainly will. > 4) display the cropped image and its new dimensions, so it can be > cropped again In a way I am doing that. But it would probably be better to display and only when it is OK to save it. But you know what they say: make it work, then make it better. > or get GIMP cause it does everything for free. That does not work for me. I need to crop exactly 1080x1080. I tried that but found it easier to just call Image Magick convert again and again until I had found the right part. My application is not perfect, but (for me) a lot better. > You might look at > GIMP for their interface, it is really quite good. The image is in > its own dialog and all the tools are in a couple of others for handy > access. Take a look at the Zoom options under the View menu to see > what I mean about #2 above. Well, at the moment I only want to crop a piece out of a picture. ;-) -- Cecil Westerhof Senior Software Engineer LinkedIn: http://www.linkedin.com/in/cecilwesterhof