Re: Readline history bug

From	Chet Ramey <chet.ramey@case.edu>
Newsgroups	gnu.bash.bug
Subject	Re: Readline history bug
Date	2020-02-01 16:31 -0500
Organization	ITS, Case Western Reserve University
Message-ID	<mailman.141.1580592724.2412.bug-bash@gnu.org> (permalink)
References	<GEBO_8wY5MXQyA9XaPplJPssz-_VaRYuLUZ4I3ITmA_1ZbiZQ6pWAQ9PyMYC70ZLlbKxP-ne7QSKXq8Bd6Cy6SzfQksyGwP7ykYgeIrJ-5Y=@protonmail.ch> <f6816c47-b253-e673-442a-13760f7ba11d@case.edu>

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 1/31/20 3:32 PM, A via Bug reports for the GNU Bourne Again SHell wrote:
> The readline package doesn't return the errno for some errors in write_history, append_history, and history_truncate_file.
> This caused an error in the CPython interpreter(at exit time) when the .python_history file was not writable.
> 
> In particular these calls return -1 when the internal`histfile_restore`call fails because`rename`fails. It's fine for`histfile_restore`to return the result from`rename`, but this should be checked for failure (e.g. -1) and handled appropriately by the caller in`history_do_write`and`history_truncate_file`. 

Thanks for the report. This fix will be in the next bash and readline devel
branch pushes.


-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar | Unroll thread

Thread

Re: Readline history bug Chet Ramey <chet.ramey@case.edu> - 2020-02-01 16:31 -0500

csiph-web