Groups | Search | Server Info | Login | Register

Groups > perl.perl5.changes > #34408

[Perl/perl5] 9c9651: Add a test for GH #16854 assertion failure

Show key headers only | View raw

  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 9c9651bdfc0bf3e337e42ce9252164858de66866
      https://github.com/Perl/perl5/commit/9c9651bdfc0bf3e337e42ce9252164858de66866
  Author: Richard Leach <richardleach@users.noreply.github.com>
  Date:   2026-02-25 (Wed, 25 Feb 2026)

  Changed paths:
    M t/lib/croak/toke

  Log Message:
  -----------
  Add a test for GH #16854 assertion failure

The asserting fuzzed test case was:

    format=
    @
    .//
    .

The assertion triggered was:

    Perl_yylex​: Assertion `((char*)PL_scopestack_name[PL_scopestack_ix-1]
    == (char*)"lex_format") || strEQ(PL_scopestack_name[PL_scopestack_ix-1],
    "lex_format")' failed.

This was addressed by:
```
commit b1f87deab83933d92fc290fdecf45641100ff81d
Author: Yves Orton <demerphq@gmail.com>
Date:   Fri Aug 26 18:26:14 2022 +0200

    Stop parsing on first syntax error.

    We try to keep parsing after many types of errors, up to a (current)
    maximum of 10 errors. Continuing after a semantic error (like
    undeclared variables) can be helpful, for instance showing a set of
    common errors, but continuing after a syntax error isn't helpful
    most of the time as the internal state of the parser can get confused
    and is not reliably restored in between attempts. This can produce
    sometimes completely bizarre errors which just obscure the true error,
    and has resulted in security tickets being filed in the past.

    This patch makes the parser stop after the first syntax error, while
    preserving the current behavior for other errors. An error is considered
    a syntax error if the error message from our internals is the literal
    text "syntax error". This may not be a complete list of true syntax
    errors, we can iterate on that in the future.

    This fixes the segfaults reported in Issue #17397, and #16944 and
    likely fixes other "segfault due to compiler continuation after syntax
    error" bugs that we have on record, which has been a recurring issue
    over the years.
```



To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications

Back to perl.perl5.changes | Previous | Next | Find similar

Thread

[Perl/perl5] 9c9651: Add a test for GH #16854 assertion failure perl5-changes@perl.org (Richard Leach via perl5-changes) - 2026-02-25 12:04 -0800

csiph-web