Groups | Search | Server Info | Login | Register
Groups > perl.perl5.changes > #34445
| Newsgroups | perl.perl5.changes |
|---|---|
| Path | csiph.com!fu-berlin.de!bofh.it!nntp.perl.org |
| Xref | csiph.com perl.perl5.changes:34445 |
| Return-Path | <noreply@github.com> |
| Mailing-List | contact perl5-changes-help@perl.org; run by ezmlm |
| Delivered-To | mailing list perl5-changes@perl.org |
| DKIM-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=perl.org; h=date :from:to:message-id:subject:mime-version:content-type :content-transfer-encoding:list-unsubscribe:reply-to; s=dr1; bh= pg+IJsj6pFYWrEd9mNO/4J5zAylCugwPuaoLeTTrHSc=; b=SEVmWnBh3cZyC1hO muWTA0c6abM/SFGu2pRi0+t6OaSVVb+z8W2ugbVNMtUhdV3IPIp4uGLtrocHfCjk je/XrUXMK4MQV9liQ6pXpR9FVYPD+70dFfJ3Rs3E0XDE/LIJwxGM/AcLOmKIU/g3 4vcJLU64QjmjWTyrTQPeZvN9WKEGOblg/rjgHuA8xf2PMG73/KuZaeoNSN4KahdX OjUt08/QolVSLl9Hh3LfnQb3DkQkocbDHPdHcLWYI/UTYkjHel//2nGneXdzdTK7 VtrrRcZi9DMuDRkGrMfCobfg1Pc2ByK4qrj+v/89eacgz+IxB2poKEgl3rZ9OpQk w9GRHQ== |
| Received | (qmail 22336 invoked from network); 10 Mar 2026 23:05:15 -0000 |
| Received | from xx1.develooper.com (147.75.38.233) by x6.develooper.com with SMTP; 10 Mar 2026 23:05:15 -0000 |
| Received | from inbound-egress-11.mailchannels.net (inbound-egress-11.mailchannels.net [23.83.208.2]) by xx1.develooper.com (Postfix) with ESMTP id 887D67C1A6 for <perl5-changes@perl.org>; Tue, 10 Mar 2026 16:05:15 -0700 (PDT) |
| ARC-Seal | i=1; a=rsa-sha256; d=mailchannels.net; s=arc-2022; cv=none; t=1773183914; b=zs4429vQGq14Dy94njVildo4JUMAPdDnH/cChyDpvQ26lFTdNyBY/rdJ6U1pP0sXbvw7GA 53GOp0x0ZGPzhcFUaAw8O0V/YHhVgSVVDPiRSAPUAzgD+GeI7i6oYgQmCwTgc51sWvvMf4 9lMUxheKsCUnXBuHf0CFw7nPYFXSgQ+WjiIHfAXQN2DUNztgvbTtu00sCjB6SsQJz/2nCC ihDSfViToAfJX81Cwy2FsVQrUdNMLSWmC1TYq3h1+17KHqK5/P6eNR/eFRpZMU4+IWt3/B QGgRID58MbqHMhQlMZ0nTlvhloF+fw3RGz2QhGt67Tf1Mzr65z8UdTIYiUmulQ== |
| ARC-Message-Signature | i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1773183914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-unsubscribe: dkim-signature; bh=pg+IJsj6pFYWrEd9mNO/4J5zAylCugwPuaoLeTTrHSc=; b=JdeKNz09SAFpDgBNvINs1zpbX9YjZ+oyAz1pFAhZmOlej9fpZIlli5wSrR2m1uEtI69pTU 2zS6YdloIDYvlP8arjl+BOWc3wbNd5Z5hfz0MyJGf3e6HwB2qYtFOBfhYmJwYZB5qRQoi9 dfGKPK7Nobh9S2i3Th83TO2YKehx3G0W/mdppjasHtlJ2WcG/Z+D91vm7yZKTOGmkn4ati Jy9QeSTs8rvhhyfKxuchgG1AIAD6dvSZWW9OQXWJHdv+oMi+0ZsCzLnJ3Zlnj6Ak6sXFOS esHzeU60yvmQZjUDFA21P3orlaftAoBAty0KynQcrewtRr+Ty2geY75W9DbLQw== |
| ARC-Authentication-Results | i=1; inbound-rspamd-57bbd4d544-6c4zf; none |
| X-Message-ID | YWKlSeT1qovDa8yzV7v0R09Y |
| Received | from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.107.84.214 (trex/7.1.4); Tue, 10 Mar 2026 23:05:14 +0000 |
| Authentication-Results | inbound.mailchannels.net; spf=pass smtp.mailfrom=noreply@github.com; dkim=pass header.d=github.com; dmarc=pass (policy=reject; pct=100; status=pass); arc=none |
| Received-SPF | pass (dmarc-service-78968d7585-9zbg6: domain of github.com designates 192.30.252.201 as permitted sender) client-ip=192.30.252.201; envelope-from=noreply@github.com; helo=out-18.smtp.github.com; |
| Received | from github.com (hubbernetes-node-ee54afe.va3-iad.github.net [10.48.14.65]) by smtp.github.com (Postfix) with ESMTPA id 7E527E0A9C for <perl5-changes@perl.org>; Tue, 10 Mar 2026 16:05:13 -0700 (PDT) |
| Date | Tue, 10 Mar 2026 16:05:13 -0700 |
| To | perl5-changes@perl.org |
| Message-ID | <Perl/perl5/push/refs/heads/blead/905eb9-e75458@github.com> (permalink) |
| Subject | [Perl/perl5] e75458: S_newSVsv_flags_NN_PVxx - ensure that xiv_u and xn... |
| Mime-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Content-Transfer-Encoding | 7bit |
| X-GitHub-Recipient-Address | perl5-changes@perl.org |
| X-Auto-Response-Suppress | All |
| Original-From | Richard Leach <noreply@github.com> |
| Reply-To | Richard Leach <noreply@github.com>, |
| Approved | news@nntp.perl.org |
| From | perl5-changes@perl.org (Richard Leach via perl5-changes) |
Show key headers only | View raw
Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: e754582d735a91352151aa27efb79f25101b7e16
https://github.com/Perl/perl5/commit/e754582d735a91352151aa27efb79f25101b7e16
Author: Richard Leach <richardleach@users.noreply.github.com>
Date: 2026-03-10 (Tue, 10 Mar 2026)
Changed paths:
M sv.c
M t/op/svflags.t
Log Message:
-----------
S_newSVsv_flags_NN_PVxx - ensure that xiv_u and xnv_u are initialized
When added earlier in this development cycle, `S_newSVsv_flags_NN_PVxx`
would only initialize `xiv_u` and `xnv_u` struct members in PVIV, PVNV,
and PVMG types if the relevant `IOK` or `NOK` flags were set. Since the
absence of flags technically means that the contents of these struct
members are not valid for use, skipping initialization seemed like a
way of reducing unnecessary memory store operations.
GH#24242 revealed that `PL_linestr` in _toke.c_ breaks that assumption.
`PL_linestr` behaves as an IV/PV dualvar, but is only `SvPOK` not `SvIOK`.
Given that there is a reasonable chance that this is not the only code
with that kind of behaviour, this commit adds additional initialization
to the branches that would otherwise have left `xiv_u` and/or `xnv_u`
uninitialized.
To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications
Back to perl.perl5.changes | Previous | Next | Find similar
[Perl/perl5] e75458: S_newSVsv_flags_NN_PVxx - ensure that xiv_u and xn... perl5-changes@perl.org (Richard Leach via perl5-changes) - 2026-03-10 16:05 -0700
csiph-web