Groups | Search | Server Info | Login | Register

Groups > perl.perl5.changes > #34410

[Perl/perl5] 81937b: Add internal only macros isEVEN, isODD

Show key headers only | View raw

  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 81937b704070de956d014e40fc10f651420118fa
      https://github.com/Perl/perl5/commit/81937b704070de956d014e40fc10f651420118fa
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M handy.h

  Log Message:
  -----------
  Add internal only macros isEVEN, isODD

It is a bit clearer to use these


  Commit: 692ba8034bbfb48c7a7d1fab236db4b8cd4fbcf0
      https://github.com/Perl/perl5/commit/692ba8034bbfb48c7a7d1fab236db4b8cd4fbcf0
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  numeric.c: Clarify comment


  Commit: 21930453cd303e1e32b683a715885c6d73483b4e
      https://github.com/Perl/perl5/commit/21930453cd303e1e32b683a715885c6d73483b4e
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  Convert output_nonportable() to use a switch()

This makes it cleaner; at the same time, add a commented-out case for
base 10, in case that is ever wanted.


  Commit: d6906d82154ccd998c8c6418746cd7216f14fdb5
      https://github.com/Perl/perl5/commit/d6906d82154ccd998c8c6418746cd7216f14fdb5
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M embed.fnc
    M embed.h
    M inline.h
    M numeric.c
    M proto.h

  Log Message:
  -----------
  Add grok_bin_hex()

grok_bin() and grok_hex() differ from grok_oct() in that they optionally
accept a leading 0x or 0b, based on a flag.  Then they all share common
code.  This commit splits out the check for the leading 0[bx] into a
separate function.

This speeds up the function common to all, since it doesn't have to
check for this possibility.  It slows these two down, as there is an
extra function layer.  The reason to do this is that future commits will
make the common function called in more places where speed matters.


  Commit: 7d9c93315930ae00dc225d0f1c983aa6c3eaa837
      https://github.com/Perl/perl5/commit/7d9c93315930ae00dc225d0f1c983aa6c3eaa837
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_bin_oct_hex: Macroize common expression

The original impetus to do this has gone, but I'm leaving it in because
I can foresee it being useful.


  Commit: 7adc4faeddb0df99dd0ce02c9e62bbfbc8377ae0
      https://github.com/Perl/perl5/commit/7adc4faeddb0df99dd0ce02c9e62bbfbc8377ae0
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_oct_bin_hex: Change OR to addition

Currently an OR is all that is needed as a shift is used to make space
for the next digit.  But a future commit will change that so that we
will need to add the new digit, not just OR it


  Commit: 42bcc1b1bf2d883943b025f0cb467cb23f0f9f54
      https://github.com/Perl/perl5/commit/42bcc1b1bf2d883943b025f0cb467cb23f0f9f54
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M inline.h
    M numeric.c

  Log Message:
  -----------
  grok_bin_oct_hex: Add ability to discard, not overflow

This will be used in a future commit


  Commit: 1afd1c3f629e7ce64672ead8c63ce4a6705db0a2
      https://github.com/Perl/perl5/commit/1afd1c3f629e7ce64672ead8c63ce4a6705db0a2
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_bin_oct_hex: Change 'if's to not use a double negative

For clarity


  Commit: 4f4e8afd5cb5294db85bd6590c248b878fefcd40
      https://github.com/Perl/perl5/commit/4f4e8afd5cb5294db85bd6590c248b878fefcd40
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_bin_oct_hex: Convert chained ternaries to a switch()

This is for clarity and adds an error check.


  Commit: e72252f04fe7ba35f8cf0f006d1d2fed1672e140
      https://github.com/Perl/perl5/commit/e72252f04fe7ba35f8cf0f006d1d2fed1672e140
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_bin_oct_hex: Convert some code to a switch()

This is for clarity, adds an error check, and collapses two calls to
warner().


  Commit: 7d7cde15e484f5cc22fb277bd9e38944862807f8
      https://github.com/Perl/perl5/commit/7d7cde15e484f5cc22fb277bd9e38944862807f8
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M embed.fnc
    M inline.h
    M numeric.c
    M proto.h

  Log Message:
  -----------
  grok_bin_oct_hex: Also accept base 10.

This commit unifies the parsing of strings of integers of all four
common numeric bases.  The next commit will take advantage of this,
resulting in ripping out 80 lines of duplicated logic.  There are other
opportunities for removing code as well.

Integrating these has resulted in some compromises.  These could be
eliminated if we had a regen program that would generate a separate
function tailored for each base.  That could happen later, after things
settle down.

Comments will be added in a future commit documenting the tradeoffs.


  Commit: 28c9daee6fe36a04814f303111c25e1ec9d6cd6e
      https://github.com/Perl/perl5/commit/28c9daee6fe36a04814f303111c25e1ec9d6cd6e
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_number: Convert to use grok_bin_oct_hex

The major part of this function can now be replaced by a call to the
other function.  This saves 80 lines of duplicated logic


  Commit: 6348f16bfd622f864b9907305bcff8003fcad6af
      https://github.com/Perl/perl5/commit/6348f16bfd622f864b9907305bcff8003fcad6af
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M embed.fnc
    M embed.h
    M inline.h
    M numeric.c
    M proto.h

  Log Message:
  -----------
  Rename grok_bin_oct_hex(), and document in perlintern

It now also accepts decimal, so that name no longer is appropriate.
grok_uint_by_base() is what I chose.


  Commit: ff4e1580450c72c870493797400efa7b17ba9121
      https://github.com/Perl/perl5/commit/ff4e1580450c72c870493797400efa7b17ba9121
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_uint_by_base: Fix up comments

The name changed, but the comments didn't.  And capitalize a word


Compare: https://github.com/Perl/perl5/compare/8326d43f0d50...ff4e1580450c

To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications

Back to perl.perl5.changes | Previous | Next | Find similar

Thread

[Perl/perl5] 81937b: Add internal only macros isEVEN, isODD perl5-changes@perl.org (Karl Williamson via perl5-changes) - 2026-02-26 10:12 -0800

csiph-web