Newsgroups: perl.perl5.changes
Path: csiph.com!fu-berlin.de!bofh.it!nntp.perl.org
Xref: csiph.com perl.perl5.changes:34425
Mailing-List: contact perl5-changes-help@perl.org; run by ezmlm
Received-SPF: pass (dmarc-service-79fbc8656b-czmb8: domain of github.com designates 192.30.252.200 as permitted sender) client-ip=192.30.252.200; envelope-from=noreply@github.com; helo=out-17.smtp.github.com;
Date: Tue, 03 Mar 2026 07:46:22 -0800
To: perl5-changes@perl.org
Message-ID: <Perl/perl5/push/refs/heads/blead/746135-c3d324@github.com>
Subject: [Perl/perl5] 83141f: grok_uint_by_base: Change parameter name
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Original-From: Karl Williamson <noreply@github.com>
Reply-To: Karl Williamson <noreply@github.com>,
Approved: news@nntp.perl.org
From: perl5-changes@perl.org (Karl Williamson via perl5-changes)

  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 83141f96c58a460f1cf6073fe96d68971f89ae53
      https://github.com/Perl/perl5/commit/83141f96c58a460f1cf6073fe96d68971f89ae53
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M embed.fnc
    M inline.h
    M numeric.c
    M proto.h

  Log Message:
  -----------
  grok_uint_by_base: Change parameter name

The old name 'result' is misleading.  What gets stored here is an
approximation.  Change to 'approximation'.


  Commit: c3d3248ca915de9378b137bf50cbffdff3a4184a
      https://github.com/Perl/perl5/commit/c3d3248ca915de9378b137bf50cbffdff3a4184a
  Author: Karl Williamson <khw@cpan.org>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  grok_uint_by_base: Avoid to-be-discarded work

The caller indicates if they want an approximation to an overflowing
value by passing a non-NULL pointer to where to store it.

It turns out that this function was calculating that approximation
and then discarding it if the pointer is NULL.

This commit changes to avoid that.  There already was code that
completed the parsing without doing the calculation.  This commit just
moves the block that set the return flags/did warnings to earlier, and
then uses the non-calculating code when no approximation is desired.


Compare: https://github.com/Perl/perl5/compare/746135fdef92...c3d3248ca915

To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications