Newsgroups: perl.perl5.changes
Path: csiph.com!fu-berlin.de!bofh.it!nntp.perl.org
Xref: csiph.com perl.perl5.changes:34443
Mailing-List: contact perl5-changes-help@perl.org; run by ezmlm
Received-SPF: pass (dmarc-service-78968d7585-vnjcm: domain of github.com designates 192.30.252.211 as permitted sender) client-ip=192.30.252.211; envelope-from=noreply@github.com; helo=out-28.smtp.github.com;
Date: Mon, 09 Mar 2026 05:30:04 -0700
To: perl5-changes@perl.org
Message-ID: <Perl/perl5/push/refs/heads/blead/1aa643-3ed243@github.com>
Subject: [Perl/perl5] 3ed243: Add SAVEt_PADSV; fixes memory leak in pp_methstart
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Original-From: Paul Evans <noreply@github.com>
Reply-To: Paul Evans <noreply@github.com>,
Approved: news@nntp.perl.org
From: perl5-changes@perl.org (Paul Evans via perl5-changes)

  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 3ed2439bc15f60b2ab82a0f91b568a32f9c8bd7d
      https://github.com/Perl/perl5/commit/3ed2439bc15f60b2ab82a0f91b568a32f9c8bd7d
  Author: Paul "LeoNerd" Evans <leonerd@leonerd.org.uk>
  Date:   2026-03-09 (Mon, 09 Mar 2026)

  Changed paths:
    M class.c
    M embed.fnc
    M embed.h
    M proto.h
    M regen/embed.pl
    M regen/scope_types.pl
    M scope.c
    M scope_types.h
    M sv.c
    M t/class/field.t

  Log Message:
  -----------
  Add SAVEt_PADSV; fixes memory leak in pp_methstart

The previous commit here (6b450442) intended to fix `pp_methstart` to
allow refaliasing operations on fields. The way it did this had the
unintended side-effect of no longer undoing the `SvREFCNT_inc` applied
to each field, and thus caused every method call to leak SV references
to every field it captured.

This change fixes this, by introducing a new savestack operation,
`SAVEt_PADSV`. This operation saves the current SV in a pad slot, then
on scope exit restores it back by first decrementing the reference count
of *whatever SV* is now found in that pad slot. This was the original
bug in `pp_methstart` that refaliasing into fields highlighted and the
previous commit intended to fix.

In addition to the bugfix, this new savestack operation makes it more
efficient than the previous code, as it combines into a single operation
the two behaviours which previously required two separate ones
(SAVEt_SPTR + SAVEt_CLEARSV).



To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications