Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: Mattia Rizzolo Newsgroups: linux.debian.maint.python Subject: Re: RFS: python-patch 1.16 Date: Tue, 04 Apr 2017 19:40:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Apr 4 17:31:30 2017 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.88 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, PGPSIGNATURE=-5] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5 Mail-Followup-To: debian-python@lists.debian.org, Paolo Greppi MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tpstcocg4ex5q5va" Content-Disposition: inline X-Info: Keep It Simple, Stupid. X-Operating-System: Linux, kernel 4.9.0-2-amd64, inside Debian GNU/Linux 9.0 (stretch) stretch. X-Message-Flag: WARNING!! Outlook sucks. A lot. User-Agent: Every email client sucks, this one just sucks less. X-Debbugs-No-Ack: no thanks I trust my emails to =?utf-8?Q?r?= =?utf-8?B?ZWFjaCB0aGVpciBkZXN0aW5hdGlvbuKApiDimLo=?= X-Mailing-List: archive/latest/14834 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20170404173107.gpvngm3rkc5q3lkn@mapreri.org Approved: robomod@news.nic.it Lines: 119 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: Paolo Greppi X-Original-Date: Tue, 4 Apr 2017 19:31:08 +0200 X-Original-Message-ID: <20170404173107.gpvngm3rkc5q3lkn@mapreri.org> X-Original-References: <351f9b0c-19bd-64ad-4fb7-33d5c6d8b05b@libpf.com> <20161229171739.cyqm5kec6vym5ukn@mapreri.org> Xref: csiph.com linux.debian.maint.python:9459 --tpstcocg4ex5q5va Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Paolo, any news of this package? (explicitly CCing you to be extra sure it'll reach you) (And this is why I prefer RFS bugs, btw, saving me from digging in my mail archive to find this one=E2=80=A6) On Thu, Dec 29, 2016 at 06:17:40PM +0100, Mattia Rizzolo wrote: > On Tue, Nov 29, 2016 at 08:20:23AM +0100, Paolo Greppi wrote: > > Hi, >=20 > Hi! >=20 > FYI, I found your RFS only thanks to the /topic in #debian-python. > Unless you're very lucky most RFSes sent to random mailing lists have a > tendency to get lost/ignored; that's why I suggest you always file a RFS > bug and X-Debbugs-CC the relevant team, unless you know that team is > going to react (like pkg-js recently). >=20 > > I packaged python-patch as per this ITP: > > https://bugs.debian.org/845482, this is the repo: > > https://anonscm.debian.org/cgit/python-modules/packages/python-patch.git > >=20 > > Please someone more experienced than me review it and if it's OK sponsor > > its upload. >=20 > I fixed the file name in the pristine-tar branch (otherwise `origtargz` > ignored it..). >=20 > > Please note that since the pypi tarball has no tests, whereas the github > > tarball has no setup, I choose the latter and added the setup.py with a > > git-dpm/quilt patch. I hope this is correct. >=20 > Yep, that's fine. Please ask upstream to syncronize both, and have > github ship the setup.py, and the tarball the release. >=20 >=20 > more changes I ask you: > * d/changelog: > + please kill the second changelog line; first uploads should only > come with a "first upload" line > + finalize it (dch -r) > * d/control: > + please wrap-and-sort that list of build-deps > + why are you commenting out the Testsuite field? > + Vcs-* are pointing to a repo that's not DPMT's, that's wrong > (furthermore that URL first requires auth, and it gave me a 404, so > I think it's a private repo) > * d/compat: > + please bump to 10 (d/control already have the >=3D 10, so I guess you > just forgot to push this one too) > * d/rules: > + please repspect DEB_BUILD_OPTIONS=3Dnocheck > + please use the method provided by pybuild to properly run the tests > against all supported python versions, against what you just > "built"; I think that one runs only one python version (2.7) > against the original sources. > + you're overriding dh_auto_install when you only want to append > --install-script to the command invoked. Please use > PYBUILD_INSTALL_ARGS=3D--install-scripts=3D... instead. > * d/copyright: > + why are you licensing debian/ under a different license? > + personally I find a lot more readable to have all the file paragraph > at the top, and all stand alone licenses at the bottom > + other/pack.py is under another license > * I: python-patch: new-package-should-not-package-python2-module python-p= atch > + right, I was about to forget about this... > * I: python-patch source: binary-control-field-duplicates-source field "s= ection" in package python-patch >=20 > --=20 > regards, > Mattia Rizzolo >=20 > GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. > more about me: https://mapreri.org : :' : > Launchpad user: https://launchpad.net/~mapreri `. `'` > Debian QA page: https://qa.debian.org/developer.php?login=3Dmattia `- --=20 regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=3Dmattia `- --tpstcocg4ex5q5va Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAljj2FgACgkQCBa54Yx2 K62ZIQ/9Hqf9OqmskIZfhRFhIKAAfDpdZ3EdzfWE1DuAo+5mabgXumURJXpRVRhd UImJ5WWZxGGcjx5kSs5ofr4CfgL2NOffVc8izCvljN5FFZUgj+1+6UyzLsoy49mc OE4AwzP1mfv5wivOFyiTp+qlh+Vq3FMrqJtdNQDvBjrQY9VhX/8uGT96f48S6Y/m 1HIrQgRqRuKdoQCHJMkIQx2dnCCBsAK9g99AmzoYMK98VIO8BklFRSYxl4oU6SGy /HWsw1xZguKumKTUEKUcxFIXt8+gusQKw1yGdARpxCcrArWYY5+p5oCIK7fED+ej Cjv9KtLZnM48kRQBzU9osWZ0t+Vz9hAJ/wjHfmiOu7nvus59h0u3+pS0Jxc6ObVD 7TnEsUkxnNw1TlyX4Y2SBRzbxCQfzRJXAeocwqTXp7gQRlkMh6WIYPNo236gurL4 dpvOjY5KKNwLoDRzIXoCnY+8Xuq1OU3U81gciWAXYc1/wjpRKc6U7AHwdOHzX8hH iQO5vEIMIXmlgKJEAfwm+e4VZ1P5ybbljDDdJqlfqj4uL5kxolJjsIHLSfvYNYC+ 103opMQZmZ8BkTurkl17/eGix0UMKFjE4sSvUtXQu0m2JwV6tDkGQ96NYZH4/REz 3jhANr9RTKVV9GZasnj9gGxJBaWLIKLBAmvbahCtWaq7mbY01Sw= =LzEh -----END PGP SIGNATURE----- --tpstcocg4ex5q5va--