Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Thomas Goirand Newsgroups: linux.debian.maint.python Subject: Re: Adopting factory-boy Date: Thu, 12 May 2016 16:20:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Thu May 12 14:15:06 2016 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5 X-Enigmail-Draft-Status: N1110 Organization: Debian User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailing-List: archive/latest/13855 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/57348FD4.9070503@debian.org Approved: robomod@news.nic.it Lines: 97 Sender: robomod@news.nic.it X-Original-Date: Thu, 12 May 2016 16:14:44 +0200 X-Original-Message-ID: <57348FD4.9070503@debian.org> X-Original-References: <567540B7.8020709@cbaines.net> <20151219180642.GA2584@mitya57.me> <567A8613.50605@debian.org> <567ABE02.1020707@cbaines.net> <5732FBE6.8010409@cbaines.net> <5733236F.3010401@debian.org> <57332604.8060007@cbaines.net> <57342977.10107@debian.org> <57343B11.6080502@cbaines.net> Xref: csiph.com linux.debian.maint.python:8526 On 05/12/2016 10:13 AM, Christopher Baines wrote: > On 12/05/16 07:57, Thomas Goirand wrote: >> On 05/11/2016 02:31 PM, Christopher Baines wrote: >>> On 11/05/16 13:19, Thomas Goirand wrote: >>>> On 05/11/2016 11:31 AM, Christopher Baines wrote: >>>>> On 23/12/15 15:30, Christopher Baines wrote: >>>>>> On 23/12/15 11:31, Thomas Goirand wrote: >>>>>>> I was the maintainer of this package, though I lost interest for = it >>>>>>> because there's no reverse dependency for it. >>>>>> >>>>>> Thanks for packaging it :) >>>>>> >>>>>>> If you want to continue maintaining it within the OpenStack PKG t= eam, >>>>>>> you can do it as well. Though we're not using git-dpm, and rather= a git >>>>>>> tag workflow, you're still free to use whatever workflow you want= there, >>>>>>> as long as the package is well maintained. >>>>>>> >>>>>>> If you need sponsoring for this package, I can review it and uplo= ad it >>>>>>> for you. >>>>>> >>>>>> Great, thanks for the offer. I think I'll have to wait a couple of= weeks >>>>>> to see where things are for packaging this. There is at least one = new >>>>>> dependency for the latest release (python-fake-factory), I have pa= ckaged >>>>>> that, but the tests currently don't pass. Once there is a release = for >>>>>> python-fake-factory, for which the tests pass, and that has been >>>>>> uploaded to Debian, I'll get around to looking at factory-boy agai= n. >>>>> >>>>> Its been quite a few weeks, but the above is now done. The missing >>>>> dependency (python-fake-factory) is now in Debian, and I have updat= ed >>>>> factory-boy to the latest upstream version [1]. >>>>> >>>>> Are you still open to sponsoring this zigo? I have just filled in t= he >>>>> alioth form to become a member of the OpenStack team. >>>>> >>>>> 1: http://git.cbaines.net/factory-boy/ >>>> >>>> Hi, >>>> >>>> I added you as a member of the team. Let me know when I should spons= or >>>> the package. >>> >>> Great, I have pushed the changes to the repository and it is ready fo= r >>> you to review. >> >> Hi, >> >> Please join #debian-openstack-commits to see the build results. >> Currently, the package FTBFS in Jessie's chroot: >> >> https://mitaka-jessie.pkgs.mirantis.com/job/factory-boy/5/console >> >> The type of error you're seeing is most of the time due to the fact yo= u >> didn't push the upstream tags to Git. >=20 > Ok, the script in use there was not using the correct tag (it was > missing a leading "v"), but this is now fixed by modifying GIT_TAG in > the debian/rules makefile. >=20 > However, the package still fails, as fake-factory is not available in > Jessie. Hi, I added fake-factory as backport in that Jenkins server, and now it builds fine. In your Git log, I can read: * Add myself to Uploaders * Add build dependencies on fake-factory and python-ipaddress * Bump Standards-Version to 3.9.8 (no changes required) * Change the gbp.conf upstream-tag to include the v prefix, as this makes git-buildpackage able to find the tags None of this appeared in the debian/changelog. I added them, pushed them to the git, built and upload. Next time, please document all of your packaging changes in debian/changelog. Thanks for your contribution to Debian, Cheers, Thomas Goirand (zigo)