Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: Sandro Tosi Newsgroups: linux.debian.maint.python Subject: Re: python-networkx_1.10-1_amd64.changes ACCEPTED into experimental Date: Wed, 30 Sep 2015 10:50:02 +0200 Message-ID: References:

X-Original-To: Thomas Goirand X-Mailbox-Line: From debian-python-request@lists.debian.org Wed Sep 30 08:40:17 2015 Old-Return-Path: X-Amavis-Spam-Status: No, score=-7.5 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.198, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, LDO_WHITELIST=-5, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -7 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=zWxOl5uEd45qyMj3gOzbUGrChBRKJFCS6THEnwvYmdc=; b=TgskBAXWfXuM1xelFa21O2MDJWKJ+KSHKcuvqnetMsUnmkfslY1qeNSUE/vEHRxjD2 jUoOIhJlccFbP5qoStZprL/3QY2SgrE3SurXgPZGZhyzAxQcJvnMYNawbaj7s4epSHDE bfEaTt5SLROPA54wg3fhSTwA9uWJ8IDlwNCFViroOetneJKrrHmcFrxMvxhNG6Ox14Z8 z/U0XKO04KQB/lrhGkee3QG9rWpXJiYm/euAxIioKofkz4CxhiUlFxqx1rlodZl6Oqqz Lqg8jNqsjK3tDCUoGabYrztTlg/1SV2ZiNYgqL3B0QM7zdfo8rwBFMjXuu0zPdSMC9zl 1joA== X-Received: by 10.112.12.165 with SMTP id z5mr726518lbb.33.1443602371734; Wed, 30 Sep 2015 01:39:31 -0700 (PDT) MIME-Version: 1.0 Sender: robomod@news.nic.it X-Google-Sender-Auth: kmxURyakuCk9o9fvA73ZnVgGoIU Content-Type: text/plain; charset=UTF-8 X-Mailing-List: archive/latest/12672 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CAB4XWXwRXQUT7NUa=n+mAJp+w0FiJr+OUkHUgoZZHiEqBUEbsg@mail.gmail.com Approved: robomod@news.nic.it Lines: 48 Organization: linux.* mail to news gateway X-Original-Cc: debian-python X-Original-Date: Wed, 30 Sep 2015 09:39:01 +0100 X-Original-Message-ID: X-Original-References:

<20150929115535.GA2584@sh73.dev.logilab.fr> <560B9965.1060302@debian.org> X-Original-Sender: sandro.tosi@gmail.com Xref: csiph.com linux.debian.maint.python:7361 On Wed, Sep 30, 2015 at 9:12 AM, Thomas Goirand wrote: > On 09/29/2015 02:11 PM, Sandro Tosi wrote: >>> Are >>> there any specific changes you object to >> >> As for the technical aspects, tests were disabled mentioning they >> access internet (and from the code it is not clear at all if they do, >> and I kinda doubt that) > > It clearly showed access to the outside world when it wasn't blacklisted. really? I re-enabled the test, and this is what I got (pasting and line wrapping will suck): File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_agraph.py", line 218, in networkx.drawing.nx_agraph.graphviz_layout Failed example: pos=nx.graphviz_layout(G) Exception raised: Traceback (most recent call last): File "/usr/lib/python2.7/doctest.py", line 1315, in __run compileflags, 1) in test.globs File "", line 1, in pos=nx.graphviz_layout(G) File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_pydot.py", line 257, in graphviz_layout return pydot_layout(G=G,prog=prog,root=root,**kwds) File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_pydot.py", line 271, in pydot_layout pydot = load_pydot() File "/tmp/buildd/python-networkx-1.10/networkx/drawing/nx_pydot.py", line 47, in load_pydot raise ImportError(msg) ImportError: pydot could not be loaded: http://code.google.com/p/pydot/ is this what you call "clearly showed access"? did you even look at the code? It is just an indication where to download pydot since it cannot be found when running the test.... disabling the test is *wrong* adding a build-dep is *right*. Fix your mistakes or refrain from changing packages you dont understand or care to maintain. -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi